cleanup: Make normalize method const (#341)

varungandhi-src · web-flow · commit 7242afb6bc07 · 2023-05-24T10:02:58.000Z
diff --git a/indexer/Path.cc b/indexer/Path.cc
@@ -78,12 +78,10 @@ bool AbsolutePathRef::isNormalized() const {
   return true;
 }
 
-void AbsolutePathRef::normalize(llvm::SmallVectorImpl<char> &newStorage) {
+void AbsolutePathRef::normalize(llvm::SmallVectorImpl<char> &newStorage) const {
   newStorage.clear();
   newStorage.append(this->asStringView().begin(), this->asStringView().end());
   llvm::sys::path::remove_dots(newStorage);
-  *this =
-      AbsolutePathRef(std::string_view(newStorage.data(), newStorage.size()));
 }
 
 std::optional<AbsolutePathRef> AbsolutePathRef::prefix() const {
diff --git a/indexer/Path.h b/indexer/Path.h
@@ -78,7 +78,7 @@ class AbsolutePathRef {
 
   bool isNormalized() const;
 
-  void normalize(llvm::SmallVectorImpl<char> &newStorage);
+  void normalize(llvm::SmallVectorImpl<char> &newStorage) const;
 
   PathPrefixIterator<AbsolutePathRef> prefixesBegin() const {
     return PathPrefixIterator<AbsolutePathRef>{*this};

Original file line number	Diff line number	Diff line change
`@@ -78,12 +78,10 @@ bool AbsolutePathRef::isNormalized() const {`
`78`	`78`	`return true;`
`79`	`79`	`}`
`80`	`80`
`81`		`-void AbsolutePathRef::normalize(llvm::SmallVectorImpl<char> &newStorage) {`
	`81`	`+void AbsolutePathRef::normalize(llvm::SmallVectorImpl<char> &newStorage) const {`
`82`	`82`	`newStorage.clear();`
`83`	`83`	`newStorage.append(this->asStringView().begin(), this->asStringView().end());`
`84`	`84`	`llvm::sys::path::remove_dots(newStorage);`
`85`		`- *this =`
`86`		`- AbsolutePathRef(std::string_view(newStorage.data(), newStorage.size()));`
`87`	`85`	`}`
`88`	`86`
`89`	`87`	`std::optional<AbsolutePathRef> AbsolutePathRef::prefix() const {`