Skip to content

Commit c83339c

Browse files
sagi1623sagi1623
authored
Revert changes that make parameters local (#39)
As it can be seen in [this](#38 (comment)) comment, I realised making Parameters local was a mistake, as Named arguments is a thing for both C# and VbNet. There are actually test cases in the Expressions file for both C# and VbNet, that I have glimpsed over because of the sheer amount of changes the PR introduced. Sorry once more for the mistake.
1 parent d44ea99 commit c83339c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+1122
-1123
lines changed

‎ScipDotnet/ScipDocumentIndexer.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,6 @@ private static bool IsLocalSymbol(ISymbol sym)
368368
{
369369
return sym.Kind == SymbolKind.Local ||
370370
sym.Kind == SymbolKind.RangeVariable ||
371-
sym.Kind == SymbolKind.Parameter ||
372371
sym.Kind == SymbolKind.TypeParameter ||
373372
sym is IMethodSymbol { MethodKind: MethodKind.LocalFunction } ||
374373
// Anonymous classes/methods have empty names and can not be accessed outside their file.

‎snapshots/output-net6.0/syntax/Main/Classes.cs

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public class Classes
2121
public Classes(int name)
2222
// ^^^^^^^ definition scip-dotnet nuget . . Main/Classes#`.ctor`().
2323
// documentation ```cs\npublic Classes.Classes(int name)\n```
24-
// ^^^^ definition local 0
24+
// ^^^^ definition scip-dotnet nuget . . Main/Classes#`.ctor`().(name)
2525
// documentation ```cs\nint name\n```
2626
{
2727
Name = "name";
@@ -31,10 +31,10 @@ public Classes(int name)
3131
public Classes(string name) => Name = name;
3232
// ^^^^^^^ definition scip-dotnet nuget . . Main/Classes#`.ctor`(+1).
3333
// documentation ```cs\npublic Classes.Classes(string name)\n```
34-
// ^^^^ definition local 1
34+
// ^^^^ definition scip-dotnet nuget . . Main/Classes#`.ctor`(+1).(name)
3535
// documentation ```cs\nstring name\n```
3636
// ^^^^ reference scip-dotnet nuget . . Main/Classes#Name.
37-
// ^^^^ reference local 1
37+
// ^^^^ reference scip-dotnet nuget . . Main/Classes#`.ctor`(+1).(name)
3838

3939
~Classes()
4040
// ^^^^^^^ definition scip-dotnet nuget . . Main/Classes#Finalize().
@@ -60,117 +60,117 @@ public partial class PartialClass
6060
class TypeParameterClass<T>
6161
// ^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#TypeParameterClass#
6262
// documentation ```cs\nclass TypeParameterClass<T>\n```
63-
// ^ definition local 2
63+
// ^ definition local 0
6464
// documentation ```cs\nT\n```
6565
{
6666
}
6767

6868
internal class InternalMultipleTypeParametersClass<T1, T2>
6969
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#InternalMultipleTypeParametersClass#
7070
// documentation ```cs\nclass InternalMultipleTypeParametersClass<T1, T2>\n```
71-
// ^^ definition local 3
71+
// ^^ definition local 1
7272
// documentation ```cs\nT1\n```
73-
// ^^ definition local 4
73+
// ^^ definition local 2
7474
// documentation ```cs\nT2\n```
7575
{
7676
}
7777

7878
interface ICovariantContravariant<in T1, out T2>
7979
// ^^^^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#ICovariantContravariant#
8080
// documentation ```cs\ninterface ICovariantContravariant<in T1, out T2>\n```
81-
// ^^ definition local 5
81+
// ^^ definition local 3
8282
// documentation ```cs\nin T1\n```
83-
// ^^ definition local 6
83+
// ^^ definition local 4
8484
// documentation ```cs\nout T2\n```
8585
{
8686
public void Method1(T1 t1)
8787
// ^^^^^^^ definition scip-dotnet nuget . . Main/Classes#ICovariantContravariant#Method1().
8888
// documentation ```cs\nvoid ICovariantContravariant<in T1, out T2>.Method1(T1 t1)\n```
89-
// ^^ reference local 5
90-
// ^^ definition local 7
89+
// ^^ reference local 3
90+
// ^^ definition scip-dotnet nuget . . Main/Classes#ICovariantContravariant#Method1().(t1)
9191
// documentation ```cs\nT1 t1\n```
9292
{
9393
Console.WriteLine(t1);
94-
// ^^ reference local 7
94+
// ^^ reference scip-dotnet nuget . . Main/Classes#ICovariantContravariant#Method1().(t1)
9595
}
9696

9797
public T2? Method2()
98-
// ^^ reference local 6
98+
// ^^ reference local 4
9999
// ^^^^^^^ definition scip-dotnet nuget . . Main/Classes#ICovariantContravariant#Method2().
100100
// documentation ```cs\nT2? ICovariantContravariant<in T1, out T2>.Method2()\n```
101101
{
102102
return default(T2);
103-
// ^^ reference local 6
103+
// ^^ reference local 4
104104
}
105105
}
106106

107107
public class StructConstraintClass<T> where T : struct
108108
// ^^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#StructConstraintClass#
109109
// documentation ```cs\nclass StructConstraintClass<T> where T : struct\n```
110-
// ^ definition local 8
110+
// ^ definition local 5
111111
// documentation ```cs\nT\n```
112-
// ^ reference local 8
112+
// ^ reference local 5
113113
{
114114
}
115115

116116
public class UnmanagedConstraintClass<T> where T : unmanaged
117117
// ^^^^^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#UnmanagedConstraintClass#
118118
// documentation ```cs\nclass UnmanagedConstraintClass<T> where T : unmanaged\n```
119-
// ^ definition local 9
119+
// ^ definition local 6
120120
// documentation ```cs\nT\n```
121-
// ^ reference local 9
121+
// ^ reference local 6
122122
{
123123
}
124124

125125
public class ClassConstraintClass<T> where T : class
126126
// ^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#ClassConstraintClass#
127127
// documentation ```cs\nclass ClassConstraintClass<T> where T : class\n```
128-
// ^ definition local 10
128+
// ^ definition local 7
129129
// documentation ```cs\nT\n```
130-
// ^ reference local 10
130+
// ^ reference local 7
131131
{
132132
}
133133

134134
public class NonNullableConstraintClass<T> where T : notnull
135135
// ^^^^^^^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#NonNullableConstraintClass#
136136
// documentation ```cs\nclass NonNullableConstraintClass<T> where T : notnull\n```
137-
// ^ definition local 11
137+
// ^ definition local 8
138138
// documentation ```cs\nT\n```
139-
// ^ reference local 11
139+
// ^ reference local 8
140140
{
141141
}
142142

143143
public class NewConstraintClass<T> where T : new()
144144
// ^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#NewConstraintClass#
145145
// documentation ```cs\nclass NewConstraintClass<T> where T : new()\n```
146-
// ^ definition local 12
146+
// ^ definition local 9
147147
// documentation ```cs\nT\n```
148-
// ^ reference local 12
148+
// ^ reference local 9
149149
{
150150
}
151151

152152
public class TypeParameterConstraintClass<T> where T : SomeInterface
153153
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#TypeParameterConstraintClass#
154154
// documentation ```cs\nclass TypeParameterConstraintClass<T> where T : SomeInterface\n```
155-
// ^ definition local 13
155+
// ^ definition local 10
156156
// documentation ```cs\nT\n```
157-
// ^ reference local 13
157+
// ^ reference local 10
158158
// ^^^^^^^^^^^^^ reference scip-dotnet nuget . . Main/SomeInterface#
159159
{
160160
}
161161

162162
private class MultipleTypeParameterConstraintsClass<T1, T2> where T1 : SomeInterface, SomeInterface2, new()
163163
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#MultipleTypeParameterConstraintsClass#
164164
// documentation ```cs\nclass MultipleTypeParameterConstraintsClass<T1, T2> where T1 : SomeInterface, SomeInterface2, new() where T2 : SomeInterface2\n```
165-
// ^^ definition local 14
165+
// ^^ definition local 11
166166
// documentation ```cs\nT1\n```
167-
// ^^ definition local 15
167+
// ^^ definition local 12
168168
// documentation ```cs\nT2\n```
169-
// ^^ reference local 14
169+
// ^^ reference local 11
170170
// ^^^^^^^^^^^^^ reference scip-dotnet nuget . . Main/SomeInterface#
171171
// ^^^^^^^^^^^^^^ reference scip-dotnet nuget . . Main/SomeInterface2#
172172
where T2 : SomeInterface2
173-
// ^^ reference local 15
173+
// ^^ reference local 12
174174
// ^^^^^^^^^^^^^^ reference scip-dotnet nuget . . Main/SomeInterface2#
175175
{
176176
}
@@ -184,14 +184,14 @@ class IndexClass
184184
// documentation ```cs\nprivate bool IndexClass.a\n```
185185

186186
public bool this[int index]
187-
// ^^^^^ definition local 16
187+
// ^^^^^ definition scip-dotnet nuget . . Main/Classes#IndexClass#`this[]`.(index)
188188
// documentation ```cs\nint index\n```
189189
{
190190
get { return a; }
191191
// ^ reference scip-dotnet nuget . . Main/Classes#IndexClass#a.
192192
set { a = value; }
193193
// ^ reference scip-dotnet nuget . . Main/Classes#IndexClass#a.
194-
// ^^^^^ reference local 17
194+
// ^^^^^ reference scip-dotnet nuget . . Main/Classes#IndexClass#set_Item().(value)
195195
}
196196
}
197197

0 commit comments

Comments
 (0)