Skip to content

Commit 280203c

Browse files
Strum355Strum355
committed
dont emit references for 'this'
1 parent 0bbdd1e commit 280203c

35 files changed

+7
-149
lines changed

‎semanticdb-javac/src/main/java/com/sourcegraph/semanticdb_javac/GlobalSymbolsCache.java‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,6 @@ private SemanticdbSymbols.Descriptor semanticdbDescriptor(Symbol sym) {
8080
return new SemanticdbSymbols.Descriptor(
8181
SemanticdbSymbols.Descriptor.Kind.TypeParameter, sym.name.toString());
8282
} else if (sym instanceof Symbol.VarSymbol) {
83-
if (sym.name.toString().equals("this")) {
84-
return new SemanticdbSymbols.Descriptor(SemanticdbSymbols.Descriptor.Kind.None, "");
85-
}
8683
return new SemanticdbSymbols.Descriptor(
8784
SemanticdbSymbols.Descriptor.Kind.Term, sym.name.toString());
8885
} else {

‎semanticdb-javac/src/main/java/com/sourcegraph/semanticdb_javac/SemanticdbVisitor.java‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@ public Void visitVariable(VariableTree node, Void unused) {
193193
public Void visitIdentifier(IdentifierTree node, Void unused) {
194194
if (node instanceof JCTree.JCIdent) {
195195
JCTree.JCIdent ident = (JCTree.JCIdent) node;
196+
if (ident.name.toString().equals("this")) return null;
196197
emitSymbolOccurrence(ident.sym, ident, Role.REFERENCE, CompilerRange.FROM_START_TO_END);
197198
}
198199
return super.visitIdentifier(node, unused);

‎tests/snapshots/src/main/generated/com/airbnb/epoxy/AsyncEpoxyController.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ public abstract class AsyncEpoxyController extends EpoxyController {
3232
public AsyncEpoxyController() {
3333
// ^^^^^^^^^^^^^^^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyController#`<init>`(). public AsyncEpoxyController()
3434
this(true);
35-
// ^^^^ reference com/airbnb/epoxy/AsyncEpoxyController#`<init>`(+1).
3635
}
3736

3837
/**
@@ -43,7 +42,6 @@ public AsyncEpoxyController(boolean enableAsync) {
4342
// ^^^^^^^^^^^^^^^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyController#`<init>`(+1). public AsyncEpoxyController(boolean enableAsync)
4443
// ^^^^^^^^^^^ definition local0 boolean enableAsync
4544
this(enableAsync, enableAsync);
46-
// ^^^^ reference com/airbnb/epoxy/AsyncEpoxyController#`<init>`(+2).
4745
// ^^^^^^^^^^^ reference local0
4846
// ^^^^^^^^^^^ reference local0
4947
}

‎tests/snapshots/src/main/generated/com/airbnb/epoxy/AsyncEpoxyDiffer.java‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -93,16 +93,13 @@ interface ResultCallback {
9393
// ^^^^^^^^^^^^ definition local3 @NonNull unresolved_type diffCallback
9494
) {
9595
this.executor = new HandlerExecutor(handler);
96-
// ^^^^ reference com/airbnb/epoxy/AsyncEpoxyDiffer#
9796
// ^^^^^^^^ reference com/airbnb/epoxy/AsyncEpoxyDiffer#executor.
9897
// ^^^^^^^^^^^^^^^ reference com/airbnb/epoxy/HandlerExecutor#`<init>`().
9998
// ^^^^^^^ reference local1
10099
this.resultCallback = resultCallback;
101-
// ^^^^ reference com/airbnb/epoxy/AsyncEpoxyDiffer#
102100
// ^^^^^^^^^^^^^^ reference com/airbnb/epoxy/AsyncEpoxyDiffer#resultCallback.
103101
// ^^^^^^^^^^^^^^ reference local2
104102
this.diffCallback = diffCallback;
105-
// ^^^^ reference com/airbnb/epoxy/AsyncEpoxyDiffer#
106103
// ^^^^^^^^^^^^ reference com/airbnb/epoxy/AsyncEpoxyDiffer#diffCallback.
107104
// ^^^^^^^^^^^^ reference local3
108105
}
@@ -239,7 +236,6 @@ public void submitList(@Nullable final List<? extends EpoxyModel<?>> newList) {
239236
// ^^^^^^^^^^^^ definition local9 @Nullable final List<? extends EpoxyModel<?>> previousList
240237

241238
synchronized (this) {
242-
// ^^^^ reference com/airbnb/epoxy/AsyncEpoxyDiffer#
243239
// Incrementing generation means any currently-running diffs are discarded when they finish
244240
// We synchronize to guarantee list object and generation number are in sync
245241
runGeneration = generationTracker.incrementAndGetNextScheduled();
@@ -530,15 +526,12 @@ private static class DiffCallback extends DiffUtil.Callback {
530526
// ^^^^^^^^^^ reference com/airbnb/epoxy/EpoxyModel#
531527
// ^^^^^^^^^^^^ definition local30 unresolved_type diffCallback
532528
this.oldList = oldList;
533-
// ^^^^ reference com/airbnb/epoxy/AsyncEpoxyDiffer#DiffCallback#
534529
// ^^^^^^^ reference com/airbnb/epoxy/AsyncEpoxyDiffer#DiffCallback#oldList.
535530
// ^^^^^^^ reference local28
536531
this.newList = newList;
537-
// ^^^^ reference com/airbnb/epoxy/AsyncEpoxyDiffer#DiffCallback#
538532
// ^^^^^^^ reference com/airbnb/epoxy/AsyncEpoxyDiffer#DiffCallback#newList.
539533
// ^^^^^^^ reference local29
540534
this.diffCallback = diffCallback;
541-
// ^^^^ reference com/airbnb/epoxy/AsyncEpoxyDiffer#DiffCallback#
542535
// ^^^^^^^^^^^^ reference com/airbnb/epoxy/AsyncEpoxyDiffer#DiffCallback#diffCallback.
543536
// ^^^^^^^^^^^^ reference local30
544537
}

‎tests/snapshots/src/main/generated/com/airbnb/epoxy/BaseEpoxyAdapter.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,6 @@ public EpoxyViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
213213
// ^^^^^ definition local9 EpoxyModel<?> model
214214
// ^^^^^^^^^^^^^^^ reference com/airbnb/epoxy/BaseEpoxyAdapter#viewTypeManager.
215215
// ^^^^^^^^^^^^^^^^^^^ reference com/airbnb/epoxy/ViewTypeManager#getModelForViewType().
216-
// ^^^^ reference com/airbnb/epoxy/BaseEpoxyAdapter#
217216
// ^^^^^^^^ reference local8
218217
View view = model.buildView(parent);
219218
// ^^^^ reference _root_/
@@ -633,7 +632,6 @@ public void setSpanCount(int spanCount) {
633632
// ^^^^^^^^^^^^ definition com/airbnb/epoxy/BaseEpoxyAdapter#setSpanCount(). public void setSpanCount(int spanCount)
634633
// ^^^^^^^^^ definition local44 int spanCount
635634
this.spanCount = spanCount;
636-
// ^^^^ reference com/airbnb/epoxy/BaseEpoxyAdapter#
637635
// ^^^^^^^^^ reference com/airbnb/epoxy/BaseEpoxyAdapter#spanCount.
638636
// ^^^^^^^^^ reference local44
639637
}

‎tests/snapshots/src/main/generated/com/airbnb/epoxy/Carousel.java‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,6 @@ && getPaddingBottom() == 0) {
225225
// ^^^^^^^^^^^^^^^ reference com/airbnb/epoxy/Carousel#SnapHelperFactory#buildSnapHelper().
226226
// ^^^^^^^^^^ reference com/airbnb/epoxy/Carousel#getContext#
227227
// ^^^^^^^^^^^^^^^^^^^^ reference `<any>`#attachToRecyclerView#
228-
// ^^^^ reference com/airbnb/epoxy/Carousel#
229228
}
230229

231230
// Carousels will be detached when their parent recyclerview is
@@ -437,7 +436,6 @@ private int getSpaceForChildren(boolean horizontal) {
437436
// ^^^^^^^^^^ reference local24
438437
return getTotalWidthPx(this)
439438
// ^^^^^^^^^^^^^^^ reference com/airbnb/epoxy/Carousel#getTotalWidthPx().
440-
// ^^^^ reference com/airbnb/epoxy/Carousel#
441439
- getPaddingLeft()
442440
// ^^^^^^^^^^^^^^ reference com/airbnb/epoxy/Carousel#getPaddingLeft#
443441
- (getClipToPadding() ? getPaddingRight() : 0);
@@ -449,7 +447,6 @@ private int getSpaceForChildren(boolean horizontal) {
449447
} else {
450448
return getTotalHeightPx(this)
451449
// ^^^^^^^^^^^^^^^^ reference com/airbnb/epoxy/Carousel#getTotalHeightPx().
452-
// ^^^^ reference com/airbnb/epoxy/Carousel#
453450
- getPaddingTop()
454451
// ^^^^^^^^^^^^^ reference com/airbnb/epoxy/Carousel#getPaddingTop#
455452
- (getClipToPadding() ? getPaddingBottom() : 0);
@@ -950,7 +947,6 @@ public Padding(@Px int paddingPx, @Px int itemSpacingPx) {
950947
// ^^ reference androidx/annotation/Px#
951948
// ^^^^^^^^^^^^^ definition local53 @Px int itemSpacingPx
952949
this(paddingPx, paddingPx, paddingPx, paddingPx, itemSpacingPx, PaddingType.PX);
953-
// ^^^^ reference com/airbnb/epoxy/Carousel#Padding#`<init>`(+2).
954950
// ^^^^^^^^^ reference local52
955951
// ^^^^^^^^^ reference local52
956952
// ^^^^^^^^^ reference local52
@@ -982,7 +978,6 @@ public Padding(
982978
// ^^ reference androidx/annotation/Px#
983979
// ^^^^^^^^^^^^^ definition local58 @Px int itemSpacingPx
984980
this(leftPx, topPx, rightPx, bottomPx, itemSpacingPx, PaddingType.PX);
985-
// ^^^^ reference com/airbnb/epoxy/Carousel#Padding#`<init>`(+2).
986981
// ^^^^^^ reference local54
987982
// ^^^^^ reference local55
988983
// ^^^^^^^ reference local56
@@ -1013,27 +1008,21 @@ private Padding(
10131008
// ^^^^^^^^^^^ definition local64 PaddingType paddingType
10141009

10151010
this.left = left;
1016-
// ^^^^ reference com/airbnb/epoxy/Carousel#Padding#
10171011
// ^^^^ reference com/airbnb/epoxy/Carousel#Padding#left.
10181012
// ^^^^ reference local59
10191013
this.top = top;
1020-
// ^^^^ reference com/airbnb/epoxy/Carousel#Padding#
10211014
// ^^^ reference com/airbnb/epoxy/Carousel#Padding#top.
10221015
// ^^^ reference local60
10231016
this.right = right;
1024-
// ^^^^ reference com/airbnb/epoxy/Carousel#Padding#
10251017
// ^^^^^ reference com/airbnb/epoxy/Carousel#Padding#right.
10261018
// ^^^^^ reference local61
10271019
this.bottom = bottom;
1028-
// ^^^^ reference com/airbnb/epoxy/Carousel#Padding#
10291020
// ^^^^^^ reference com/airbnb/epoxy/Carousel#Padding#bottom.
10301021
// ^^^^^^ reference local62
10311022
this.itemSpacing = itemSpacing;
1032-
// ^^^^ reference com/airbnb/epoxy/Carousel#Padding#
10331023
// ^^^^^^^^^^^ reference com/airbnb/epoxy/Carousel#Padding#itemSpacing.
10341024
// ^^^^^^^^^^^ reference local63
10351025
this.paddingType = paddingType;
1036-
// ^^^^ reference com/airbnb/epoxy/Carousel#Padding#
10371026
// ^^^^^^^^^^^ reference com/airbnb/epoxy/Carousel#Padding#paddingType.
10381027
// ^^^^^^^^^^^ reference local64
10391028
}
@@ -1045,7 +1034,6 @@ public boolean equals(Object o) {
10451034
// ^^^^^^ reference java/lang/Object#
10461035
// ^ definition local65 Object o
10471036
if (this == o) {
1048-
// ^^^^ reference com/airbnb/epoxy/Carousel#Padding#
10491037
// ^ reference local65
10501038
return true;
10511039
}

‎tests/snapshots/src/main/generated/com/airbnb/epoxy/DebugTimer.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ class DebugTimer implements Timer {
2323
// ^^^^^^ reference java/lang/String#
2424
// ^^^ definition local0 String tag
2525
this.tag = tag;
26-
// ^^^^ reference com/airbnb/epoxy/DebugTimer#
2726
// ^^^ reference com/airbnb/epoxy/DebugTimer#tag.
2827
// ^^^ reference local0
2928
reset();
@@ -55,7 +54,6 @@ public void start(String sectionName) {
5554
// ^^^^^^ reference java/lang/System#
5655
// ^^^^^^^^ reference java/lang/System#nanoTime().
5756
this.sectionName = sectionName;
58-
// ^^^^ reference com/airbnb/epoxy/DebugTimer#
5957
// ^^^^^^^^^^^ reference com/airbnb/epoxy/DebugTimer#sectionName.
6058
// ^^^^^^^^^^^ reference local1
6159
}

‎tests/snapshots/src/main/generated/com/airbnb/epoxy/DiffHelper.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,9 @@ class DiffHelper {
7474
// ^^^^^^^ definition local0 BaseEpoxyAdapter adapter
7575
// ^^^^^^^^^^^^^^^ definition local1 boolean immutableModels
7676
this.adapter = adapter;
77-
// ^^^^ reference com/airbnb/epoxy/DiffHelper#
7877
// ^^^^^^^ reference com/airbnb/epoxy/DiffHelper#adapter.
7978
// ^^^^^^^ reference local0
8079
this.immutableModels = immutableModels;
81-
// ^^^^ reference com/airbnb/epoxy/DiffHelper#
8280
// ^^^^^^^^^^^^^^^ reference com/airbnb/epoxy/DiffHelper#immutableModels.
8381
// ^^^^^^^^^^^^^^^ reference local1
8482
adapter.registerAdapterDataObserver(observer);

‎tests/snapshots/src/main/generated/com/airbnb/epoxy/DiffPayload.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ public DiffPayload(EpoxyModel<?> changedItem) {
9090
// ^^^^^^^^^^ reference com/airbnb/epoxy/EpoxyModel#
9191
// ^^^^^^^^^^^ definition local3 EpoxyModel<?> changedItem
9292
this(Collections.singletonList(changedItem));
93-
// ^^^^ reference com/airbnb/epoxy/DiffPayload#`<init>`().
9493
// ^^^^^^^^^^^ reference java/util/Collections#
9594
// ^^^^^^^^^^^^^ reference java/util/Collections#singletonList().
9695
// ^^^^^^^^^^^ reference local3

‎tests/snapshots/src/main/generated/com/airbnb/epoxy/DiffResult.java‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,15 +168,12 @@ private DiffResult(
168168
// ^^^^^^^^^^^^ definition local8 @Nullable unresolved_type differResult
169169
) {
170170
this.previousModels = previousModels;
171-
// ^^^^ reference com/airbnb/epoxy/DiffResult#
172171
// ^^^^^^^^^^^^^^ reference com/airbnb/epoxy/DiffResult#previousModels.
173172
// ^^^^^^^^^^^^^^ reference local6
174173
this.newModels = newModels;
175-
// ^^^^ reference com/airbnb/epoxy/DiffResult#
176174
// ^^^^^^^^^ reference com/airbnb/epoxy/DiffResult#newModels.
177175
// ^^^^^^^^^ reference local7
178176
this.differResult = differResult;
179-
// ^^^^ reference com/airbnb/epoxy/DiffResult#
180177
// ^^^^^^^^^^^^ reference com/airbnb/epoxy/DiffResult#differResult.
181178
// ^^^^^^^^^^^^ reference local8
182179
}

0 commit comments

Comments
 (0)