Emit local symbols for anonymous classes.

Anonymous class symbols can't escape a single compilation unit so they
can use local symbols according to the SemanticDB spec, and for
consistency with the Scala implementation.

Author: olafurpg

semanticdb-javac/src/main/java/com/sourcegraph/semanticdb_javac/GlobalSymbolsCache.java

@@ -39,7 +39,7 @@ private String uncachedSemanticdbSymbol(Symbol sym, LocalSymbolsCache locals) {
     String owner = semanticdbSymbol(sym.owner, locals);
     if (owner.equals(SemanticdbSymbols.NONE)) {
       return SemanticdbSymbols.ROOT_PACKAGE;
-    } else if (sym instanceof Symbol.VarSymbol && sym.isLocal()) {
+    } else if (SemanticdbSymbols.isLocal(owner) || isAnonymousClass(sym) || isLocalVariable(sym)) {
       return locals.put(sym);
     }
     SemanticdbSymbols.Descriptor desc = semanticdbDescriptor(sym);
@@ -53,6 +53,14 @@ private String uncachedSemanticdbSymbol(Symbol sym, LocalSymbolsCache locals) {
     return SemanticdbSymbols.global(owner, desc);
   }
 
+  private boolean isLocalVariable(Symbol sym) {
+    return sym instanceof Symbol.VarSymbol && sym.isLocal();
+  }
+
+  private boolean isAnonymousClass(Symbol sym) {
+    return sym instanceof Symbol.ClassSymbol && sym.name.isEmpty();
+  }
+
   private SemanticdbSymbols.Descriptor semanticdbDescriptor(Symbol sym) {
     if (sym instanceof Symbol.ClassSymbol) {
       return new SemanticdbSymbols.Descriptor(

tests/snapshots/src/main/generated/com/airbnb/epoxy/AsyncEpoxyDiffer.java

@@ -14,16 +14,16 @@ class ControllerModelList extends ModelList {
   private static final ModelListObserver OBSERVER = new ModelListObserver() {
 //                     ^^^^^^^^^^^^^^^^^ reference com/airbnb/epoxy/ModelList#ModelListObserver#
 //                                       ^^^^^^^^ definition com/airbnb/epoxy/ControllerModelList#OBSERVER.
-//                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^ reference com/airbnb/epoxy/ControllerModelList#OBSERVER.``#`<init>`(). 12:3
+//                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^ reference local1 12:3
 //                                                      ^^^^^^^^^^^^^^^^^ reference com/airbnb/epoxy/ModelList#ModelListObserver#
 //                                                      ^^^^^^^^^^^^^^^^^ reference com/airbnb/epoxy/ModelList#ModelListObserver#
-//                                                                          ^ definition com/airbnb/epoxy/ControllerModelList#OBSERVER.``#`<init>`(). 1:4
+//                                                                          ^ definition local1 1:4
     @Override
 //   ^^^^^^^^ reference java/lang/Override#
     public void onItemRangeInserted(int positionStart, int itemCount) {
-//              ^^^^^^^^^^^^^^^^^^^ definition com/airbnb/epoxy/ControllerModelList#OBSERVER.``#onItemRangeInserted().
-//                                      ^^^^^^^^^^^^^ definition local0
-//                                                         ^^^^^^^^^ definition local1
+//              ^^^^^^^^^^^^^^^^^^^ definition local2
+//                                      ^^^^^^^^^^^^^ definition local3
+//                                                         ^^^^^^^^^ definition local4
       throw new IllegalStateException(
 //          ^^^^^^^^^^^^^^^^^^^^^^^^^^ reference java/lang/IllegalStateException#`<init>`(+1). 1:75
 //              ^^^^^^^^^^^^^^^^^^^^^ reference java/lang/IllegalStateException#
@@ -33,9 +33,9 @@ public void onItemRangeInserted(int positionStart, int itemCount) {
     @Override
 //   ^^^^^^^^ reference java/lang/Override#
     public void onItemRangeRemoved(int positionStart, int itemCount) {
-//              ^^^^^^^^^^^^^^^^^^ definition com/airbnb/epoxy/ControllerModelList#OBSERVER.``#onItemRangeRemoved().
-//                                     ^^^^^^^^^^^^^ definition local2
-//                                                        ^^^^^^^^^ definition local3
+//              ^^^^^^^^^^^^^^^^^^ definition local5
+//                                     ^^^^^^^^^^^^^ definition local6
+//                                                        ^^^^^^^^^ definition local7
       throw new IllegalStateException(
 //          ^^^^^^^^^^^^^^^^^^^^^^^^^^ reference java/lang/IllegalStateException#`<init>`(+1). 1:75
 //              ^^^^^^^^^^^^^^^^^^^^^ reference java/lang/IllegalStateException#
@@ -45,10 +45,10 @@ public void onItemRangeRemoved(int positionStart, int itemCount) {
 
   ControllerModelList(int expectedModelCount) {
   ^^^^^^ definition com/airbnb/epoxy/ControllerModelList#`<init>`().
-//                        ^^^^^^^^^^^^^^^^^^ definition local4
+//                        ^^^^^^^^^^^^^^^^^^ definition local8
     super(expectedModelCount);
 //  ^^^^^ reference com/airbnb/epoxy/ModelList#`<init>`().
-//        ^^^^^^^^^^^^^^^^^^ reference local4
+//        ^^^^^^^^^^^^^^^^^^ reference local8
     pauseNotifications();
 //  ^^^^^^^^^^^^^^^^^^ reference com/airbnb/epoxy/ModelList#pauseNotifications().
   }