Skip to content

Commit 63b830e

Browse files
committed
change constructor range from text search to text search from preferred point
1 parent 8fb4663 commit 63b830e

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

semanticdb-javac/src/main/java/com/sourcegraph/semanticdb_javac/RangeFinder.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@ public static Optional<Semanticdb.Range> findRange(
3030
int endPos = (int) trees.getSourcePositions().getEndPosition(root, path.getLeaf());
3131
// false for anonymous classes
3232
if (name.length() != 0) {
33-
// for declared constructors with no modifiers, findNameIn will return -1 as the name will
34-
// not start with a space, the first char is the start of the name
35-
if (source.charAt(startPos) != ' ') startPos -= 1;
3633
startPos = findNameIn(name, startPos, source);
3734
endPos = startPos + name.length();
3835
}
@@ -54,9 +51,9 @@ public static Optional<Semanticdb.Range> findRange(
5451
private static int findNameIn(CharSequence name, int start, String source) {
5552
if (source.equals("")) return -1;
5653

57-
int offset = source.indexOf(" " + name, start);
54+
int offset = source.indexOf(name.toString(), start);
5855
if (offset > -1) {
59-
return offset + 1;
56+
return offset ;
6057
}
6158
return -1;
6259
}

semanticdb-javac/src/main/java/com/sourcegraph/semanticdb_javac/SemanticdbVisitor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ public Void visitMethod(MethodTree node, Void unused) {
157157
JCTree.JCMethodDecl meth = (JCTree.JCMethodDecl) node;
158158
CompilerRange range = CompilerRange.FROM_POINT_TO_SYMBOL_NAME;
159159
if (meth.sym.name.toString().equals("<init>")) {
160-
range = CompilerRange.FROM_TEXT_SEARCH;
160+
range = CompilerRange.FROM_POINT_WITH_TEXT_SEARCH;
161161
}
162162
emitSymbolOccurrence(meth.sym, meth, Role.DEFINITION, range);
163163

0 commit comments

Comments
 (0)