Ignore java/lang/Object relationships

Author: olafurpg

lsif-semanticdb/src/main/java/com/sourcegraph/lsif_semanticdb/LsifSemanticdb.java

@@ -118,9 +118,7 @@ private void processTypedDocument(Path path, PackageTable packages) {
             LsifTyped.SymbolInformation.newBuilder().setSymbol(typedSymbol(info.getSymbol(), pkg));
 
         for (String overriddenSymbol : info.getOverriddenSymbolsList()) {
-          if (overriddenSymbol.equals("java/lang/Object#")) {
-            // Skip java/lang/Object# since it's the parent of all classes
-            // making it noisy for "find implementations" results.
+          if (isIgnoredOverriddenSymbol(overriddenSymbol)) {
             continue;
           }
           Package overriddenSymbolPkg =
@@ -280,16 +278,22 @@ private Integer processDocumentUnsafe(
 
       // Overrides
       if (symbolInformation.getOverriddenSymbolsCount() > 0) {
-        int[] overriddenReferenceResultIds = new int[symbolInformation.getOverriddenSymbolsCount()];
+        List<Integer> overriddenReferenceResultIds =
+            new ArrayList<>(symbolInformation.getOverriddenSymbolsCount());
         for (int i = 0; i < symbolInformation.getOverriddenSymbolsCount(); i++) {
           String overriddenSymbol = symbolInformation.getOverriddenSymbols(i);
+          if (isIgnoredOverriddenSymbol(overriddenSymbol)) {
+            continue;
+          }
           ResultIds overriddenIds = results.getOrInsertResultSet(overriddenSymbol);
-          overriddenReferenceResultIds[i] = overriddenIds.referenceResult;
+          overriddenReferenceResultIds.add(overriddenIds.referenceResult);
+          writer.emitReferenceResultsItemEdge(
+              overriddenIds.referenceResult, Collections.singletonList(rangeId), doc.id);
+        }
+        if (overriddenReferenceResultIds.size() > 0) {
           writer.emitReferenceResultsItemEdge(
-              overriddenIds.referenceResult, new int[] {rangeId}, doc.id);
+              ids.referenceResult, overriddenReferenceResultIds, doc.id);
         }
-        writer.emitReferenceResultsItemEdge(
-            ids.referenceResult, overriddenReferenceResultIds, doc.id);
       }
     }
     writer.emitContains(doc.id, new ArrayList<>(rangeIds));
@@ -324,4 +328,10 @@ private Semanticdb.TextDocuments textDocumentsParseFrom(Path semanticdbPath) thr
       return Semanticdb.TextDocuments.parseFrom(bytes);
     }
   }
+
+  private boolean isIgnoredOverriddenSymbol(String symbol) {
+    // Skip java/lang/Object# since it's the parent of all classes
+    // making it noisy for "find implementations" results.
+    return symbol.equals("java/lang/Object#");
+  }
 }

lsif-semanticdb/src/main/java/com/sourcegraph/lsif_semanticdb/LsifWriter.java

@@ -146,12 +146,11 @@ public void emitItem(int outV, int inV, int document) {
     emitObject(lsifEdge("item").setOutV(outV).addInVs(inV).setDocument(document));
   }
 
-  public void emitReferenceResultsItemEdge(int outV, int[] inVs, int document) {
-    List<Integer> ints = Arrays.stream(inVs).boxed().collect(Collectors.toList());
+  public void emitReferenceResultsItemEdge(int outV, Iterable<Integer> inVs, int document) {
     emitObject(
         lsifEdge("item")
             .setOutV(outV)
-            .addAllInVs(ints)
+            .addAllInVs(inVs)
             .setDocument(document)
             .setProperty("referenceResults"));
   }