Merge pull request #505 from sourcegraph/olafurpg/test-mvnw-executable

Test that gradlew/mvnw/mill are executable files.

Author: olafurpg

scip-java/src/main/scala/com/sourcegraph/scip_java/buildtools/GradleBuildTool.scala

@@ -40,7 +40,9 @@ class GradleBuildTool(index: IndexCommand) extends BuildTool("Gradle", index) {
           "gradlew"
       )
     val gradleCommand: String =
-      if (Files.isRegularFile(gradleWrapper))
+      if (
+        Files.isRegularFile(gradleWrapper) && Files.isExecutable(gradleWrapper)
+      )
         gradleWrapper.toString
       else
         "gradle"

scip-java/src/main/scala/com/sourcegraph/scip_java/buildtools/MavenBuildTool.scala

@@ -30,7 +30,7 @@ class MavenBuildTool(index: IndexCommand) extends BuildTool("Maven", index) {
     TemporaryFiles.withDirectory(index) { tmp =>
       val mvnw = index.workingDirectory.resolve("mvnw")
       val mavenScript =
-        if (Files.isRegularFile(mvnw))
+        if (Files.isRegularFile(mvnw) && Files.isExecutable(mvnw))
           mvnw.toString
         else {
           "mvn"

scip-java/src/main/scala/com/sourcegraph/scip_java/buildtools/MillBuildTool.scala

@@ -38,7 +38,8 @@ class MillBuildTool(index: IndexCommand) extends BuildTool("mill", index) {
   private val rawOutput = index.output.toString
 
   private def unconditionallyGenerateScip(): Int = {
-    val localMill = Files.isRegularFile(millFile)
+    val localMill =
+      Files.isRegularFile(millFile) && Files.isExecutable(millFile)
     val command =
       if (localMill) {
         "./mill"