Skip to content

Commit 8bb41e6

Browse files
committed
fix adding void|scala/Unit# type to signatures
1 parent d82dd45 commit 8bb41e6

File tree

92 files changed

+534
-522
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

92 files changed

+534
-522
lines changed

semanticdb-javac/src/main/java/com/sourcegraph/semanticdb_javac/SemanticdbSignatures.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,13 @@ public Semanticdb.Type visitWildcard(WildcardType t, Void unused) {
234234
.build();
235235
}
236236

237+
@Override
238+
public Semanticdb.Type visitNoType(NoType t, Void unused) {
239+
return Semanticdb.Type.newBuilder()
240+
.setTypeRef(TypeRef.newBuilder().setSymbol(primitiveSymbol(t.getKind())))
241+
.build();
242+
}
243+
237244
public String primitiveSymbol(TypeKind kind) {
238245
switch (kind) {
239246
case BOOLEAN:

tests/minimized/src/main/java/minimized/Primitives.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,6 @@ public static String app() {
1515
boolean h = random.nextBoolean();
1616
return "" + a + b + c + d + e + f + g + h;
1717
}
18+
19+
public static void test() {}
1820
}

tests/snapshots/src/main/generated/com/airbnb/epoxy/AsyncEpoxyController.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public abstract class AsyncEpoxyController extends EpoxyController {
3030
* A new instance that does model building and diffing asynchronously.
3131
*/
3232
public AsyncEpoxyController() {
33-
// ^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyController#`<init>`(). public <init>()
33+
// ^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyController#`<init>`(). public void <init>()
3434
this(true);
3535
// ^^^^ reference com/airbnb/epoxy/AsyncEpoxyController#`<init>`(+1).
3636
}
@@ -40,7 +40,7 @@ public AsyncEpoxyController() {
4040
* both on the main thread.
4141
*/
4242
public AsyncEpoxyController(boolean enableAsync) {
43-
// ^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyController#`<init>`(+1). public <init>(boolean enableAsync)
43+
// ^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyController#`<init>`(+1). public void <init>(boolean enableAsync)
4444
// ^^^^^^^^^^^ definition local0 boolean enableAsync
4545
this(enableAsync, enableAsync);
4646
// ^^^^ reference com/airbnb/epoxy/AsyncEpoxyController#`<init>`(+2).
@@ -52,7 +52,7 @@ public AsyncEpoxyController(boolean enableAsync) {
5252
* Individually control whether model building and diffing are done async or on the main thread.
5353
*/
5454
public AsyncEpoxyController(boolean enableAsyncModelBuilding, boolean enableAsyncDiffing) {
55-
// ^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyController#`<init>`(+2). public <init>(boolean enableAsyncModelBuilding, boolean enableAsyncDiffing)
55+
// ^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyController#`<init>`(+2). public void <init>(boolean enableAsyncModelBuilding, boolean enableAsyncDiffing)
5656
// ^^^^^^^^^^^^^^^^^^^^^^^^ definition local1 boolean enableAsyncModelBuilding
5757
// ^^^^^^^^^^^^^^^^^^ definition local2 boolean enableAsyncDiffing
5858
super(getHandler(enableAsyncModelBuilding), getHandler(enableAsyncDiffing));

tests/snapshots/src/main/generated/com/airbnb/epoxy/AsyncEpoxyDiffer.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class AsyncEpoxyDiffer {
5555
interface ResultCallback {
5656
// ^^^^^^^^^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyDiffer#ResultCallback# abstract static interface ResultCallback
5757
void onResult(@NonNull DiffResult result);
58-
// ^^^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyDiffer#ResultCallback#onResult(). public abstract onResult(DiffResult result)
58+
// ^^^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyDiffer#ResultCallback#onResult(). public abstract void onResult(DiffResult result)
5959
// ^^^^^^^ reference androidx/annotation/NonNull#
6060
// ^^^^^^^^^^ reference com/airbnb/epoxy/DiffResult#
6161
// ^^^^^^ definition local0 DiffResult result
@@ -78,7 +78,7 @@ interface ResultCallback {
7878
// ^^^^^^^^^^^^^^^^^ reference com/airbnb/epoxy/AsyncEpoxyDiffer#GenerationTracker#
7979

8080
AsyncEpoxyDiffer(
81-
//^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyDiffer#`<init>`(). <init>(unresolved_type handler, ResultCallback resultCallback, unresolved_type diffCallback)
81+
//^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyDiffer#`<init>`(). void <init>(unresolved_type handler, ResultCallback resultCallback, unresolved_type diffCallback)
8282
@NonNull Handler handler,
8383
// ^^^^^^^ reference androidx/annotation/NonNull#
8484
// ^^^^^^^ reference _root_/
@@ -227,7 +227,7 @@ public synchronized boolean forceListOverride(@Nullable List<EpoxyModel<?>> newL
227227
@SuppressWarnings("WeakerAccess")
228228
// ^^^^^^^^^^^^^^^^ reference java/lang/SuppressWarnings#
229229
public void submitList(@Nullable final List<? extends EpoxyModel<?>> newList) {
230-
// ^^^^^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyDiffer#submitList(). public submitList(List<? extends EpoxyModel<?>> newList)
230+
// ^^^^^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyDiffer#submitList(). public void submitList(List<? extends EpoxyModel<?>> newList)
231231
// ^^^^^^^^ reference androidx/annotation/Nullable#
232232
// ^^^^ reference java/util/List#
233233
// ^^^^^^^^^^ reference com/airbnb/epoxy/EpoxyModel#
@@ -325,7 +325,7 @@ public void submitList(@Nullable final List<? extends EpoxyModel<?>> newList) {
325325
@Override
326326
// ^^^^^^^^ reference java/lang/Override#
327327
public void run() {
328-
// ^^^ definition local14 public run()
328+
// ^^^ definition local14 public void run()
329329
DiffUtil.DiffResult result = DiffUtil.calculateDiff(wrappedCallback);
330330
// ^^^^^^^^ reference DiffUtil/
331331
// ^^^^^^^^^^ reference DiffUtil/DiffResult#
@@ -347,7 +347,7 @@ public void run() {
347347
}
348348

349349
private void onRunCompleted(
350-
// ^^^^^^^^^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyDiffer#onRunCompleted(). private onRunCompleted(int runGeneration, List<? extends EpoxyModel<?>> newList, DiffResult result)
350+
// ^^^^^^^^^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyDiffer#onRunCompleted(). private void onRunCompleted(int runGeneration, List<? extends EpoxyModel<?>> newList, DiffResult result)
351351
final int runGeneration,
352352
// ^^^^^^^^^^^^^ definition local16 final int runGeneration
353353
@Nullable final List<? extends EpoxyModel<?>> newList,
@@ -373,7 +373,7 @@ private void onRunCompleted(
373373
@Override
374374
// ^^^^^^^^ reference java/lang/Override#
375375
public void run() {
376-
// ^^^ definition local21 public run()
376+
// ^^^ definition local21 public void run()
377377
final boolean dispatchResult = tryLatchList(newList, runGeneration);
378378
// ^^^^^^^^^^^^^^ definition local22 final boolean dispatchResult
379379
// ^^^^^^^^^^^^ reference com/airbnb/epoxy/AsyncEpoxyDiffer#tryLatchList().
@@ -448,7 +448,7 @@ private synchronized boolean tryLatchList(@Nullable List<? extends EpoxyModel<?>
448448
*/
449449
private static class GenerationTracker {
450450
// ^^^^^^^^^^^^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyDiffer#GenerationTracker# private static class GenerationTracker
451-
// ^^^^^^^^^^^^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyDiffer#GenerationTracker#`<init>`(). private <init>()
451+
// ^^^^^^^^^^^^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyDiffer#GenerationTracker#`<init>`(). private void <init>()
452452

453453
// Max generation of currently scheduled runnable
454454
private volatile int maxScheduledGeneration;
@@ -523,7 +523,7 @@ private static class DiffCallback extends DiffUtil.Callback {
523523
// ^^^^^^^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyDiffer#DiffCallback#diffCallback. private final unresolved_type diffCallback
524524

525525
DiffCallback(List<? extends EpoxyModel<?>> oldList, List<? extends EpoxyModel<?>> newList,
526-
// ^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyDiffer#DiffCallback#`<init>`(). <init>(List<? extends EpoxyModel<?>> oldList, List<? extends EpoxyModel<?>> newList, unresolved_type diffCallback)
526+
// ^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyDiffer#DiffCallback#`<init>`(). void <init>(List<? extends EpoxyModel<?>> oldList, List<? extends EpoxyModel<?>> newList, unresolved_type diffCallback)
527527
// ^^^^ reference java/util/List#
528528
// ^^^^^^^^^^ reference com/airbnb/epoxy/EpoxyModel#
529529
// ^^^^^^^ definition local28 List<? extends EpoxyModel<?>> oldList

0 commit comments

Comments
 (0)