Skip to content

Commit a5fd380

Browse files
Drop support for Kotlin 1, only support Kotlin 2.1
1 parent 6ca18c5 commit a5fd380

File tree

5 files changed

+9
-43
lines changed

5 files changed

+9
-43
lines changed

build.sbt

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,7 @@ lazy val V =
2323
val scala3 = "3.3.3"
2424
val metals = "1.2.2"
2525
val scalameta = "4.9.3"
26-
// val semanticdbKotlinc = "0.4.1-SNAPSHOT"
27-
val semanticdbKotlinc = new {
28-
val forKotlin1 = "0.4.0"
29-
val forKotlin2 = "dev-SNAPSHOT"
30-
}
26+
val semanticdbKotlin = "0.5.0"
3127
val testcontainers = "0.39.3"
3228
val requests = "0.8.0"
3329
val minimalMillVersion = "0.10.0"
@@ -142,8 +138,7 @@ lazy val gradlePlugin = project
142138
"sbtSourcegraphVersion" ->
143139
com.sourcegraph.sbtsourcegraph.BuildInfo.version,
144140
"semanticdbVersion" -> V.scalameta,
145-
"semanticdbKotlinc1Version" -> V.semanticdbKotlinc.forKotlin1,
146-
"semanticdbKotlinc2Version" -> V.semanticdbKotlinc.forKotlin2,
141+
"semanticdbKotlincVersion" -> V.semanticdbKotlin,
147142
"mtagsVersion" -> V.metals,
148143
"scala211" -> V.scala211,
149144
"scala212" -> V.scala212,
@@ -271,8 +266,7 @@ lazy val cli = project
271266
"sbtSourcegraphVersion" ->
272267
com.sourcegraph.sbtsourcegraph.BuildInfo.version,
273268
"semanticdbVersion" -> V.scalameta,
274-
"semanticdbKotlinc1Version" -> V.semanticdbKotlinc.forKotlin1,
275-
"semanticdbKotlinc2Version" -> V.semanticdbKotlinc.forKotlin2,
269+
"semanticdbKotlincVersion" -> V.semanticdbKotlin,
276270
"mtagsVersion" -> V.metals,
277271
"scala211" -> V.scala211,
278272
"scala212" -> V.scala212,

scip-java/src/main/scala/com/sourcegraph/scip_java/buildtools/GradleBuildTool.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ class GradleBuildTool(index: IndexCommand) extends BuildTool("Gradle", index) {
100100
val pluginpath = Embedded.semanticdbJar(tmp)
101101
val gradlePluginPath = Embedded.gradlePluginJar(tmp)
102102
val dependenciesPath = targetroot.resolve("dependencies.txt")
103-
// val kotlinSemanticdbVersion = BuildInfo.semanticdbKotlincVersion
104103
Files.deleteIfExists(dependenciesPath)
105104

106105
val script =

scip-java/src/main/scala/com/sourcegraph/scip_java/buildtools/ScipBuildTool.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ class ScipBuildTool(index: IndexCommand) extends BuildTool("SCIP", index) {
240240
Dependencies
241241
.resolveDependencies(
242242
List(
243-
s"com.sourcegraph:semanticdb-kotlinc:${BuildInfo.semanticdbKotlinc2Version}"
243+
s"com.sourcegraph:semanticdb-kotlinc:${BuildInfo.semanticdbKotlincVersion}"
244244
),
245245
transitive = false
246246
)

semanticdb-gradle-plugin/src/main/scala/SemanticdbGradlePlugin.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,13 +333,14 @@ class SemanticdbGradlePlugin extends Plugin[Project] {
333333
def getKotlinOptions(): {
334334
def getFreeCompilerArgs(): ju.List[String]
335335
def setFreeCompilerArgs(args: ju.List[String]): Unit
336+
// def getLanguageVersion(): Any
336337
}
337338
}
338339
]
339340
.getKotlinOptions()
340341

341342
val semanticdbkotlincDependency =
342-
s"com.sourcegraph:semanticdb-kotlinc:${BuildInfo.semanticdbKotlinc1Version}"
343+
s"com.sourcegraph:semanticdb-kotlinc:${BuildInfo.semanticdbKotlincVersion}"
343344

344345
val semanticdbKotlinc =
345346
project

tests/buildTools/src/test/scala/tests/GradleBuildToolSuite.scala

Lines changed: 3 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -360,32 +360,6 @@ abstract class GradleBuildToolSuite(gradle: Tool.Gradle)
360360
gradleVersions = List(Gradle8, Gradle7, Gradle6),
361361
tools = List(Scala2_12_12)
362362
)
363-
checkGradleBuild(
364-
"kotlin",
365-
"""|/build.gradle
366-
|plugins {
367-
| id 'org.jetbrains.kotlin.jvm' version '1.8.0'
368-
|}
369-
|repositories {
370-
| mavenCentral()
371-
|}
372-
|/src/main/java/foo/JExample.java
373-
|package foo;
374-
|public class JExample {}
375-
|/src/main/kotlin/foo/Example.kt
376-
|package foo
377-
|object Example {}
378-
|/src/test/java/foo/JExampleSuite.java
379-
|package foo;
380-
|public class JExampleSuite {}
381-
|/src/test/kotlin/foo/ExampleSuite.kt
382-
|package foo
383-
|class ExampleSuite {}
384-
|""".stripMargin,
385-
expectedSemanticdbFiles = 4,
386-
gradleVersions = List(Gradle6, Gradle7)
387-
)
388-
389363
checkGradleBuild(
390364
"kotlin2",
391365
"""|/build.gradle
@@ -465,7 +439,7 @@ abstract class GradleBuildToolSuite(gradle: Tool.Gradle)
465439
s"""|/build.gradle
466440
|plugins {
467441
| id 'java'
468-
| id 'org.jetbrains.kotlin.jvm' version '1.8.0'
442+
| id 'org.jetbrains.kotlin.jvm' version '2.1.20'
469443
|}
470444
|java {
471445
| toolchain {
@@ -478,9 +452,7 @@ abstract class GradleBuildToolSuite(gradle: Tool.Gradle)
478452
|object Example {}
479453
|""".stripMargin,
480454
expectedSemanticdbFiles = 1,
481-
// Older Kotlin gradle plugins don't support Gradle 8:
482-
// https://youtrack.jetbrains.com/issue/KT-55704/Cannot-use-TaskAction-annotation-on-method-AbstractKotlinCompile.execute-error-while-using-Gradle-8.0-rc-with-KGP-1.5.32
483-
gradleVersions = List(Gradle6, Gradle7)
455+
gradleVersions = List(Gradle8)
484456
)
485457
}
486458

@@ -490,7 +462,7 @@ abstract class GradleBuildToolSuite(gradle: Tool.Gradle)
490462
s"kotlin-multiplatform-$jvmSettings",
491463
s"""|/build.gradle
492464
|plugins {
493-
| id 'org.jetbrains.kotlin.multiplatform' version '1.8.0'
465+
| id 'org.jetbrains.kotlin.multiplatform' version '2.1.20'
494466
|}
495467
|repositories {
496468
| mavenCentral()

0 commit comments

Comments
 (0)