Fix CI and address comment

Author: olafurpg

lsif-java/src/main/scala/com/sourcegraph/lsif_java/commands/SnapshotLsifCommand.scala

@@ -5,7 +5,6 @@ import java.nio.charset.StandardCharsets
 import java.nio.file.Files
 import java.nio.file.Path
 import java.nio.file.Paths
-import java.util.concurrent.atomic.AtomicInteger
 import java.util.stream.Collectors
 import java.util.stream.Stream
 

lsif-semanticdb/src/main/java/com/sourcegraph/lsif_semanticdb/LsifSemanticdb.java

@@ -12,6 +12,7 @@
 import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Map;
+import java.util.NoSuchElementException;
 import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.stream.Collectors;
@@ -101,8 +102,14 @@ private Integer processDocument(LsifTextDocument doc, Set<String> isExportedSymb
       writer.emitItem(ids.referenceResult, rangeId, doc.id);
 
       // Definition
-      if (occ.getRole() == SymbolOccurrence.Role.DEFINITION && ids.isDefinitionDefined()) {
-        writer.emitItem(ids.definitionResult, rangeId, doc.id);
+      if (occ.getRole() == SymbolOccurrence.Role.DEFINITION) {
+        if (ids.isDefinitionDefined()) {
+          writer.emitItem(ids.definitionResult, rangeId, doc.id);
+        } else {
+          options.reporter.error(
+              new NoSuchElementException(
+                  String.format("no definition ID for symbol '%s'", occ.getSymbol())));
+        }
 
         // Hover
         String documentation = symbolInformation.getDocumentation().getMessage();