Add test suite for -targetroot:javac-classes-directory

Author: olafurpg

semanticdb-javac/src/main/java/com/sourcegraph/semanticdb_javac/SemanticdbJavacOptions.java

@@ -1,5 +1,7 @@
 package com.sourcegraph.semanticdb_javac;
 
+import java.io.ByteArrayOutputStream;
+import java.io.PrintStream;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.ArrayList;
@@ -22,7 +24,7 @@ public class SemanticdbJavacOptions {
   public boolean verboseEnabled = false;
   public final ArrayList<String> errors;
 
-  public static String stubClassName = "META-INF-stub";
+  public static String stubClassName = "META-INF-semanticdb-stub";
 
   public SemanticdbJavacOptions() {
     errors = new ArrayList<>();
@@ -83,10 +85,12 @@ private static Path getJavacClassesDir(SemanticdbJavacOptions result, Context ct
           fm.getJavaFileForOutput(CLASS_OUTPUT, stubClassName, JavaFileObject.Kind.CLASS, null);
       outputDir = Paths.get(outputDirStub.toUri()).toAbsolutePath().getParent();
     } catch (Exception e) {
+      ByteArrayOutputStream out = new ByteArrayOutputStream();
+      e.printStackTrace(new PrintStream(out));
       String errorMsg =
           String.format(
-              "-targetroot:%s passed but could not get the class output directory: %s",
-              JAVAC_CLASSES_DIR_ARG, e.getMessage());
+              "exception while processing SemanticDB option '-targetroot:%s'\n%s",
+              JAVAC_CLASSES_DIR_ARG, out.toString());
       result.errors.add(errorMsg);
     }
     return outputDir;

tests/unit/src/main/scala/tests/SimpleFileManager.java

@@ -1,6 +1,7 @@
 package tests;
 
 import java.net.URI;
+import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.List;
 import javax.tools.FileObject;
@@ -13,19 +14,21 @@
 public class SimpleFileManager
     extends ForwardingJavaFileManager<StandardJavaFileManager> {
 
-  public List<SimpleClassFile> compiled = new ArrayList<>();
+  public final List<SimpleClassFile> compiled = new ArrayList<>();
+  public final Path targetroot;
 
-  protected SimpleFileManager(StandardJavaFileManager fileManager) {
+  protected SimpleFileManager(StandardJavaFileManager fileManager, Path targetroot) {
     super(fileManager);
+    this.targetroot = targetroot;
   }
 
   // standard constructors/getters
 
   @Override
   public JavaFileObject getJavaFileForOutput(Location location,
                                              String className, JavaFileObject.Kind kind, FileObject sibling) {
-    SimpleClassFile result = new SimpleClassFile(
-        URI.create("string://" + className));
+    URI uri = targetroot.resolve(className).toUri();
+    SimpleClassFile result = new SimpleClassFile(uri);
     if (!className.equals(SemanticdbJavacOptions.stubClassName)) {
       compiled.add(result);
     }

tests/unit/src/main/scala/tests/TestCompiler.scala

@@ -28,7 +28,10 @@ class TestCompiler(
 
   private val compiler = ToolProvider.getSystemJavaCompiler
   private val fileManager =
-    new SimpleFileManager(compiler.getStandardFileManager(null, null, null))
+    new SimpleFileManager(
+      compiler.getStandardFileManager(null, null, null),
+      targetroot
+    )
 
   def this(targetroot: Path) {
     this(TestCompiler.PROCESSOR_PATH, Nil, targetroot)

tests/unit/src/test/scala/tests/JavacClassesDirectorySuite.scala

@@ -0,0 +1,47 @@
+package tests
+
+import java.nio.file.Files
+import java.nio.file.Paths
+
+import scala.meta.inputs.Input
+
+import munit.FunSuite
+
+class JavacClassesDirectorySuite extends FunSuite with TempDirectories {
+  val sourceroot = new DirectoryFixture()
+
+  override def munitFixtures: Seq[Fixture[_]] =
+    super.munitFixtures ++ List(sourceroot)
+
+  test("targetroot:javac-classes-directory") {
+    val compiler =
+      new TestCompiler(
+        classpath = TestCompiler.PROCESSOR_PATH,
+        options = Nil,
+        targetroot = sourceroot(),
+        sourceroot = sourceroot()
+      )
+    val compileResult = compiler.compile(
+      List(
+        Input.VirtualFile(
+          "example/Example.java",
+          """package example;
+            |public class Example{}""".stripMargin
+        )
+      ),
+      List(
+        s"-Xplugin:semanticdb -sourceroot:${sourceroot()} -targetroot:javac-classes-directory",
+        "-d",
+        sourceroot().toString
+      )
+    )
+    assert(clue(compileResult).isSuccess)
+    val semanticdbPath = Paths
+      .get("META-INF")
+      .resolve("semanticdb")
+      .resolve("example")
+      .resolve("Example.java.semanticdb")
+    assert(Files.isRegularFile(clue(sourceroot().resolve(semanticdbPath))))
+  }
+
+}