Skip to content

Commit 59aaf04

Browse files
nicolas-guichardantonsviridov-src
authored andcommitted
Fix getters/setters
Identify getters/setters using FirPropertyAccessorSymbol.isGetter and FirPropertyAccessorSymbol.isSetter instead of doing string comparisons. Still 14 failing tests.
1 parent 0dac7a4 commit 59aaf04

File tree

1 file changed

+2
-5
lines changed
  • semanticdb-kotlinc/src/main/kotlin/com/sourcegraph/semanticdb_kotlinc

1 file changed

+2
-5
lines changed

semanticdb-kotlinc/src/main/kotlin/com/sourcegraph/semanticdb_kotlinc/SymbolsCache.kt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import org.jetbrains.kotlin.fir.analysis.checkers.getContainingSymbol
99
import org.jetbrains.kotlin.fir.declarations.FirClass
1010
import org.jetbrains.kotlin.fir.declarations.FirDeclarationOrigin
1111
import org.jetbrains.kotlin.fir.declarations.utils.memberDeclarationNameOrNull
12-
import org.jetbrains.kotlin.fir.declarations.utils.nameOrSpecialName
1312
import org.jetbrains.kotlin.fir.packageFqName
1413
import org.jetbrains.kotlin.fir.resolve.getContainingDeclaration
1514
import org.jetbrains.kotlin.fir.resolve.providers.symbolProvider
@@ -136,13 +135,11 @@ class GlobalSymbolsCache(testing: Boolean = false) : Iterable<Symbol> {
136135
return when {
137136
symbol is FirClassLikeSymbol ->
138137
SemanticdbSymbolDescriptor(Kind.TYPE, symbol.classId.shortClassName.asString())
139-
symbol is FirPropertyAccessorSymbol &&
140-
symbol.fir.nameOrSpecialName.asStringStripSpecialMarkers().startsWith("set") ->
138+
symbol is FirPropertyAccessorSymbol && symbol.isSetter ->
141139
SemanticdbSymbolDescriptor(
142140
Kind.METHOD,
143141
"set" + symbol.propertySymbol.fir.name.toString().capitalizeAsciiOnly())
144-
symbol is FirPropertyAccessorSymbol &&
145-
symbol.fir.nameOrSpecialName.asStringStripSpecialMarkers().startsWith("get") ->
142+
symbol is FirPropertyAccessorSymbol && symbol.isGetter ->
146143
SemanticdbSymbolDescriptor(
147144
Kind.METHOD,
148145
"get" + symbol.propertySymbol.fir.name.toString().capitalizeAsciiOnly())

0 commit comments

Comments
 (0)