Fix eslint errors

Amp-Thread-ID: https://ampcode.com/threads/T-0319390d-8526-40e6-b85d-aba74c0e2522
Co-authored-by: Amp <[email protected]>

Author: varungandhi-src

src/FileIndexer.ts

@@ -245,9 +245,9 @@ export class FileIndexer {
 
           // Diagnostics should only be added for references to the symbol, not
           // the definition
-          diagnostics: !isDefinitionNode
-            ? this.diagnosticsForSymbol(sym)
-            : undefined,
+          diagnostics: isDefinitionNode
+            ? undefined
+            : FileIndexer.diagnosticsForSymbol(sym),
         })
       )
       if (isDefinitionNode) {
@@ -726,7 +726,7 @@ export class FileIndexer {
   }
 
   // Returns the scip diagnostics for a given typescript symbol
-  private diagnosticsForSymbol(
+  private static diagnosticsForSymbol(
     sym: ts.Symbol
   ): scip.scip.Diagnostic[] | undefined {
     const jsDocTags = sym.getJsDocTags()

src/SnapshotTesting.ts

@@ -297,12 +297,12 @@ export function formatSnapshot(
       pushDoc(range, occurrence.symbol, isDefinition, isStartOfLine)
 
       if (occurrence.diagnostics && occurrence.diagnostics.length > 0) {
-        for (let diagnostic of occurrence.diagnostics) {
-          let indent = ' '.repeat(range.start.character - 2)
+        for (const diagnostic of occurrence.diagnostics) {
+          const indent = ' '.repeat(range.start.character - 2)
           out.push(commentSyntax + indent)
           out.push(`diagnostic ${scip.Severity[diagnostic.severity]}:\n`)
           if (diagnostic.message) {
-            for (let messageLine of diagnostic.message.split('\n')) {
+            for (const messageLine of diagnostic.message.split('\n')) {
               out.push(`${commentSyntax + indent}> ${messageLine}\n`)
             }
           }