Skip to content

Commit cebd1bf

Browse files
Update Node version used by Docker image (#103)
The existing image causes failures because the `fs.close()` method is used with a single filedescriptor argument. However, the callback argument is mandatory before v15.9.0 and v14.17.0. See https://nodejs.org/api/fs.html#fsclosefd-callback
1 parent 13ae475 commit cebd1bf

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
FROM sourcegraph/src-cli:3.38.0@sha256:5d26b9225268c5e49f24ceedf7bae303c9e34640faae3f254f4c8f312d77d4cb AS src-cli
22

3-
FROM node:14.5-alpine3.10@sha256:7fb1e608dc4081c25930db83cb4a5df884b6a3f6e4e9f5fa2df08f22778fcfad
3+
# Keep in sync with Dockerfile.autoindex
4+
FROM node:17.7.1-alpine3.14@sha256:cbb62fa2f740959b173b180e4806a5e479fbbd7a20072c3d6b4283bf2b9951d1
45

56
ARG TAG
67

Dockerfile.autoindex

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
FROM sourcegraph/src-cli:3.38.0@sha256:5d26b9225268c5e49f24ceedf7bae303c9e34640faae3f254f4c8f312d77d4cb AS src-cli
22

3+
# Keep in sync with default Dockerfile
34
FROM node:17.7.1-alpine3.14@sha256:cbb62fa2f740959b173b180e4806a5e479fbbd7a20072c3d6b4283bf2b9951d1
45

56
ENV NODE_OPTIONS=--max-old-space-size=4096

0 commit comments

Comments
 (0)