Fix a bug where goto definition did not work when SymbolInformation was missing (#36)

* Reproduce the bug where SymbolInformation is missing

* Fix the bug

* Remove debugging lines

* Add back the actual if statement

Author: olafurpg

bindings/go/scip/convert.go

@@ -78,6 +78,18 @@ func ConvertSCIPToLSIF(index *Index) ([]reader.Element, error) {
 				g.symbolToResultSet[exportedSymbol.Symbol] = g.emitResultSet(exportedSymbol, "export")
 			}
 		}
+		for _, occ := range document.Occurrences {
+			if !SymbolRole_Definition.Matches(occ) {
+				continue
+			}
+			if IsLocalSymbol(occ.Symbol) {
+				continue
+			}
+			if _, ok := g.symbolToResultSet[occ.Symbol]; ok {
+				continue
+			}
+			g.symbolToResultSet[occ.Symbol] = g.emitResultSet(&SymbolInformation{Symbol: occ.Symbol}, "export")
+		}
 	}
 
 	// Pass 2: emit ranges for all documents.
@@ -194,6 +206,19 @@ func (g *graph) emitDocument(index *Index, doc *Document) {
 		}
 	}
 
+	for _, occ := range doc.Occurrences {
+		if !SymbolRole_Definition.Matches(occ) {
+			continue
+		}
+		if !IsLocalSymbol(occ.Symbol) {
+			continue
+		}
+		if _, ok := localSymbolInformationTable[occ.Symbol]; ok {
+			continue
+		}
+		localSymbolInformationTable[occ.Symbol] = g.emitResultSet(&SymbolInformation{Symbol: occ.Symbol}, "local")
+	}
+
 	var rangeIDs []int
 	for _, occ := range doc.Occurrences {
 		rangeID, err := g.emitRange(occ.Range)

cmd/tests/reprolang/bindings/go/repro/scip.go

@@ -2,6 +2,7 @@ package repro
 
 import (
 	"sort"
+	"strings"
 
 	"github.com/sourcegraph/scip/bindings/go/scip"
 )
@@ -17,6 +18,9 @@ func (i *identifier) occurrence(roles scip.SymbolRole) *scip.Occurrence {
 func (s *reproSourceFile) symbols() []*scip.SymbolInformation {
 	var result []*scip.SymbolInformation
 	for _, def := range s.definitions {
+		if strings.Index(def.name.value, "NoSymbolInformation") >= 0 {
+			continue
+		}
 		documentation := []string{"signature of " + def.name.value}
 		if def.docstring != "" {
 			documentation = append(documentation, def.docstring)

cmd/tests/snapshots/input/missing-symbol-information/globals.repro

@@ -0,0 +1,2 @@
+definition NoSymbolInformation#
+reference NoSymbolInformation#

cmd/tests/snapshots/input/missing-symbol-information/locals.repro

@@ -0,0 +1,2 @@
+definition localNoSymbolInformation
+reference localNoSymbolInformation

cmd/tests/snapshots/output/missing-symbol-information/dump.lsif

@@ -0,0 +1,37 @@
+{"id":1,"version":"0.4.3","projectRoot":"file:/root","positionEncoding":"utf-8","toolInfo":{"name":"reprolang","version":"1.0.0"},"type":"vertex","label":"metaData"}
+{"id":2,"type":"vertex","label":"definitionResult"}
+{"id":3,"type":"vertex","label":"resultSet"}
+{"id":4,"type":"vertex","label":"referenceResult"}
+{"id":5,"type":"vertex","label":"hoverResult","result":{"contents":{"kind":"markdown"}}}
+{"id":6,"type":"edge","label":"textDocument/definition","inV":2,"outV":3}
+{"id":7,"type":"edge","label":"textDocument/references","inV":4,"outV":3}
+{"id":8,"type":"edge","label":"textDocument/hover","inV":5,"outV":3}
+{"id":9,"type":"vertex","label":"moniker","identifier":"reprolang repro_manager missing-symbol-information 1.0.0 globals.repro/NoSymbolInformation#","kind":"export","scheme":"reprolang"}
+{"id":10,"type":"edge","label":"moniker","inV":9,"outV":3}
+{"id":11,"name":"missing-symbol-information","version":"1.0.0","manager":"repro_manager","type":"vertex","label":"packageInformation"}
+{"id":12,"type":"edge","label":"packageInformation","inV":11,"outV":9}
+{"id":13,"type":"vertex","label":"document","uri":"file:/root/globals.repro"}
+{"id":14,"type":"vertex","label":"range","start":{"line":0,"character":11},"end":{"line":0,"character":31}}
+{"id":15,"type":"edge","label":"next","inV":3,"outV":14}
+{"id":16,"type":"edge","label":"item","inVs":[14],"outV":2,"document":13}
+{"id":17,"type":"edge","label":"item","inVs":[14],"outV":4,"document":13}
+{"id":18,"type":"vertex","label":"range","start":{"line":1,"character":10},"end":{"line":1,"character":30}}
+{"id":19,"type":"edge","label":"next","inV":3,"outV":18}
+{"id":20,"type":"edge","label":"item","inVs":[18],"outV":4,"document":13}
+{"id":21,"type":"edge","label":"contains","inVs":[14,18],"outV":13}
+{"id":22,"type":"vertex","label":"document","uri":"file:/root/locals.repro"}
+{"id":23,"type":"vertex","label":"definitionResult"}
+{"id":24,"type":"vertex","label":"resultSet"}
+{"id":25,"type":"vertex","label":"referenceResult"}
+{"id":26,"type":"vertex","label":"hoverResult","result":{"contents":{"kind":"markdown"}}}
+{"id":27,"type":"edge","label":"textDocument/definition","inV":23,"outV":24}
+{"id":28,"type":"edge","label":"textDocument/references","inV":25,"outV":24}
+{"id":29,"type":"edge","label":"textDocument/hover","inV":26,"outV":24}
+{"id":30,"type":"vertex","label":"range","start":{"line":0,"character":11},"end":{"line":0,"character":35}}
+{"id":31,"type":"edge","label":"next","inV":24,"outV":30}
+{"id":32,"type":"edge","label":"item","inVs":[30],"outV":23,"document":22}
+{"id":33,"type":"edge","label":"item","inVs":[30],"outV":25,"document":22}
+{"id":34,"type":"vertex","label":"range","start":{"line":1,"character":10},"end":{"line":1,"character":34}}
+{"id":35,"type":"edge","label":"next","inV":24,"outV":34}
+{"id":36,"type":"edge","label":"item","inVs":[34],"outV":25,"document":22}
+{"id":37,"type":"edge","label":"contains","inVs":[30,34],"outV":22}

cmd/tests/snapshots/output/missing-symbol-information/globals.repro

@@ -0,0 +1,4 @@
+ definition NoSymbolInformation#
+#           ^^^^^^^^^^^^^^^^^^^^ definition globals.repro/NoSymbolInformation#
+ reference NoSymbolInformation#
+#          ^^^^^^^^^^^^^^^^^^^^ reference globals.repro/NoSymbolInformation#

cmd/tests/snapshots/output/missing-symbol-information/locals.repro

@@ -0,0 +1,4 @@
+ definition localNoSymbolInformation
+#           ^^^^^^^^^^^^^^^^^^^^^^^^ definition local NoSymbolInformation
+ reference localNoSymbolInformation
+#          ^^^^^^^^^^^^^^^^^^^^^^^^ reference local NoSymbolInformation