Make plugin configurable via dotted .sourcegraph-jetbrains.properties (#28)

* Make plugin configurable via dotted `.sourcegraph-jetbrains.properties`

Normally configuration files for tools (especially global configuration)
tend to begin with a dot to avoid showing up in file listings and other
tools (unless desired).

This change adds `.sourcegraph-jetbrains.properties` as a candidate path
to check for the global configuration file. Since dotted files are
conventional, the path mentioned in the README has been changed to
suggest the dotted file name.

The original filename is still read as a backup for backwards
compatibility.

* Make use of path and file terminology consistent

Co-authored-by: Alexander Palmer <[email protected]>

Author: XanderXAJ

README.md

@@ -30,7 +30,7 @@ The plugin works with all JetBrains IDEs including:
 
 ## Configuring for use with a private Sourcegraph instance
 
-The plugin is configurable _globally_ by creating a `sourcegraph-jetbrains.properties` in your home directory. For example, modify the following URL to match your on-premises Sourcegraph instance URL:
+The plugin is configurable _globally_ by creating a `.sourcegraph-jetbrains.properties` in your home directory. For example, modify the following URL to match your on-premises Sourcegraph instance URL:
 
 ```
 url = https://sourcegraph.example.com

src/main/java/Util.java

@@ -2,6 +2,8 @@
 import com.intellij.openapi.project.Project;
 
 import java.io.*;
+import java.nio.file.Path;
+import java.nio.file.Paths;
 import java.util.Properties;
 
 public class Util {
@@ -78,26 +80,33 @@ public static String setRemoteUrlReplacements(Project project) {
         return replacements;
     }
 
-    // readProps tries to read the $HOME/sourcegraph-jetbrains.properties file.
+    // readProps returns the first properties file it's able to parse from the following paths:
+    //   $HOME/.sourcegraph-jetbrains.properties
+    //   $HOME/sourcegraph-jetbrains.properties
     private static Properties readProps() {
+        Path[] candidatePaths = {
+                Paths.get(System.getProperty("user.home"), ".sourcegraph-jetbrains.properties"),
+                Paths.get(System.getProperty("user.home"), "sourcegraph-jetbrains.properties"),
+        };
+
+        for (Path path : candidatePaths) {
+            try {
+                return readPropsFile(path.toFile());
+            } catch (IOException e) {
+                // no-op
+            }
+        }
+        // No files found/readable
+        return new Properties();
+    }
+
+    private static Properties readPropsFile(File file) throws IOException {
         Properties props = new Properties();
-        InputStream input = null;
 
-        String path = System.getProperty("user.home") + File.separator + "sourcegraph-jetbrains.properties";
-        try{
-            input = new FileInputStream(path);
+        try (InputStream input = new FileInputStream(file)) {
             props.load(input);
-        } catch (IOException e) {
-            // no-op
-        } finally {
-            if (input != null) {
-                try{
-                    input.close();
-                } catch (IOException e) {
-                    // no-op
-                }
-            }
         }
+
         return props;
     }