Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Commit 074af1b

Browse files
[Backport 5.5.x] Publish images for all commits on release branches (#63987)
In order to run nightly vulnerability scans of Sourcegraph releases, we need to publish a new set of images whenever the release branch is pushed to. Previously, this was implemented in https://github.com/sourcegraph/sourcegraph/pull/63379 but with RFC 795 the release branch format changed from 5.5.1234 to 5.5.x. This PR updates the regex to catch this new format. The end result of this is that whenever Buildkite runs on a branch matching `\d.\d.x`, it will push images to the `us.gcr.io/sourcegraph-dev/gitserver` registry with the tag `$branch-insiders`. I&#39;ve also tagged this PR for backport as we want it on the current patch release branch 5.5.x :) ## Test plan - Test buildkite run on branch `will-0.0.x` (with modified regex to match that branch) https://buildkite.com/sourcegraph/sourcegraph/builds/283608 ## Changelog <br> Backport b7242d2 from #63985 Co-authored-by: Will Dollman <[email protected]>
1 parent 9522c46 commit 074af1b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

dev/ci/push_all.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ elif [[ "$BUILDKITE_BRANCH" =~ ^[0-9]+\.[0-9]+$ ]]; then
119119
# format introduced by https://github.com/sourcegraph/sourcegraph/pull/48050
120120
# by release branch deployments.
121121
push_prod=true
122-
elif [[ "$BUILDKITE_BRANCH" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
122+
elif [[ "$BUILDKITE_BRANCH" =~ ^[0-9]+\.[0-9]+\.(x|[0-9]+)$ ]]; then
123123
# Patch release builds only need to be pushed to internal registries.
124124
push_prod=false
125125
dev_tags+=("$BUILDKITE_BRANCH-insiders")

dev/ci/runtype/runtype.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ func (t RunType) Matcher() *RunTypeMatcher {
141141
}
142142
case PatchReleaseBranch:
143143
return &RunTypeMatcher{
144-
Branch: `^[0-9]+\.[0-9]+\.[0-9]+$`,
144+
Branch: `^[0-9]+\.[0-9]+\.(?:x|[0-9]+)$`,
145145
BranchRegexp: true,
146146
}
147147
case BextReleaseBranch:

0 commit comments

Comments
 (0)