Wraps up syntactic usages in resolvers (#63285)

Fixes
https://linear.app/sourcegraph/issue/GRAPH-667/wrap-up-usage-results-in-graphql-resolvers

This allows us to actually return syntactic usages from the occurrences
API. It does not implement pagination yet, but I think _that_ PR will be
nicer to review after this one landed.

Requires #63268

## Test plan

Running queries against the site-admin api console

Author: Christoph Hegemann

internal/codeintel/codenav/transport/graphql/root_resolver.go

@@ -229,6 +229,18 @@ func (r *rootResolver) UsagesForSymbol(ctx context.Context, unresolvedArgs *reso
 
 			}
 		}
+
+		usageResolvers := []resolverstubs.UsageResolver{}
+		for _, result := range results {
+			usageResolvers = append(usageResolvers, NewSyntacticUsageResolver(result, args.Repo, args.CommitID))
+		}
+		if len(usageResolvers) != 0 {
+			return &usageConnectionResolver{
+				nodes:    usageResolvers,
+				pageInfo: resolverstubs.NewSimplePageInfo(false),
+			}, nil
+		}
+
 		numSyntacticResults = len(results)
 		remainingCount = remainingCount - numSyntacticResults
 	}

internal/codeintel/codenav/transport/graphql/root_resolver_usages.go

@@ -2,37 +2,67 @@ package graphql
 
 import (
 	"context"
+
+	"github.com/sourcegraph/scip/bindings/go/scip"
+
+	"github.com/sourcegraph/sourcegraph/internal/api"
+	"github.com/sourcegraph/sourcegraph/internal/codeintel/codenav"
+	"github.com/sourcegraph/sourcegraph/internal/codeintel/codenav/shared"
 	resolverstubs "github.com/sourcegraph/sourcegraph/internal/codeintel/resolvers"
+	"github.com/sourcegraph/sourcegraph/internal/types"
 )
 
 type usageConnectionResolver struct {
+	nodes    []resolverstubs.UsageResolver
+	pageInfo resolverstubs.PageInfo
 }
 
 var _ resolverstubs.UsageConnectionResolver = &usageConnectionResolver{}
 
 func (u *usageConnectionResolver) Nodes(ctx context.Context) ([]resolverstubs.UsageResolver, error) {
-	//TODO implement me
-	panic("implement me")
+	return u.nodes, nil
 }
 
 func (u *usageConnectionResolver) PageInfo() resolverstubs.PageInfo {
-	//TODO implement me
-	panic("implement me")
+	return u.pageInfo
 }
 
 type usageResolver struct {
+	symbol     resolverstubs.SymbolInformationResolver
+	kind       resolverstubs.SymbolUsageKind
+	usageRange resolverstubs.UsageRangeResolver
 }
 
 var _ resolverstubs.UsageResolver = &usageResolver{}
 
+func NewSyntacticUsageResolver(usage codenav.SyntacticMatch, repository types.Repo, revision api.CommitID) resolverstubs.UsageResolver {
+	var kind resolverstubs.SymbolUsageKind
+	if scip.SymbolRole_Definition.Matches(usage.Occurrence) {
+		kind = resolverstubs.UsageKindDefinition
+	} else {
+		kind = resolverstubs.UsageKindReference
+	}
+	return &usageResolver{
+		symbol: &symbolInformationResolver{
+			name:       usage.Occurrence.Symbol,
+			provenance: resolverstubs.ProvenanceSyntactic,
+		},
+		kind: kind,
+		usageRange: &usageRangeResolver{
+			repository: repository,
+			revision:   revision,
+			path:       usage.Path,
+			range_:     usage.Range(),
+		},
+	}
+}
+
 func (u *usageResolver) Symbol(ctx context.Context) (resolverstubs.SymbolInformationResolver, error) {
-	//TODO implement me
-	panic("implement me")
+	return u.symbol, nil
 }
 
 func (u *usageResolver) UsageRange(ctx context.Context) (resolverstubs.UsageRangeResolver, error) {
-	//TODO implement me
-	panic("implement me")
+	return u.usageRange, nil
 }
 
 func (u *usageResolver) SurroundingContent(_ context.Context, args *struct {
@@ -43,17 +73,18 @@ func (u *usageResolver) SurroundingContent(_ context.Context, args *struct {
 }
 
 func (u *usageResolver) UsageKind() resolverstubs.SymbolUsageKind {
-	panic("implement me")
+	return u.kind
 }
 
 type symbolInformationResolver struct {
+	name       string
+	provenance resolverstubs.CodeGraphDataProvenance
 }
 
 var _ resolverstubs.SymbolInformationResolver = &symbolInformationResolver{}
 
 func (s *symbolInformationResolver) Name() (string, error) {
-	//TODO implement me
-	panic("implement me")
+	return s.name, nil
 }
 
 func (s *symbolInformationResolver) Documentation() (*[]string, error) {
@@ -62,35 +93,37 @@ func (s *symbolInformationResolver) Documentation() (*[]string, error) {
 }
 
 func (s *symbolInformationResolver) Provenance() (resolverstubs.CodeGraphDataProvenance, error) {
-	//TODO implement me
-	panic("implement me")
+	return s.provenance, nil
 }
 
 func (s *symbolInformationResolver) DataSource() *string {
 	//TODO implement me
 	panic("implement me")
 }
 
-type usageRangeResolver struct{}
+type usageRangeResolver struct {
+	repository types.Repo
+	revision   api.CommitID
+	path       string
+	range_     scip.Range
+}
 
 var _ resolverstubs.UsageRangeResolver = &usageRangeResolver{}
 
 func (u *usageRangeResolver) Repository() string {
-	//TODO implement me
-	panic("implement me")
+	return string(u.repository.Name)
 }
 
 func (u *usageRangeResolver) Revision() string {
-	//TODO implement me
-	panic("implement me")
+	return string(u.revision)
 }
 
 func (u *usageRangeResolver) Path() string {
-	//TODO implement me
-	panic("implement me")
+	return u.path
 }
 
 func (u *usageRangeResolver) Range() resolverstubs.RangeResolver {
-	//TODO implement me
-	panic("implement me")
+	return &rangeResolver{
+		lspRange: convertRange(shared.TranslateRange(u.range_)),
+	}
 }