embeddings: Extend policies from code intel (#52326)

Extend the code intel policies service to also describe embeddings
re-indexing. We extend the GraphQL API and also copy/share the UI
backing the admin pages.

---------

Co-authored-by: Stefan Hengl <[email protected]>
Co-authored-by: numbers88s <[email protected]>
Co-authored-by: Tim Lucas <[email protected]>

Author: 4 people

client/web/BUILD.bazel

@@ -24,6 +24,7 @@ export const POLICIES_CONFIGURATION = gql`
         $query: String
         $forDataRetention: Boolean
         $forIndexing: Boolean
+        $forEmbeddings: Boolean
         $first: Int
         $after: String
         $protected: Boolean
@@ -33,6 +34,7 @@ export const POLICIES_CONFIGURATION = gql`
             query: $query
             forDataRetention: $forDataRetention
             forIndexing: $forIndexing
+            forEmbeddings: $forEmbeddings
             first: $first
             after: $after
             protected: $protected
@@ -58,6 +60,7 @@ export const queryPolicies = (
         query,
         forDataRetention,
         forIndexing,
+        forEmbeddings,
         after,
         protected: varProtected,
     }: Partial<CodeIntelligenceConfigurationPoliciesVariables>,
@@ -68,6 +71,7 @@ export const queryPolicies = (
         query: query ?? null,
         forDataRetention: forDataRetention ?? null,
         forIndexing: forIndexing ?? null,
+        forEmbeddings: forEmbeddings ?? null,
         first: first ?? null,
         after: after ?? null,
         protected: varProtected ?? null,

client/web/src/enterprise/codeintel/configuration/hooks/queryPolicies.tsx

@@ -16,6 +16,7 @@ export const nullPolicy = {
     indexingEnabled: false,
     indexCommitMaxAgeHours: null,
     indexIntermediateCommits: false,
+    embeddingsEnabled: false,
     repository: null,
 }
 
@@ -38,5 +39,6 @@ export const defaultCodeIntelligenceConfigurationPolicyFieldsFragment = gql`
         indexingEnabled
         indexCommitMaxAgeHours
         indexIntermediateCommits
+        embeddingsEnabled
     }
 `

client/web/src/enterprise/codeintel/configuration/hooks/types.tsx

@@ -41,6 +41,7 @@ const emptyPolicy: CodeIntelligenceConfigurationPolicyFields = {
     indexingEnabled: false,
     indexCommitMaxAgeHours: null,
     indexIntermediateCommits: false,
+    embeddingsEnabled: false,
 }
 
 export const usePolicyConfigurationByID = (id: string): UsePolicyConfigResult => {

client/web/src/enterprise/codeintel/configuration/hooks/usePolicyConfigurationById.tsx

@@ -17,6 +17,7 @@ const CREATE_POLICY_CONFIGURATION = gql`
         $indexingEnabled: Boolean!
         $indexCommitMaxAgeHours: Int
         $indexIntermediateCommits: Boolean!
+        $embeddingsEnabled: Boolean!
     ) {
         createCodeIntelligenceConfigurationPolicy(
             repository: $repositoryId
@@ -30,6 +31,7 @@ const CREATE_POLICY_CONFIGURATION = gql`
             indexingEnabled: $indexingEnabled
             indexCommitMaxAgeHours: $indexCommitMaxAgeHours
             indexIntermediateCommits: $indexIntermediateCommits
+            embeddingsEnabled: $embeddingsEnabled
         ) {
             id
         }
@@ -49,6 +51,7 @@ const UPDATE_POLICY_CONFIGURATION = gql`
         $indexingEnabled: Boolean!
         $indexCommitMaxAgeHours: Int
         $indexIntermediateCommits: Boolean!
+        $embeddingsEnabled: Boolean!
     ) {
         updateCodeIntelligenceConfigurationPolicy(
             id: $id
@@ -62,6 +65,7 @@ const UPDATE_POLICY_CONFIGURATION = gql`
             indexingEnabled: $indexingEnabled
             indexCommitMaxAgeHours: $indexCommitMaxAgeHours
             indexIntermediateCommits: $indexIntermediateCommits
+            embeddingsEnabled: $embeddingsEnabled
         ) {
             alwaysNil
         }

client/web/src/enterprise/codeintel/configuration/hooks/useSavePolicyConfiguration.tsx

@@ -11,6 +11,7 @@ import {
     mdiLock,
     mdiPencil,
     mdiSourceRepository,
+    mdiVectorPolyline,
 } from '@mdi/js'
 import classNames from 'classnames'
 import { useNavigate, useLocation } from 'react-router-dom'
@@ -59,12 +60,12 @@ export const CodeIntelConfigurationPage: FunctionComponent<CodeIntelConfiguratio
     const apolloClient = useApolloClient()
     const queryDefaultPoliciesCallback = useCallback(
         (args: FilteredConnectionQueryArguments) =>
-            queryPolicies({ ...args, repository: repo?.id, protected: true }, apolloClient),
+            queryPolicies({ ...args, repository: repo?.id, forEmbeddings: false, protected: true }, apolloClient),
         [queryPolicies, repo?.id, apolloClient]
     )
     const queryCustomPoliciesCallback = useCallback(
         (args: FilteredConnectionQueryArguments) =>
-            queryPolicies({ ...args, repository: repo?.id, protected: false }, apolloClient),
+            queryPolicies({ ...args, repository: repo?.id, forEmbeddings: false, protected: false }, apolloClient),
         [queryPolicies, repo?.id, apolloClient]
     )
 
@@ -212,38 +213,44 @@ export const CodeIntelConfigurationPage: FunctionComponent<CodeIntelConfiguratio
 interface ProtectedPoliciesNodeProps {
     node: CodeIntelligenceConfigurationPolicyFields
     indexingEnabled?: boolean
+    domain?: 'scip' | 'embeddings'
 }
 
-interface UnprotectedPoliciesNodeProps {
+export interface UnprotectedPoliciesNodeProps {
     node: CodeIntelligenceConfigurationPolicyFields
     isDeleting: boolean
     onDelete: (id: string, name: string) => Promise<void>
     indexingEnabled?: boolean
+    domain?: 'scip' | 'embeddings'
 }
 
 type PoliciesNodeProps = ProtectedPoliciesNodeProps | UnprotectedPoliciesNodeProps
 
-const PoliciesNode: FunctionComponent<React.PropsWithChildren<PoliciesNodeProps>> = ({
+export const PoliciesNode: FunctionComponent<React.PropsWithChildren<PoliciesNodeProps>> = ({
     node: policy,
     indexingEnabled = false,
+    domain = 'scip',
     ...props
 }) => (
     <>
         <span className={styles.separator} />
 
         <div className={classNames(styles.name, 'd-flex flex-column')}>
-            <PolicyDescription policy={policy} indexingEnabled={indexingEnabled} />
+            <PolicyDescription policy={policy} indexingEnabled={indexingEnabled} domain={domain} />
             <RepositoryAndGitObjectDescription policy={policy} />
             {policy.indexingEnabled && indexingEnabled && <AutoIndexingDescription policy={policy} />}
             {policy.retentionEnabled && <RetentionDescription policy={policy} />}
+            {policy.embeddingsEnabled && <EmbeddingsDescription policy={policy} />}
         </div>
 
         <div className="h-100">
             <Link
                 to={
                     policy.repository === null
-                        ? `/site-admin/code-graph/configuration/${policy.id}`
-                        : `/${policy.repository.name}/-/code-graph/configuration/${policy.id}`
+                        ? `/site-admin/${domain === 'scip' ? 'code-graph' : 'embeddings'}/configuration/${policy.id}`
+                        : `/${policy.repository.name}/-/${
+                              domain === 'scip' ? 'code-graph' : 'embeddings'
+                          }/configuration/${policy.id}`
                 }
             >
                 <Tooltip content="Edit this policy">
@@ -283,27 +290,31 @@ interface PolicyDescriptionProps {
     policy: CodeIntelligenceConfigurationPolicyFields
     indexingEnabled?: boolean
     allowGlobalPolicies?: boolean
+    domain?: 'scip' | 'embeddings'
 }
 
 const PolicyDescription: FunctionComponent<PolicyDescriptionProps> = ({
     policy,
     indexingEnabled = false,
     allowGlobalPolicies = window.context?.codeIntelAutoIndexingAllowGlobalPolicies,
+    domain = 'scip',
 }) => (
     <div className={styles.policyDescription}>
         <Link
             to={
                 policy.repository === null
-                    ? `/site-admin/code-graph/configuration/${policy.id}`
-                    : `/${policy.repository.name}/-/code-graph/configuration/${policy.id}`
+                    ? `/site-admin/${domain === 'scip' ? 'code-graph' : 'embeddings'}/configuration/${policy.id}`
+                    : `/${policy.repository.name}/-/${domain === 'scip' ? 'code-graph' : 'embeddings'}/configuration/${
+                          policy.id
+                      }`
             }
         >
             <Text weight="bold" className="mb-0">
                 {policy.name}
             </Text>
         </Link>
 
-        {!policy.retentionEnabled && !(indexingEnabled && policy.indexingEnabled) && (
+        {!policy.retentionEnabled && !(indexingEnabled && policy.indexingEnabled) && !policy.embeddingsEnabled && (
             <Tooltip content="This policy has no enabled behaviors.">
                 <Icon
                     svgPath={mdiCircleOffOutline}
@@ -359,11 +370,11 @@ const RepositoryAndGitObjectDescription: FunctionComponent<RepositoryAndGitObjec
     </div>
 )
 
-interface RepositoryDescriptionProps {
+interface GitObjectDescriptionProps {
     policy: CodeIntelligenceConfigurationPolicyFields
 }
 
-const RepositoryDescription: FunctionComponent<RepositoryDescriptionProps> = ({ policy }) => {
+const GitObjectDescription: FunctionComponent<GitObjectDescriptionProps> = ({ policy }) => {
     if (policy.type === GitObjectType.GIT_COMMIT) {
         if (policy.pattern === 'HEAD') {
             return (
@@ -407,11 +418,11 @@ const RepositoryDescription: FunctionComponent<RepositoryDescriptionProps> = ({
     return <></>
 }
 
-interface GitObjectDescriptionProps {
+interface RepositoryDescriptionProps {
     policy: CodeIntelligenceConfigurationPolicyFields
 }
 
-const GitObjectDescription: FunctionComponent<GitObjectDescriptionProps> = ({ policy }) => {
+const RepositoryDescription: FunctionComponent<RepositoryDescriptionProps> = ({ policy }) => {
     if (policy.repository) {
         return (
             <Badge variant="outlineSecondary">
@@ -520,3 +531,22 @@ const RetentionDescription: FunctionComponent<RetentionDescriptionProps> = ({ po
         </span>
     </div>
 )
+
+interface EmbeddingsDescriptionProps {
+    policy: CodeIntelligenceConfigurationPolicyFields
+}
+
+const EmbeddingsDescription: FunctionComponent<EmbeddingsDescriptionProps> = ({ policy }) => (
+    <div>
+        <Tooltip content="This policy affects embeddings.">
+            <Icon
+                svgPath={mdiVectorPolyline}
+                inline={true}
+                aria-label="This policy affects embeddings."
+                className="mr-2"
+            />
+        </Tooltip>
+
+        <span>Maintains embeddings.</span>
+    </div>
+)