add back /post-sign-up (#63456)

This is needed for the signup flow to work.


## Test plan

Manually test

Author: sqs

client/web-sveltekit/src/params/reporev.ts

@@ -33,6 +33,7 @@ const topLevelPaths = [
     'search/cody',
     'app',
     'cody',
+    'post-sign-up',
     'unlock-account',
     'password-reset',
     'survey',

client/web/BUILD.bazel

@@ -160,6 +160,7 @@ ts_project(
         "src/auth/AuthPageWrapper.tsx",
         "src/auth/CloudSignUpPage.tsx",
         "src/auth/OrDivider.tsx",
+        "src/auth/PostSignUpPage.tsx",
         "src/auth/RequestAccessPage.tsx",
         "src/auth/ResetPasswordPage.tsx",
         "src/auth/SignInPage.tsx",

client/web/src/LegacyLayout.tsx

@@ -101,6 +101,7 @@ export const LegacyLayout: FC<LegacyLayoutProps> = props => {
         [PageRoutes.SignIn, PageRoutes.SignUp, PageRoutes.PasswordReset, PageRoutes.RequestAccess].includes(
             routeMatch as PageRoutes
         )
+    const isPostSignUpPage = location.pathname === PageRoutes.PostSignUp.toString()
 
     const [newSearchNavigation] = useNewSearchNavigation()
     const [enableContrastCompliantSyntaxHighlighting] = useFeatureFlag('contrast-compliant-syntax-highlighting')
@@ -222,7 +223,7 @@ export const LegacyLayout: FC<LegacyLayoutProps> = props => {
                     telemetryRecorder={props.platformContext.telemetryRecorder}
                 />
             )}
-            {!isSiteInit && !isSignInOrUp && (
+            {!isSiteInit && !isSignInOrUp && !isPostSignUpPage && (
                 <>
                     {newSearchNavigation ? (
                         <NewGlobalNavigationBar

client/web/src/auth/PostSignUpPage.tsx

@@ -0,0 +1,18 @@
+import React from 'react'
+
+import { Navigate, useLocation } from 'react-router-dom'
+
+import { getReturnTo } from './SignInSignUpCommon'
+
+export const PostSignUpPage: React.FunctionComponent = () => {
+    const location = useLocation()
+    const returnTo = getReturnTo(location)
+
+    // Redirects Cody PLG users without asking
+    const params = new URLSearchParams()
+    params.set('returnTo', returnTo)
+
+    const navigateTo = '/sign-in?' + params.toString()
+
+    return <Navigate to={navigateTo.toString()} replace={true} />
+}

client/web/src/auth/SignUpPage.tsx

@@ -11,12 +11,13 @@ import { Container, Link, Text } from '@sourcegraph/wildcard'
 import type { AuthenticatedUser } from '../auth'
 import { PageTitle } from '../components/PageTitle'
 import type { SourcegraphContext } from '../jscontext'
+import { PageRoutes } from '../routes.constants'
 import { EventName } from '../util/constants'
 
 import { AuthPageWrapper } from './AuthPageWrapper'
 import { CloudSignUpPage, ShowEmailFormQueryParameter } from './CloudSignUpPage'
 import { getReturnTo } from './SignInSignUpCommon'
-import { SignUpForm, type SignUpArguments } from './SignUpForm'
+import { type SignUpArguments, SignUpForm } from './SignUpForm'
 import { VsCodeSignUpPage } from './VsCodeSignUpPage'
 
 import styles from './SignUpPage.module.scss'
@@ -91,7 +92,8 @@ export const SignUpPage: React.FunctionComponent<React.PropsWithChildren<SignUpP
             const v2Source = query.get('editor') === 'vscode' ? 0 : 1
             telemetryRecorder.recordEvent('auth.signUp', 'complete', { metadata: { source: v2Source } })
 
-            window.location.replace(returnTo)
+            // Redirects to the /post-sign-up after successful signup on sourcegraphDotCom.
+            window.location.replace(context.sourcegraphDotComMode ? PageRoutes.PostSignUp : returnTo)
 
             return Promise.resolve()
         })

client/web/src/auth/__snapshots__/PostSignUpPage.test.tsx.snap

@@ -4,6 +4,7 @@ export enum PageRoutes {
     SearchConsole = '/search/console',
     SignIn = '/sign-in',
     SignUp = '/sign-up',
+    PostSignUp = '/post-sign-up',
     UnlockAccount = '/unlock-account/:token',
     Settings = '/settings',
     User = '/user/*',

client/web/src/routes.constants.ts

@@ -30,6 +30,7 @@ const RepoContainer = lazyComponent(() => import('./repo/RepoContainer'), 'RepoC
 const TeamsArea = lazyComponent(() => import('./team/TeamsArea'), 'TeamsArea')
 const CodySidebarStoreProvider = lazyComponent(() => import('./cody/sidebar/Provider'), 'CodySidebarStoreProvider')
 const CodyIgnoreProvider = lazyComponent(() => import('./cody/useCodyIgnore'), 'CodyIgnoreProvider')
+const PostSignUpPage = lazyComponent(() => import('./auth/PostSignUpPage'), 'PostSignUpPage')
 
 const GlobalNotebooksArea = lazyComponent(() => import('./notebooks/GlobalNotebooksArea'), 'GlobalNotebooksArea')
 const GlobalBatchChangesArea = lazyComponent(
@@ -85,6 +86,10 @@ const PassThroughToServer: React.FC = () => {
  * See https://reacttraining.com/react-router/web/example/sidebar
  */
 export const routes: RouteObject[] = [
+    {
+        path: PageRoutes.PostSignUp,
+        element: <LegacyRoute render={() => <PostSignUpPage />} />,
+    },
     {
         path: PageRoutes.Index,
         element: <Index />,

client/web/src/routes.tsx

@@ -155,6 +155,7 @@ func InitRouter(db database.DB) {
 		{path: "/cody", name: "cody", title: "Cody", index: false},
 		// TODO: [TEMPORARY] remove this redirect route when the marketing page is added.
 		{path: "/cody/{chatID}", name: "cody-chat", title: "Cody", index: false},
+		{path: "/post-sign-up", name: "post-sign-up", title: "Cody", index: false},
 		{path: "/unlock-account/{token}", name: uirouter.RouteUnlockAccount, title: "Unlock Your Account", index: false},
 		{path: "/password-reset", name: uirouter.RoutePasswordReset, title: "Reset password", index: false},
 		{path: "/survey", name: "survey", title: "Survey", index: false},