Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Commit b9d907f

Browse files
eseligerunknwon
authored andcommitted
batches: Fix multiple tabs racing for URL query state (#40857)
After switching back to wildcard tabs, it was forgotten that before those components would not render at the same time. This causes two issues: - Going to the bulp operations tab doesn't reload so it's unclear where the bulk operation went (noticed that while debugging) - The Bulk operations, Executions and Changesets tabs will all three race for the `visible` (and other, likely) URL query param and keep updating it, leading to an infinite loop of updates until Chrome prevents the loop.
1 parent 844e1de commit b9d907f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

client/web/src/enterprise/batches/BatchChangeTabs.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import styles from './BatchChangeTabs.module.scss'
66

77
/** sourcegraph/wildcard `Tabs` with styling applied to prevent CLS on hovering the tabs. */
88
export const BatchChangeTabs: React.FunctionComponent<TabsProps> = props => (
9-
<Tabs className={styles.batchChangeTabs} {...props} />
9+
<Tabs className={styles.batchChangeTabs} lazy={true} {...props} />
1010
)
1111

1212
/** sourcegraph/wildcard `TabsList` with BC visual styling applied. */

0 commit comments

Comments
 (0)