Remove unused callback from Executor (#337)

This was used in the old architecture but has been replaced by the
TaskStatus callbacks.

Author: mrnugget

cmd/src/campaigns_common.go

@@ -186,7 +186,7 @@ func campaignsExecute(ctx context.Context, out *output.Output, svc *campaigns.Se
 	} else {
 		opts.Parallelism = flags.parallelism
 	}
-	executor := svc.NewExecutor(opts, nil)
+	executor := svc.NewExecutor(opts)
 
 	if errs != nil {
 		return "", "", errs

internal/campaigns/executor.go

@@ -66,8 +66,6 @@ type TaskStatus struct {
 	Err           error
 }
 
-type ExecutorUpdateCallback func(*Task, TaskStatus)
-
 type executor struct {
 	ExecutorOpts
 
@@ -81,13 +79,11 @@ type executor struct {
 	par           *parallel.Run
 	doneEnqueuing chan struct{}
 
-	update ExecutorUpdateCallback
-
 	specs   []*ChangesetSpec
 	specsMu sync.Mutex
 }
 
-func newExecutor(opts ExecutorOpts, client api.Client, update ExecutorUpdateCallback) *executor {
+func newExecutor(opts ExecutorOpts, client api.Client) *executor {
 	return &executor{
 		ExecutorOpts:  opts,
 		cache:         opts.Cache,
@@ -97,7 +93,6 @@ func newExecutor(opts ExecutorOpts, client api.Client, update ExecutorUpdateCall
 		logger:        NewLogManager(opts.TempDir, opts.KeepLogs),
 		tempDir:       opts.TempDir,
 		par:           parallel.NewRun(opts.Parallelism),
-		update:        update,
 	}
 }
 
@@ -272,9 +267,6 @@ func (x *executor) do(ctx context.Context, task *Task) (err error) {
 
 func (x *executor) updateTaskStatus(task *Task, status *TaskStatus) {
 	x.tasks.Store(task, status)
-	if x.update != nil {
-		x.update(task, *status)
-	}
 }
 
 type errTimeoutReached struct{ timeout time.Duration }

internal/campaigns/executor_test.go

@@ -121,7 +121,7 @@ func TestExecutor_Integration(t *testing.T) {
 				opts.Timeout = 5 * time.Second
 			}
 
-			executor := newExecutor(opts, client, nil)
+			executor := newExecutor(opts, client)
 
 			template := &ChangesetTemplate{}
 			for _, r := range tc.repos {

internal/campaigns/service.go

@@ -150,8 +150,8 @@ type ExecutorOpts struct {
 	CacheDir      string
 }
 
-func (svc *Service) NewExecutor(opts ExecutorOpts, update ExecutorUpdateCallback) Executor {
-	return newExecutor(opts, svc.client, update)
+func (svc *Service) NewExecutor(opts ExecutorOpts) Executor {
+	return newExecutor(opts, svc.client)
 }
 
 func (svc *Service) NewWorkspaceCreator(dir string, cleanArchives bool) *WorkspaceCreator {