Fix linting errors (#179)

This is what happens when I play around with VS Code.

Author: mrnugget

cmd/src/actions_create.go

@@ -42,7 +42,10 @@ Examples:
 	)
 
 	handler := func(args []string) error {
-		flagSet.Parse(args)
+		err := flagSet.Parse(args)
+		if err != nil {
+			return err
+		}
 
 		if _, err := os.Stat(*fileFlag); !os.IsNotExist(err) {
 			return fmt.Errorf("file %q already exists", *fileFlag)

cmd/src/actions_exec.go

@@ -152,7 +152,10 @@ Format of the action JSON files:
 	)
 
 	handler := func(args []string) error {
-		flagSet.Parse(args)
+		err := flagSet.Parse(args)
+		if err != nil {
+			return err
+		}
 
 		if !isGitAvailable() {
 			return errors.New("Could not find git in $PATH. 'src actions exec' requires git to be available.")
@@ -168,10 +171,7 @@ Format of the action JSON files:
 			return errors.New("cache is not a valid path")
 		}
 
-		var (
-			actionFile []byte
-			err        error
-		)
+		var actionFile []byte
 
 		if *fileFlag == "-" {
 			actionFile, err = ioutil.ReadAll(os.Stdin)
@@ -290,7 +290,7 @@ Format of the action JSON files:
 					return err
 				}
 
-				c, _ := askForConfirmation(fmt.Sprintf("Create a patch set for the produced patches anyway?"))
+				c, _ := askForConfirmation("Create a patch set for the produced patches anyway?")
 				if !c {
 					return err
 				}
@@ -582,10 +582,6 @@ func diffStatDescription(fileDiffs []*diff.FileDiff) string {
 	return fmt.Sprintf("%d file%s changed", len(fileDiffs), plural)
 }
 
-func diffStatSummary(stat diff.Stat) string {
-	return fmt.Sprintf("%d insertions(+), %d deletions(-)", stat.Added+stat.Changed, stat.Deleted+stat.Changed)
-}
-
 func diffStatDiagram(stat diff.Stat) string {
 	const maxWidth = 20
 	added := float64(stat.Added + stat.Changed)

cmd/src/actions_exec_backend_runner.go

@@ -86,7 +86,10 @@ func (x *actionExecutor) do(ctx context.Context, repo ActionRepo) (err error) {
 	}
 
 	x.updateRepoStatus(repo, status)
-	x.logger.RepoFinished(repo.Name, len(patch) > 0, err)
+	lerr := x.logger.RepoFinished(repo.Name, len(patch) > 0, err)
+	if lerr != nil {
+		return lerr
+	}
 
 	// Add to cache if successful.
 	if err == nil {

cmd/src/actions_exec_logger.go

@@ -20,7 +20,6 @@ var (
 	boldBlack = color.New(color.Bold, color.FgBlack)
 	boldRed   = color.New(color.Bold, color.FgRed)
 	boldGreen = color.New(color.Bold, color.FgGreen)
-	green     = color.New(color.FgGreen)
 	hiGreen   = color.New(color.FgHiGreen)
 	yellow    = color.New(color.FgYellow)
 	grey      = color.New(color.FgHiBlack)

cmd/src/actions_scope_query.go

@@ -35,12 +35,12 @@ Examples:
 	)
 
 	handler := func(args []string) error {
-		flagSet.Parse(args)
+		err := flagSet.Parse(args)
+		if err != nil {
+			return err
+		}
 
-		var (
-			actionFile []byte
-			err        error
-		)
+		var actionFile []byte
 
 		if *fileFlag == "-" {
 			actionFile, err = ioutil.ReadAll(os.Stdin)

cmd/src/api.go

@@ -56,7 +56,10 @@ Examples:
 	)
 
 	handler := func(args []string) error {
-		flagSet.Parse(args)
+		err := flagSet.Parse(args)
+		if err != nil {
+			return err
+		}
 
 		// Build the GraphQL request.
 		query := *queryFlag
@@ -133,7 +136,7 @@ func curlCmd(endpoint, accessToken, query string, vars map[string]interface{}) (
 		return "", err
 	}
 
-	s := fmt.Sprintf("curl \\\n")
+	s := "curl \\\n"
 	if accessToken != "" {
 		s += fmt.Sprintf("   %s \\\n", shellquote.Join("-H", "Authorization: token "+accessToken))
 	}

cmd/src/campaigns_add_changesets.go

@@ -44,7 +44,10 @@ Notes:
 	)
 
 	handler := func(args []string) error {
-		flagSet.Parse(args)
+		err := flagSet.Parse(args)
+		if err != nil {
+			return err
+		}
 
 		if *campaignIDFlag == "" {
 			return &usageError{errors.New("-campaign must be specified")}

cmd/src/campaigns_create.go

@@ -58,7 +58,10 @@ Examples:
 	)
 
 	handler := func(args []string) error {
-		flagSet.Parse(args)
+		err := flagSet.Parse(args)
+		if err != nil {
+			return err
+		}
 
 		var name, description string
 

cmd/src/campaigns_list.go

@@ -38,7 +38,10 @@ Examples:
 	)
 
 	handler := func(args []string) error {
-		flagSet.Parse(args)
+		err := flagSet.Parse(args)
+		if err != nil {
+			return err
+		}
 
 		tmpl, err := parseTemplate(*formatFlag)
 		if err != nil {

cmd/src/cmd.go

@@ -45,10 +45,10 @@ type commander []*command
 func (c commander) run(flagSet *flag.FlagSet, cmdName, usageText string, args []string) {
 	// Parse flags.
 	flagSet.Usage = func() {
-		fmt.Fprintf(flag.CommandLine.Output(), usageText)
+		fmt.Fprint(flag.CommandLine.Output(), usageText)
 	}
 	if !flagSet.Parsed() {
-		flagSet.Parse(args)
+		_ = flagSet.Parse(args)
 	}
 
 	// Print usage if the command is "help".