fix: issues affecting code quality (#471)

* Replace `t.Sub(time.Now())` with `time.Until`

* Remove unnecessary wrapping of function call

* Remove unnecessary blank (_) identifier

* Fix check for empty string

Author: withshubh

cmd/src/headers.go

@@ -29,7 +29,7 @@ func parseAdditionalHeadersFromMap(environ []string) map[string]string {
 		}
 
 		// Ensure we have a non-empty value
-		if len(parts[1]) == 0 {
+		if parts[1] == "" {
 			continue
 		}
 

cmd/src/search.go

@@ -511,9 +511,7 @@ var searchTemplateFuncs = map[string]interface{}{
 	"searchHighlightPreview": func(preview interface{}) string {
 		return searchHighlightPreview(preview, "", "")
 	},
-	"searchHighlightDiffPreview": func(diffPreview interface{}) string {
-		return searchHighlightDiffPreview(diffPreview)
-	},
+	"searchHighlightDiffPreview": searchHighlightDiffPreview,
 	"searchMaxRepoNameLength": func(results []map[string]interface{}) int {
 		max := 0
 		for _, r := range results {
@@ -526,12 +524,8 @@ var searchTemplateFuncs = map[string]interface{}{
 		}
 		return max
 	},
-	"htmlToPlainText": func(input string) string {
-		return htmlToPlainText(input)
-	},
-	"buildVersionHasNewSearchInterface": func(input string) bool {
-		return buildVersionHasNewSearchInterface(input)
-	},
+	"htmlToPlainText":                   htmlToPlainText,
+	"buildVersionHasNewSearchInterface": buildVersionHasNewSearchInterface,
 	"renderResult": func(searchResult map[string]interface{}) string {
 		searchResultBody := searchResult["body"].(map[string]interface{})
 		html := searchResultBody["html"].(string)

internal/campaigns/executor.go

@@ -308,7 +308,7 @@ func (x *executor) do(ctx context.Context, task *Task) (err error) {
 			// add it to the list of specs that are displayed to the user and
 			// send to the server. Instead, we can just report that the task is
 			// complete and move on.
-			if len(result.Diff) == 0 {
+			if result.Diff == "" {
 				x.updateTaskStatus(task, func(status *TaskStatus) {
 					status.Cached = true
 					status.FinishedAt = time.Now()
@@ -398,7 +398,7 @@ func (x *executor) do(ctx context.Context, task *Task) (err error) {
 
 	// If the steps didn't result in any diff, we don't need to add it to the
 	// list of specs that are displayed to the user and send to the server.
-	if len(result.Diff) == 0 {
+	if result.Diff == "" {
 		return
 	}
 

internal/campaigns/templating.go

@@ -250,7 +250,7 @@ func parseGitStatus(out []byte) (StepChanges, error) {
 	result := StepChanges{}
 
 	stripped := strings.TrimSpace(string(out))
-	if len(stripped) == 0 {
+	if stripped == "" {
 		return result, nil
 	}
 

internal/output/_examples/main.go

@@ -50,7 +50,7 @@ func demo(out *output.Output, duration time.Duration) {
 		defer wg.Done()
 
 		i := 0
-		for _ = range ticker.C {
+		for range ticker.C {
 			i += 1
 			if i > 20 {
 				return
@@ -68,7 +68,7 @@ func demo(out *output.Output, duration time.Duration) {
 
 		start := time.Now()
 		until := start.Add(duration)
-		for _ = range ticker.C {
+		for range ticker.C {
 			now := time.Now()
 			if now.After(until) {
 				return
@@ -91,13 +91,13 @@ func demo(out *output.Output, duration time.Duration) {
 		defer pending.Complete(output.Line(output.EmojiSuccess, output.StyleSuccess, "Ticker done!"))
 
 		until := time.Now().Add(duration)
-		for _ = range ticker.C {
+		for range ticker.C {
 			now := time.Now()
 			if now.After(until) {
 				return
 			}
 
-			pending.Updatef("Waiting for another %s", until.Sub(time.Now()))
+			pending.Updatef("Waiting for another %s", time.Until(until))
 		}
 	}()
 
@@ -123,7 +123,7 @@ func demoProgressWithBars(out *output.Output, duration time.Duration) {
 		defer wg.Done()
 
 		i := 0
-		for _ = range ticker.C {
+		for range ticker.C {
 			i += 1
 			if i > 10 {
 				return
@@ -141,7 +141,7 @@ func demoProgressWithBars(out *output.Output, duration time.Duration) {
 
 		start := time.Now()
 		until := start.Add(duration)
-		for _ = range ticker.C {
+		for range ticker.C {
 			now := time.Now()
 			if now.After(until) {
 				return