batches: fix feature detection in src batch validate (#577)

When creating the `Service` instance, `src batch validate` failed to
request or initialise the Sourcegraph feature flags based on the
Sourcegraph version in use. As a result, only baseline features were
enabled when parsing and validating batch specs.

Fixes #576.

Author: LawnGnome

CHANGELOG.md

@@ -13,10 +13,14 @@ All notable changes to `src-cli` are documented in this file.
 
 ### Added
 
+- `src batch validate` now accepts the standard flags used to control communication with Sourcegraph: `-dump-requests`, `-get-curl`, `-insecure-skip-verify`, and `-trace`. [#577](https://github.com/sourcegraph/src-cli/pull/577)
+
 ### Changed
 
 ### Fixed
 
+- `src batch validate` would fail to validate batch specs that use features that depend on specific versions of Sourcegraph, such as workspaces. This has been fixed. [#576](https://github.com/sourcegraph/src-cli/issues/576)
+
 ### Removed
 
 ## 3.30.4

cmd/src/batch_validate.go

@@ -1,10 +1,12 @@
 package main
 
 import (
+	"context"
 	"flag"
 	"fmt"
 
 	"github.com/sourcegraph/sourcegraph/lib/output"
+	"github.com/sourcegraph/src-cli/internal/api"
 	"github.com/sourcegraph/src-cli/internal/batches/service"
 	"github.com/sourcegraph/src-cli/internal/batches/ui"
 	"github.com/sourcegraph/src-cli/internal/cmderrors"
@@ -25,9 +27,12 @@ Examples:
 `
 
 	flagSet := flag.NewFlagSet("validate", flag.ExitOnError)
+	apiFlags := api.NewFlags(flagSet)
 	fileFlag := flagSet.String("f", "", "The batch spec file to read.")
 
 	handler := func(args []string) error {
+		ctx := context.Background()
+
 		if err := flagSet.Parse(args); err != nil {
 			return err
 		}
@@ -36,7 +41,13 @@ Examples:
 			return cmderrors.Usage("additional arguments not allowed")
 		}
 
-		svc := service.New(&service.Opts{})
+		svc := service.New(&service.Opts{
+			Client: cfg.apiClient(apiFlags, flagSet.Output()),
+		})
+
+		if err := svc.DetermineFeatureFlags(ctx); err != nil {
+			return err
+		}
 
 		out := output.NewOutput(flagSet.Output(), output.OutputOpts{Verbose: *verbose})
 		if _, _, err := batchParseSpec(fileFlag, svc); err != nil {