Skip to content

Commit 94eca7b

Browse files
authored
Fix display of status bars when 0 repositories have been matched (#341)
This fixes https://github.com/sourcegraph/sourcegraph/issues/14559 by not printing a progress bar when 0 repositories have been matched.
1 parent af88b4c commit 94eca7b

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

cmd/src/campaign_progress_printer.go

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,13 @@ type campaignProgressPrinter struct {
3838
}
3939

4040
func (p *campaignProgressPrinter) initProgressBar(statuses []*campaigns.TaskStatus) {
41-
statusBars := []*output.StatusBar{}
42-
for i := 0; i < p.numParallelism; i++ {
41+
numStatusBars := p.numParallelism
42+
if len(statuses) < numStatusBars {
43+
numStatusBars = len(statuses)
44+
}
45+
46+
statusBars := make([]*output.StatusBar, 0, numStatusBars)
47+
for i := 0; i < numStatusBars; i++ {
4348
statusBars = append(statusBars, output.NewStatusBarWithLabel("Starting worker..."))
4449
}
4550

@@ -56,6 +61,10 @@ func (p *campaignProgressPrinter) Complete() {
5661
}
5762

5863
func (p *campaignProgressPrinter) PrintStatuses(statuses []*campaigns.TaskStatus) {
64+
if len(statuses) == 0 {
65+
return
66+
}
67+
5968
if p.progress == nil {
6069
p.initProgressBar(statuses)
6170
}

0 commit comments

Comments
 (0)