Also respect client flags in src login command (#480)

This wasn't respecting api flags.
I also had to update the logic for retrieving the endpoint a bit, since it could have picked up a flag.

Author: eseliger

CHANGELOG.md

@@ -15,14 +15,22 @@ All notable changes to `src-cli` are documented in this file.
 
 ### Changed
 
+### Fixed
+
+- The src login command now also properly respects the `-insecure-skip-verify` flag.
+
+### Removed
+
+## 3.25.2
+
+### Changed
+
 - The volume workspace Docker image is now only pulled if the volume workspace mode is in use. [#477](https://github.com/sourcegraph/src-cli/pull/477)
 
 ### Fixed
 
 - Using volume workspace mode could result in Git errors when used with Docker containers that do not run as root. These have been fixed. [#478](https://github.com/sourcegraph/src-cli/issues/478)
 
-### Removed
-
 ## 3.25.1
 
 ### Added

cmd/src/login.go

@@ -9,6 +9,8 @@ import (
 	"io/ioutil"
 	"os"
 	"strings"
+
+	"github.com/sourcegraph/src-cli/internal/api"
 )
 
 func init() {
@@ -32,21 +34,28 @@ Examples:
 	flagSet := flag.NewFlagSet("login", flag.ExitOnError)
 	usageFunc := func() {
 		fmt.Fprintln(flag.CommandLine.Output(), usage)
+		flagSet.PrintDefaults()
 	}
 
+	var (
+		apiFlags = api.NewFlags(flagSet)
+	)
+
 	handler := func(args []string) error {
 		if err := flagSet.Parse(args); err != nil {
 			return err
 		}
 		endpoint := cfg.Endpoint
-		if len(args) == 1 {
-			endpoint = args[0]
+		if flagSet.NArg() >= 1 {
+			endpoint = flagSet.Arg(0)
 		}
 		if endpoint == "" {
 			return &usageError{errors.New("expected exactly one argument: the Sourcegraph URL, or SRC_ENDPOINT to be set")}
 		}
 
-		return loginCmd(context.Background(), cfg, endpoint, os.Stdout)
+		client := cfg.apiClient(apiFlags, ioutil.Discard)
+
+		return loginCmd(context.Background(), cfg, client, endpoint, os.Stdout)
 	}
 
 	commands = append(commands, &command{
@@ -58,7 +67,7 @@ Examples:
 
 var exitCode1 = &exitCodeError{exitCode: 1}
 
-func loginCmd(ctx context.Context, cfg *config, endpointArg string, out io.Writer) error {
+func loginCmd(ctx context.Context, cfg *config, client api.Client, endpointArg string, out io.Writer) error {
 	endpointArg = cleanEndpoint(endpointArg)
 
 	printProblem := func(problem string) {
@@ -97,7 +106,6 @@ func loginCmd(ctx context.Context, cfg *config, endpointArg string, out io.Write
 	var result struct {
 		CurrentUser *struct{ Username string }
 	}
-	client := cfg.apiClient(nil, ioutil.Discard)
 	if _, err := client.NewRequest(query, nil).Do(ctx, &result); err != nil {
 		if strings.HasPrefix(err.Error(), "error: 401 Unauthorized") || strings.HasPrefix(err.Error(), "error: 403 Forbidden") {
 			printProblem("Invalid access token.")

cmd/src/login_test.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"fmt"
+	"io/ioutil"
 	"net/http"
 	"net/http/httptest"
 	"strings"
@@ -15,7 +16,7 @@ func TestLogin(t *testing.T) {
 		t.Helper()
 
 		var out bytes.Buffer
-		err = loginCmd(context.Background(), cfg, endpointArg, &out)
+		err = loginCmd(context.Background(), cfg, cfg.apiClient(nil, ioutil.Discard), endpointArg, &out)
 		return strings.TrimSpace(out.String()), err
 	}