search: only indicate limit hit if reasons say so (#514)

If we hit the display limit we display the statistics with a "+". This
is misleading, since the result count is accurate. So we update the
logic to be the same as used in the webapp.

Author: keegancsmith

cmd/src/search_stream.go

@@ -93,7 +93,16 @@ func textDecoder(query string, t *template.Template, w io.Writer) streaming.Deco
 			if !progress.Done {
 				return
 			}
-			err := t.ExecuteTemplate(w, "progress", progress)
+
+			templateData := struct {
+				streaming.Progress
+				LimitHit bool
+			}{
+				Progress: *progress,
+				LimitHit: isLimitHit(progress),
+			}
+
+			err := t.ExecuteTemplate(w, "progress", &templateData)
 			if err != nil {
 				logError(fmt.Sprintf("error when executing template: %s\n", err))
 			}
@@ -180,6 +189,17 @@ func textDecoder(query string, t *template.Template, w io.Writer) streaming.Deco
 	}
 }
 
+// isLimitHit returns true if any of the skipped reasons indicate a limit was
+// hit. This is the same logic we use in the webapp.
+func isLimitHit(progress *streaming.Progress) bool {
+	for _, p := range progress.Skipped {
+		if strings.Contains(string(p.Reason), "-limit") {
+			return true
+		}
+	}
+	return false
+}
+
 const streamingTemplate = `
 {{define "file"}}
 	{{- /* Repository and file name */ -}}
@@ -265,7 +285,7 @@ const streamingTemplate = `
 	{{- else -}}
 		{{- color "success" -}}
 	{{- end -}}
-	{{- .MatchCount -}}{{if len .Skipped}}+{{end}} results{{- color "nc" -}}
+	{{- .MatchCount -}}{{if .LimitHit}}+{{end}} results{{- color "nc" -}}
 	{{- " in " -}}{{color "success"}}{{msDuration .DurationMs}}{{if .RepositoriesCount}}{{- color "nc" -}}
 	{{- " from " -}}{{color "success"}}{{.RepositoriesCount}}{{- " Repositories" -}}{{- color "nc" -}}{{end}}
 	{{- "\n" -}}