Introduce CommandRunner and CommandRunnerbehaviour

Co-authored-by: wevtimoteo <[email protected]>
Co-authored-by: garaujodev <[email protected]>

Co-authored-by: wevtimoteo <[email protected]>
Co-authored-by: garaujodev <[email protected]>

Author: 3 people

lib/auto_formatter/action.ex

@@ -6,7 +6,7 @@ defmodule AutoFormatter.Action do
     autoformatter _format
   """
 
-  alias AutoFormatter.HookManager
+  alias AutoFormatter.{CommandRunner, HookManager}
 
   def perform(:version) do
     AutoFormatter.version()
@@ -17,7 +17,7 @@ defmodule AutoFormatter.Action do
   end
 
   def perform(:_format) do
-    {output, 0} = System.cmd("git", ["diff", "--name-only"])
+    {:ok, output} = command_runner().run("git", ["diff", "--name-only"])
 
     files_list =
       output
@@ -26,7 +26,7 @@ defmodule AutoFormatter.Action do
       |> tl()
       |> Enum.reverse()
 
-    {_output, 0} = System.cmd("mix", ["format" | files_list])
+    {:ok, _output} = command_runner().run("mix", ["format" | files_list])
 
     "Formatted successfully"
   end
@@ -38,4 +38,8 @@ defmodule AutoFormatter.Action do
   defp hook_manager do
     Application.get_env(:auto_formatter, :hook_manager, HookManager)
   end
+
+  defp command_runner do
+    Application.get_env(:auto_formatter, :command_runner, CommandRunner)
+  end
 end

lib/auto_formatter/behaviours/command_runner_behaviour.ex

@@ -0,0 +1,3 @@
+defmodule AutoFormatter.CommandRunnerBehaviour do
+  @callback run(String.t(), nonempty_list(String.t())) :: {atom(), String.t()}
+end

lib/auto_formatter/command_runner.ex

@@ -0,0 +1,13 @@
+defmodule AutoFormatter.CommandRunner do
+  alias AutoFormatter.CommandRunnerBehaviour
+
+  @behaviour CommandRunnerBehaviour
+
+  @impl CommandRunnerBehaviour
+  def run(command, args \\ [""]) do
+    case System.cmd(command, args) do
+      {output, 0} -> {:ok, output}
+      {output, _exit_status} -> {:error, output}
+    end
+  end
+end