Lint property names that are not code-generation friendly (#588)

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

Author: jviotti

DEPENDENCIES

@@ -1,5 +1,5 @@
 vendorpull https://github.com/sourcemeta/vendorpull 1dcbac42809cf87cb5b045106b863e17ad84ba02
-core https://github.com/sourcemeta/core 44adbe95771afdd1d4188d35e6b3bd9c323d8dca
-jsonbinpack https://github.com/sourcemeta/jsonbinpack 6cef045cf3ef69b779477d60950e5dd8d8796e62
+core https://github.com/sourcemeta/core e4d7ae9358710fc138d2afd3179db6d850e4190f
+jsonbinpack https://github.com/sourcemeta/jsonbinpack 8fae212dc7ec02af4bb0cd4e7fccd42a2471f1c1
 blaze https://github.com/sourcemeta/blaze cd5ebdb49d7d5fac151f7ed89810908d22198e42
 hydra https://github.com/sourcemeta/hydra af9f2c54709d620872ead0c3f8f683c15a0fa702

src/command_canonicalize.cc

@@ -44,8 +44,10 @@ auto sourcemeta::jsonschema::canonicalize(
     sourcemeta::core::SchemaTransformer canonicalizer;
     sourcemeta::core::add(canonicalizer,
                           sourcemeta::core::AlterSchemaMode::Canonicalizer);
-    canonicalizer.apply(schema, sourcemeta::core::schema_walker,
-                        custom_resolver, transformer_callback_noop, dialect);
+    [[maybe_unused]] const auto result = canonicalizer.apply(
+        schema, sourcemeta::core::schema_walker, custom_resolver,
+        transformer_callback_noop, dialect);
+    assert(result.first);
 
     sourcemeta::core::format(schema, sourcemeta::core::schema_walker,
                              custom_resolver, dialect);

test/lint/pass_lint_list_exclude.sh

@@ -157,6 +157,9 @@ property_names_type_default
 required_properties_in_properties
   Every property listed in the `required` keyword must be explicitly defined using the `properties` keyword
 
+simple_properties_identifiers
+  Set `properties` to identifier names that can be easily mapped to programming languages (matching [A-Za-z_][A-Za-z0-9_]*)
+
 single_type_array
   Setting `type` to an array of a single type is the same as directly declaring such type
 
@@ -211,7 +214,7 @@ unsatisfiable_max_contains
 unsatisfiable_min_properties
   Setting `minProperties` to a number less than `required` does not add any further constraint
 
-Number of rules: 67
+Number of rules: 68
 EOF
 
 diff "$TMP/output.txt" "$TMP/expected.txt"

test/lint/pass_lint_list_long.sh

@@ -163,6 +163,9 @@ property_names_type_default
 required_properties_in_properties
   Every property listed in the `required` keyword must be explicitly defined using the `properties` keyword
 
+simple_properties_identifiers
+  Set `properties` to identifier names that can be easily mapped to programming languages (matching [A-Za-z_][A-Za-z0-9_]*)
+
 single_type_array
   Setting `type` to an array of a single type is the same as directly declaring such type
 
@@ -217,7 +220,7 @@ unsatisfiable_max_contains
 unsatisfiable_min_properties
   Setting `minProperties` to a number less than `required` does not add any further constraint
 
-Number of rules: 69
+Number of rules: 70
 EOF
 
 diff "$TMP/output.txt" "$TMP/expected.txt"

test/lint/pass_lint_list_short.sh

@@ -163,6 +163,9 @@ property_names_type_default
 required_properties_in_properties
   Every property listed in the `required` keyword must be explicitly defined using the `properties` keyword
 
+simple_properties_identifiers
+  Set `properties` to identifier names that can be easily mapped to programming languages (matching [A-Za-z_][A-Za-z0-9_]*)
+
 single_type_array
   Setting `type` to an array of a single type is the same as directly declaring such type
 
@@ -217,7 +220,7 @@ unsatisfiable_max_contains
 unsatisfiable_min_properties
   Setting `minProperties` to a number less than `required` does not add any further constraint
 
-Number of rules: 69
+Number of rules: 70
 EOF
 
 diff "$TMP/output.txt" "$TMP/expected.txt"