Better detect unreferenced definitions in the linter (#595)

Signed-off-by: Juan Cruz Viotti <[email protected]>

Author: jviotti

DEPENDENCIES

@@ -1,5 +1,5 @@
 vendorpull https://github.com/sourcemeta/vendorpull 1dcbac42809cf87cb5b045106b863e17ad84ba02
-core https://github.com/sourcemeta/core e4d7ae9358710fc138d2afd3179db6d850e4190f
+core https://github.com/sourcemeta/core 9985d96665aae0a8dfabf63f59b0732b92c64771
 jsonbinpack https://github.com/sourcemeta/jsonbinpack 8fae212dc7ec02af4bb0cd4e7fccd42a2471f1c1
 blaze https://github.com/sourcemeta/blaze 8dba65f8aebfe1ac976168b76e01c20dd406c517
 hydra https://github.com/sourcemeta/hydra af9f2c54709d620872ead0c3f8f683c15a0fa702

src/command_lint.cc

@@ -127,10 +127,6 @@ auto sourcemeta::jsonschema::lint(const sourcemeta::core::Options &options)
   bundle.add<sourcemeta::blaze::ValidDefault>(
       sourcemeta::blaze::default_schema_compiler);
 
-  // TODO: This rule has known problems we are working hard to fix right now
-  // See https://github.com/sourcemeta/core/pull/2145
-  bundle.remove("orphan_definitions");
-
   if (options.contains("only")) {
     if (options.contains("exclude")) {
       throw OptionConflictError{

test/lint/pass_lint_list_exclude.sh

@@ -139,6 +139,9 @@ non_applicable_type_specific_keywords
 not_false
   Setting the `not` keyword to `false` imposes no constraints. Negating `false` yields the always-true schema
 
+orphan_definitions
+  Schema definitions in `$defs` or `definitions` that are never internally referenced can be removed
+
 pattern_properties_default
   Setting the `patternProperties` keyword to the empty object does not add any further constraint
 
@@ -205,13 +208,16 @@ unnecessary_allof_ref_wrapper_modern
 unnecessary_allof_wrapper
   Keywords inside `allOf` that do not conflict with the parent schema can be elevated
 
+unsatisfiable_in_place_applicator_type
+  An in-place applicator branch that defines a `type` with no overlap with the parent `type` can never be satisfied
+
 unsatisfiable_max_contains
   Setting the `maxContains` keyword to a number greater than or equal to the array upper bound does not add any further constraint
 
 unsatisfiable_min_properties
   Setting `minProperties` to a number less than `required` does not add any further constraint
 
-Number of rules: 67
+Number of rules: 69
 EOF
 
 diff "$TMP/output.txt" "$TMP/expected.txt"

test/lint/pass_lint_list_long.sh

@@ -145,6 +145,9 @@ non_applicable_type_specific_keywords
 not_false
   Setting the `not` keyword to `false` imposes no constraints. Negating `false` yields the always-true schema
 
+orphan_definitions
+  Schema definitions in `$defs` or `definitions` that are never internally referenced can be removed
+
 pattern_properties_default
   Setting the `patternProperties` keyword to the empty object does not add any further constraint
 
@@ -211,13 +214,16 @@ unnecessary_allof_ref_wrapper_modern
 unnecessary_allof_wrapper
   Keywords inside `allOf` that do not conflict with the parent schema can be elevated
 
+unsatisfiable_in_place_applicator_type
+  An in-place applicator branch that defines a `type` with no overlap with the parent `type` can never be satisfied
+
 unsatisfiable_max_contains
   Setting the `maxContains` keyword to a number greater than or equal to the array upper bound does not add any further constraint
 
 unsatisfiable_min_properties
   Setting `minProperties` to a number less than `required` does not add any further constraint
 
-Number of rules: 69
+Number of rules: 71
 EOF
 
 diff "$TMP/output.txt" "$TMP/expected.txt"

test/lint/pass_lint_list_short.sh

@@ -145,6 +145,9 @@ non_applicable_type_specific_keywords
 not_false
   Setting the `not` keyword to `false` imposes no constraints. Negating `false` yields the always-true schema
 
+orphan_definitions
+  Schema definitions in `$defs` or `definitions` that are never internally referenced can be removed
+
 pattern_properties_default
   Setting the `patternProperties` keyword to the empty object does not add any further constraint
 
@@ -211,13 +214,16 @@ unnecessary_allof_ref_wrapper_modern
 unnecessary_allof_wrapper
   Keywords inside `allOf` that do not conflict with the parent schema can be elevated
 
+unsatisfiable_in_place_applicator_type
+  An in-place applicator branch that defines a `type` with no overlap with the parent `type` can never be satisfied
+
 unsatisfiable_max_contains
   Setting the `maxContains` keyword to a number greater than or equal to the array upper bound does not add any further constraint
 
 unsatisfiable_min_properties
   Setting `minProperties` to a number less than `required` does not add any further constraint
 
-Number of rules: 69
+Number of rules: 71
 EOF
 
 diff "$TMP/output.txt" "$TMP/expected.txt"