feat: indentation fact (#110) (#154)

Author: yaronskaya

src/main/kotlin/app/FactCodes.kt

@@ -23,4 +23,7 @@ object FactCodes {
     val VARIABLE_NAMING_SNAKE_CASE = 0
     val VARIABLE_NAMING_CAMEL_CASE = 1
     val VARIABLE_NAMING_OTHER = 2
+    val INDENTATION = 14
+    val INDENTATION_TABS = 0
+    val INDENTATION_SPACES = 1
 }

src/main/kotlin/app/hashers/FactHasher.kt

@@ -33,6 +33,7 @@ class FactHasher(private val serverRepo: Repo = Repo(),
     private val fsLineNum = hashMapOf<String, Long>()
     private val fsLinesPerCommits = hashMapOf<String, Array<Int>>()
     private val fsVariableNaming = hashMapOf<String, Array<Int>>()
+    private val fsIndentation = hashMapOf<String, Array<Int>>()
 
     init {
         for (author in emails) {
@@ -47,6 +48,7 @@ class FactHasher(private val serverRepo: Repo = Repo(),
             // TODO(anatoly): Do the bin computations on the go.
             fsLinesPerCommits.put(author, Array(rehashes.size) {0})
             fsVariableNaming.put(author, Array(3) { 0 })
+            fsIndentation.put(author, Array(2) { 0 })
         }
     }
 
@@ -121,6 +123,11 @@ class FactHasher(private val serverRepo: Repo = Repo(),
             fsVariableNaming[email]!![FactCodes.VARIABLE_NAMING_OTHER] +=
                 others
         }
+
+        fsIndentation[email]!![FactCodes.INDENTATION_SPACES] +=
+            lines.count { it.isNotBlank()  &&  it.startsWith(" ") && !it.contains("\t")}
+        fsIndentation[email]!![FactCodes.INDENTATION_TABS] +=
+            lines.count { it.startsWith("\t") }
     }
 
     private fun createFacts(): List<Fact> {
@@ -139,6 +146,12 @@ class FactHasher(private val serverRepo: Repo = Repo(),
                 fs.add(Fact(serverRepo, FactCodes.VARIABLE_NAMING, naming,
                         count.toString(), author))
             }}
+            fsIndentation[email]?.forEachIndexed { indentation, count ->
+                if (count > 0) {
+                    fs.add(Fact(serverRepo, FactCodes.INDENTATION, indentation,
+                            count.toString(), author))
+                }
+            }
 
             fs.add(Fact(serverRepo, FactCodes.REPO_DATE_START, 0,
                         fsRepoDateStart[email].toString(), author))

src/test/kotlin/test/tests/hashers/FactHasherTest.kt

@@ -327,4 +327,46 @@ class FactHasherTest : Spek({
             testRepo.destroy()
         }
     }
+
+    given("commits for indentation facts") {
+        val testRepo = TestRepo(repoPath + "indentation-facts")
+        val emails = hashSetOf(authorEmail1)
+        val mockApi = MockApi(mockRepo = repo)
+        val facts = mockApi.receivedFacts
+
+        afterEachTest {
+            facts.clear()
+        }
+
+        val lines = listOf("\tdef test()", "\t\tdef fn()", "a b c d", "    ", "    def fn()")
+
+        it("sends facts") {
+            for (i in 0..lines.size - 1) {
+                val line = lines[i]
+                val fileName = "file$i.txt"
+                testRepo.createFile(fileName, listOf(line))
+                testRepo.commit(message = "$line in $fileName", author = author1)
+            }
+
+            val errors = mutableListOf<Throwable>()
+            val observable = CommitCrawler.getObservable(testRepo.git, repo)
+            val rehashes = (0..lines.size - 1).map { "r$it" }
+
+            FactHasher(repo, mockApi, rehashes, emails)
+                    .updateFromObservable(observable, { e -> errors.add(e) })
+            if (errors.size > 0) {
+                println(errors[0].message)
+            }
+            assertEquals(0, errors.size)
+
+            assertFactInt(FactCodes.INDENTATION,
+                    FactCodes.INDENTATION_TABS, 2, author1, facts)
+            assertFactInt(FactCodes.INDENTATION,
+                    FactCodes.INDENTATION_SPACES, 1, author1, facts)
+        }
+
+        afterGroup {
+            testRepo.destroy()
+        }
+    }
 })