Skip to content

Commit 53368e7

Browse files
committed
fix(longevity): 'to' commit may be computed wrongly for deleted lines (APP-94)
1 parent 03dec51 commit 53368e7

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

src/main/kotlin/app/hashers/CodeLongevity.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,10 +221,7 @@ class CodeLongevity(private val localRepo: LocalRepo,
221221
if (diff.changeType == DiffEntry.ChangeType.DELETE) {
222222
val fileLoader = repo.open(oldId)
223223
val fileText = RawText(fileLoader.getBytes())
224-
var lines = ArrayList<RevCommitLine>(fileText.size())
225-
for (idx in 0 .. fileText.size() - 1) {
226-
lines.add(RevCommitLine(commit, oldPath, idx))
227-
}
224+
val lines = ArrayList<RevCommitLine>(fileText.size())
228225
files.put(oldPath, lines)
229226
}
230227

src/test/kotlin/test/tests/hashers/CodeLongevityTest.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,12 +138,10 @@ class CodeLongevityTest : Spek({
138138
rev4, fileName, 0,
139139
lines4[1])
140140

141-
/* TODO(alex): the test fails
142141
assertCodeLine("line2",
143142
rev1, fileName, 1,
144143
rev3, fileName, 2,
145144
lines4[2])
146-
*/
147145
}
148146

149147
afterGroup {

0 commit comments

Comments
 (0)