feat: relative path support (#149)

Author: osilla

src/main/kotlin/app/Logger.kt

@@ -93,7 +93,8 @@ object Logger {
     }
 
     private fun configLevelValue() : Int {
-        val a = mapOf("trace" to TRACE, "debug" to DEBUG, "info" to INFO, "warn" to WARN, "error" to ERROR)
+        val a = mapOf("trace" to TRACE, "debug" to DEBUG, "info" to INFO,
+            "warn" to WARN, "error" to ERROR)
         return a.getValue(BuildConfig.LOG_LEVEL)
     }
 

src/main/kotlin/app/Main.kt

@@ -11,6 +11,7 @@ import app.utils.CommandConfig
 import app.utils.CommandAdd
 import app.utils.CommandList
 import app.utils.CommandRemove
+import app.utils.FileHelper.toPath
 import app.utils.Options
 import app.utils.PasswordHelper
 import app.utils.RepoHelper
@@ -75,9 +76,9 @@ class Main(argv: Array<String>) {
     }
 
     private fun doAdd(commandAdd: CommandAdd) {
-        val path = commandAdd.path
+        val path = commandAdd.path?.toPath()
         if (path != null && RepoHelper.isValidRepo(path)) {
-            val localRepo = LocalRepo(path)
+            val localRepo = LocalRepo(path.toString())
             localRepo.hashAllContributors = commandAdd.hashAll
             configurator.addLocalRepoPersistent(localRepo)
             configurator.saveToFile()

src/main/kotlin/app/config/FileConfigurator.kt

@@ -212,7 +212,7 @@ class FileConfigurator : Configurator {
 
         try {
             loadConfig = Files.newBufferedReader(FileHelper
-                .getPath(CONFIG_FILE_NAME)).use {
+                .toPath(CONFIG_FILE_NAME)).use {
                 mapper.readValue(it, Config::class.java)
             }
         } catch (e: IOException) {
@@ -241,7 +241,7 @@ class FileConfigurator : Configurator {
      */
     override fun saveToFile() {
         try {
-            Files.newBufferedWriter(FileHelper.getPath(CONFIG_FILE_NAME)).use {
+            Files.newBufferedWriter(FileHelper.toPath(CONFIG_FILE_NAME)).use {
                 mapper.writeValue(it, persistent)
             }
         } catch (e: IOException) {

src/main/kotlin/app/hashers/CodeLongevity.kt

@@ -151,7 +151,7 @@ class CodeLongevity(private val serverRepo: Repo,
         catch(e: Exception) { throw Exception("No branch") }
 
     val df = DiffFormatter(DisabledOutputStream.INSTANCE)
-    val dataPath = FileHelper.getPath(serverRepo.rehash, "longevity")
+    val dataPath = FileHelper.toPath(serverRepo.rehash, "longevity")
 
     init {
         df.setRepository(repo)

src/main/kotlin/app/hashers/RepoHasher.kt

@@ -9,6 +9,7 @@ import app.config.Configurator
 import app.model.Author
 import app.model.LocalRepo
 import app.model.Repo
+import app.utils.FileHelper.toPath
 import app.utils.HashingException
 import app.utils.RepoHelper
 import org.eclipse.jgit.api.Git
@@ -17,11 +18,11 @@ import java.io.IOException
 import kotlin.collections.HashSet
 
 class RepoHasher(private val localRepo: LocalRepo, private val api: Api,
-                 private  val configurator: Configurator) {
+                 private val configurator: Configurator) {
     var serverRepo: Repo = Repo()
 
     init {
-        if (!RepoHelper.isValidRepo(localRepo.path)) {
+        if (!RepoHelper.isValidRepo(localRepo.path.toPath())) {
             throw IllegalArgumentException("Invalid repo $localRepo")
         }
     }

src/main/kotlin/app/ui/AddRepoState.kt

@@ -7,6 +7,7 @@ import app.Logger
 import app.api.Api
 import app.config.Configurator
 import app.model.LocalRepo
+import app.utils.FileHelper.toPath
 import app.utils.RepoHelper
 import app.utils.UiHelper
 
@@ -28,12 +29,13 @@ class AddRepoState constructor(private val context: Context,
                 if (configurator.getLocalRepos().isEmpty()) {
                     Logger.print("Add at least one valid repository.")
                 } else {
-                    break // User finished to add repos.
+                    break  // User finished to add repos.
                 }
             } else {
-                if (RepoHelper.isValidRepo(pathString)) {
-                    Logger.print("Added git repository at $pathString.")
-                    val localRepo = LocalRepo(pathString)
+                val path = pathString.toPath()
+                if (RepoHelper.isValidRepo(path)) {
+                    Logger.print("Added git repository at $path.")
+                    val localRepo = LocalRepo(path.toString())
                     localRepo.hashAllContributors = UiHelper.confirm("Do you "
                         + "want to hash commits of all contributors?",
                         defaultIsYes = true)

src/main/kotlin/app/utils/FileHelper.kt

@@ -3,6 +3,7 @@
 
 package app.utils
 
+import app.Logger
 import java.io.File
 import java.net.URLDecoder
 import java.nio.file.Files
@@ -17,7 +18,7 @@ object FileHelper {
     private val jarPath = getJarPath()
     private val settingsPath = jarPath.resolve(dirName)
 
-    fun getPath(name: String, vararg parts: String): Path {
+    fun toPath(name: String, vararg parts: String): Path {
         val path = settingsPath.resolve(Paths.get("", *parts))
         if (Files.notExists(path)) {
             Files.createDirectories(path)
@@ -26,11 +27,11 @@ object FileHelper {
     }
 
     fun getFile(name: String, vararg parts: String): File {
-        return getPath(name, *parts).toFile()
+        return toPath(name, *parts).toFile()
     }
 
     fun notExists(name:String, vararg parts: String): Boolean {
-        return Files.notExists(getPath(name, *parts))
+        return Files.notExists(toPath(name, *parts))
     }
 
     fun getFileExtension(path: String): String {
@@ -47,4 +48,13 @@ object FileHelper {
         // Removing jar filename.
         return root.resolve(fullPath.subpath(0, fullPath.nameCount - 1))
     }
+
+    fun String.toPath(): Path {
+        val substitutePath = if (this.startsWith("~" + File.separator)) {
+            System.getProperty("user.home") + this.substring(1)
+        } else { this }
+        val pathTemp = Paths.get(substitutePath).toAbsolutePath().normalize()
+        println(pathTemp.toString())
+        return pathTemp
+    }
 }

src/main/kotlin/app/utils/RepoHelper.kt

@@ -12,13 +12,14 @@ import org.eclipse.jgit.lib.ObjectId
 import org.eclipse.jgit.lib.Repository
 import java.io.File
 import java.nio.file.InvalidPathException
+import java.nio.file.Path
 import java.nio.file.Paths
 
 /**
  * Class for utility functions on repos.
  */
 object RepoHelper {
-    fun isValidRepo(path: String): Boolean {
+    fun isValidRepo(path: Path): Boolean {
         if (!isDirectory(path)) {
             return false
         }
@@ -27,7 +28,7 @@ object RepoHelper {
         var repository: Repository? = null
         val commitId: ObjectId?
         try {
-            git = Git.open(File(path))
+            git = Git.open(path.toFile())
             repository = git.repository
             commitId = CommitCrawler.getDefaultBranchHead(git)
         } catch (e: Exception) {
@@ -44,9 +45,9 @@ object RepoHelper {
         return false
     }
 
-    fun isDirectory(path: String): Boolean {
+    fun isDirectory(path: Path): Boolean {
         return try {
-            Paths.get(path).toFile().isDirectory
+            path.toFile().isDirectory
         } catch (e: InvalidPathException) {
             Logger.error(e, "Invalid path")
             false

src/test/kotlin/test/tests/utils/FileHelperTest.kt

@@ -0,0 +1,27 @@
+// Copyright 2017 Sourcerer Inc. All Rights Reserved.
+// Author: Ryan Osilla ([email protected])
+
+package test.tests.utils
+
+import org.jetbrains.spek.api.Spek
+import org.jetbrains.spek.api.dsl.given
+import org.jetbrains.spek.api.dsl.it
+import kotlin.test.assertEquals
+import app.utils.FileHelper.toPath
+import java.nio.file.Paths
+
+fun testPath(expectedPath: String, actualPath: String) {
+    assertEquals(Paths.get(expectedPath), actualPath.toPath())
+}
+
+class FileHelperTest : Spek({
+    given("relative path test") {
+        it("basic") {
+            val home = System.getProperty("user.home")
+            testPath("/Users/user/repo", "/Users/user/repo")
+            testPath("/Users/user/repo", "/Users/user/../user/repo/../repo")
+            testPath("$home/test", "~/test")
+            testPath("$home/test1", "~/test/../test1")
+        }
+    }
+})