Skip to content

Commit 14c5358

Browse files
committed
Formalize PR code review policy w/ pullapprove.com
- Right now: - At least one person form SI (@zbeekman, @rouson, @afanfa) must approve a PR - Approver may be the PR Author - This is the regexp to match approval via comments: `'^([Aa]pproved|:\+1:|:shipit:|:ship: it|LGTM|:zap:|:boom:|:clap:|:bow:)'` - This is the regexp to reject via comment: `'^([Nn]ope|[Nn]ope\.jpg|[Dd]enied|[Rr]ejected|:\-1:)'` - Approve or reject at pullapprove.com as well
1 parent 327523d commit 14c5358

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

.gitattributes

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ install_prerequisites/build text
2424

2525
# Prevent dev-ops files from making it into the release archives
2626
.travis.yml export-ignore
27+
.pullapprove.yml export-ignore
2728
.gitattributes export-ignore
2829
.gitignore export-ignore
2930
developer-scripts export-ignore

.pullapprove.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
approve_by_comment: true
2+
approve_regex: '^([Aa]pproved|:\+1:|:shipit:|:ship: it|LGTM|:zap:|:boom:|:clap:|:bow:)'
3+
reject_regex: '^([Nn]ope|[Nn]ope\.jpg|[Dd]enied|[Rr]ejected|:\-1:)'
4+
reset_on_push: true
5+
author_approval: default
6+
reviewers:
7+
required: 1
8+
members:
9+
- afanfa
10+
- rouson
11+
- zbeekman

0 commit comments

Comments
 (0)