Skip to content

Commit 173f3e4

Browse files
author
Damian Rouson
committed
prevent silent failure of events integration test
src/tests/integration/events/async-hello.F90 was failing silently with GCC 7. This commit bumps the image count to 3 so the test prints output that reports the fatal MPI error. This commit also uses C preprocessor conditionals to prevent reporting success for this test with GCC 7. The pre-processor conditionals will need to be removed manually when the silent failure has been eliminated.
1 parent 4c7d1e7 commit 173f3e4

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ if(opencoarrays_aware_compiler)
399399
add_mpi_test(hello_multiverse 2 ${tests_root}/integration/coarrayHelloWorld/hello_multiverse)
400400
add_mpi_test(coarray_burgers_pde 2 ${tests_root}/integration/pde_solvers/coarrayBurgers/coarray_burgers_pde)
401401
add_mpi_test(co_heat 2 ${tests_root}/integration/pde_solvers/coarrayHeatSimplified/co_heat)
402-
add_mpi_test(asynchronous_hello_world 2 ${tests_root}/integration/events/asynchronous_hello_world)
402+
add_mpi_test(asynchronous_hello_world 3 ${tests_root}/integration/events/asynchronous_hello_world)
403403
if ( ("${CMAKE_SYSTEM_PROCESSOR}" MATCHES "x86_64") AND ("${CMAKE_SYSTEM_NAME}" MATCHES "Linux") )
404404
if ( (NOT (DEFINED ENV{TRAVIS})) AND (NOT SKIP_ASSEMBLY_DEPS) )
405405
add_mpi_test(coarray_navier_stokes 2 ${tests_root}/integration/pde_solvers/navier-stokes/coarray_navier_stokes)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
add_executable(asynchronous_hello_world async-hello.f90)
1+
add_executable(asynchronous_hello_world async-hello.F90)
22
target_link_libraries(asynchronous_hello_world OpenCoarrays)

src/tests/integration/events/async-hello.f90 renamed to src/tests/integration/events/async-hello.F90

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,11 @@ program main
6969
end do
7070

7171
sync all
72+
! Hardwire failure with GCC 7 (remove this preprocessor conditional after the silent failure with GCC 7 has been eliminated)
73+
#if __GNUC__ >= 7
74+
#else
7275
if (me==1) print *,"Test passed."
76+
#endif
7377

7478
end associate
7579

0 commit comments

Comments
 (0)