Skip to content

Commit 308985c

Browse files
committed
Make debug output really debug output.
1 parent 5c6fc31 commit 308985c

File tree

1 file changed

+14
-15
lines changed

1 file changed

+14
-15
lines changed

src/mpi/mpi_caf.c

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -830,17 +830,16 @@ finalize_internal (int status_code)
830830
MPI_Cancel (&alive_request);
831831

832832
if (status_code == 0) {
833-
/* In finalization don't stopped or failed images any more. */
833+
/* In finalization do not report stopped or failed images any more. */
834834
MPI_Errhandler_set (CAF_COMM_WORLD, MPI_ERRORS_RETURN);
835-
// MPI_Errhandler_set (lock_comm, MPI_ERRORS_RETURN);
836835
MPI_Errhandler_set (alive_comm, MPI_ERRORS_RETURN);
837836
/* Only add a conventional barrier to prevent images from quitting to early,
838837
* when this images is not failing. */
839838
dprint ("%d/%d: %s: Before MPI_Barrier (CAF_COMM_WORLD)\n",
840-
caf_this_image, caf_num_images, __FUNCTION__);
839+
caf_this_image, caf_num_images, __FUNCTION__);
841840
int ierr = MPI_Barrier (CAF_COMM_WORLD);
842841
dprint ("%d/%d: %s: After MPI_Barrier (CAF_COMM_WORLD) = %d\n",
843-
caf_this_image, caf_num_images, __FUNCTION__, ierr);
842+
caf_this_image, caf_num_images, __FUNCTION__, ierr);
844843
}
845844
else
846845
return;
@@ -871,18 +870,18 @@ finalize_internal (int status_code)
871870
prev = tmp_tot->prev;
872871
p = TOKEN(tmp_tot->token);
873872
dprint ("%d/%d: %s: Before CAF_Win_unlock_all (*p)\n",
874-
caf_this_image, caf_num_images, __FUNCTION__);
873+
caf_this_image, caf_num_images, __FUNCTION__);
875874
CAF_Win_unlock_all (*p);
876875
dprint ("%d/%d: %s: After CAF_Win_unlock_all (*p)\n",
877-
caf_this_image, caf_num_images, __FUNCTION__);
876+
caf_this_image, caf_num_images, __FUNCTION__);
878877
#ifdef GCC_GE_7
879878
/* Unregister the window to the descriptors when freeing the token. */
880879
mpi_caf_token_t *mpi_token = (mpi_caf_token_t *)tmp_tot->token;
881880
if (mpi_token->desc)
882881
{
883882
CAF_Win_unlock_all (*(mpi_token->desc));
884-
MPI_Win_free (mpi_token->desc);
885-
free (mpi_token->desc);
883+
MPI_Win_free (mpi_token->desc);
884+
free (mpi_token->desc);
886885
}
887886
MPI_Win_free (p);
888887
/* Free the memory only, when it was allocated by the caf-library. */
@@ -1046,7 +1045,7 @@ PREFIX (register) (size_t size, caf_register_t type, caf_token_t *token,
10461045
if (type == CAF_REGTYPE_COARRAY_ALLOC_REGISTER_ONLY)
10471046
{
10481047
int ierr = MPI_Win_create_dynamic (MPI_INFO_NULL, CAF_COMM_WORLD, p);
1049-
fprintf(stderr, "%d/%d: Register win = %p, ierr= %d\n", caf_this_image, caf_num_images,
1048+
dprint ("%d/%d: Register win = %p, ierr= %d\n", caf_this_image, caf_num_images,
10501049
*p, ierr);
10511050
CAF_Win_lock_all (*p);
10521051
}
@@ -1058,7 +1057,7 @@ PREFIX (register) (size_t size, caf_register_t type, caf_token_t *token,
10581057
ierr = MPI_Win_attach (*p, mem, actual_size);
10591058
CAF_Win_lock_all (*p);
10601059
*(mpi_token->flags) |= (FLAG_ASSOCIATED | FLAG_MEM_NOT_OWNED);
1061-
fprintf(stderr, "%d/%d: Attach mem %p to win = %p, ierr: %d, flags: %u\n",
1060+
dprint ("%d/%d: Attach mem %p to win = %p, ierr: %d, flags: %u\n",
10621061
caf_this_image, caf_num_images, mem, *p, ierr, *mpi_token->flags);
10631062
}
10641063
else
@@ -1184,7 +1183,7 @@ PREFIX (register) (size_t size, caf_register_t type, caf_token_t *token,
11841183
free(init_array);
11851184
}
11861185

1187-
PREFIX(sync_all) (NULL,NULL,0);
1186+
PREFIX(sync_all) (NULL, NULL, 0);
11881187

11891188
caf_static_t *tmp = malloc (sizeof (caf_static_t));
11901189
tmp->prev = caf_tot;
@@ -1364,7 +1363,7 @@ PREFIX (sync_all) (int *stat, char *errmsg, int errmsg_len)
13641363
{
13651364
int ierr = 0;
13661365

1367-
fprintf (stderr, "%d/%d: Entering sync all.\n", caf_this_image, caf_num_images);
1366+
dprint ("%d/%d: Entering sync all.\n", caf_this_image, caf_num_images);
13681367
if (unlikely (caf_is_finalized))
13691368
ierr = STAT_STOPPED_IMAGE;
13701369
else
@@ -1414,7 +1413,7 @@ PREFIX (sync_all) (int *stat, char *errmsg, int errmsg_len)
14141413
else if (stat == NULL)
14151414
caf_runtime_error (msg);
14161415
}
1417-
fprintf (stderr, "%d/%d: Leaving sync all.\n", caf_this_image, caf_num_images);
1416+
dprint ("%d/%d: Leaving sync all.\n", caf_this_image, caf_num_images);
14181417
}
14191418

14201419
/* token: The token of the array to be written to. */
@@ -2527,7 +2526,7 @@ convert_type (void *dst, int dst_type, int dst_kind, void *src, int src_type,
25272526
}
25282527

25292528
error:
2530-
fprintf (stderr, "libcaf_single RUNTIME ERROR: Cannot convert type %d kind "
2529+
fprintf (stderr, "libcaf_mpi RUNTIME ERROR: Cannot convert type %d kind "
25312530
"%d to type %d kind %d\n", src_type, src_kind, dst_type, dst_kind);
25322531
if (stat)
25332532
*stat = 1;
@@ -3549,7 +3548,7 @@ PREFIX(is_present) (caf_token_t token, int image_index, caf_reference_t *refs)
35493548
int ierr = MPI_Get (&remote_flags, sizeof (unsigned), MPI_BYTE,
35503549
image_index - 1, 0, sizeof (unsigned), MPI_BYTE,
35513550
mpi_token->flags_win);
3552-
fprintf(stderr, "%d/%d: Got remote_flags[%d] for win %p to be: %u, ierr = %d\n",
3551+
dprint ("%d/%d: Got remote_flags[%d] for win %p to be: %u, ierr = %d\n",
35533552
caf_this_image, caf_num_images, image_index, mpi_token->flags_win,
35543553
remote_flags, ierr);
35553554
return (remote_flags & FLAG_ASSOCIATED) > 0;

0 commit comments

Comments
 (0)