Fix shellcheck issues in caf wrapper scripts

Author: zbeekman

src/extensions/caf-foot

@@ -1,4 +1,4 @@
-cmd=`basename $0`
+cmd=$(basename "$0")
 
 usage()
 {
@@ -24,7 +24,7 @@ usage()
     echo " 1. With an OpenCoarrays-Aware (OCA) compiler (GNU 5.1.0 or later),"
     echo "   a. If any of the options listed above appear, any remaining arguments are ignored."
     echo "   b. If present, <fortran-source-file> must"
-    echo "      * be a Fortran source file," 
+    echo "      * be a Fortran source file,"
     echo "      * appear before all other arguments,"
     echo "      * be the only Fortran source file in the argument list,"
     echo "      * have a name of the form *.f90, *.F90, *.f, or *.F. "
@@ -87,28 +87,28 @@ elif [[ $1 == '-h' || $1 == '--help' ]]; then
   exit 1
 elif [ "$caf_compiler" = "true" ]; then
   # Nothing to do other than invoke the compiler with all the command-line arguments:
-  $CAFC "$@" -L $caf_lib_dir $link_args
+  $CAFC "$@" -L "$caf_lib_dir" $link_args
 else
   # Verify that a file with the .f90, .F90, .f, or .F extension is the first argument:
-  src_extension=`echo "$1" | cut -f2 -d'.'`
+  src_extension=$(echo "$1" | cut -f2 -d'.')
   if [[ $src_extension == 'f90' || $src_extension == 'F90' || $src_extension == 'f' || $src_extension == 'F' ]]; then
     # copy the source file into a new file for pre-processing (preprending "caf-" to the new file name):
-    cp $1 caf-$1
+    cp "$1" "caf-$1"
     # Edit the copied source to replace CAF syntax with calls to public procedures in opencoarrays.f90:
     if [ "$linux" = "true" ]; then
-      sed -i'' 's/sync all/call sync_all/g' caf-$1
-      sed -i'' 's/error stop/call error_stop/g' caf-$1
-      sed -i'' 's/sync images/call sync_images/g' caf-$1
+      sed -i'' 's/sync all/call sync_all/g' "caf-$1"
+      sed -i'' 's/error stop/call error_stop/g' "caf-$1"
+      sed -i'' 's/sync images/call sync_images/g' "caf-$1"
     else
       # This works on OS X and other POSIX-compliant operating systems:
-      sed -i '' 's/sync all/call sync_all/g' caf-$1
-      sed -i '' 's/error stop/call error_stop/g' caf-$1
-      sed -i '' 's/sync images/call sync_images/g' caf-$1
+      sed -i '' 's/sync all/call sync_all/g' "caf-$1"
+      sed -i '' 's/error stop/call error_stop/g' "caf-$1"
+      sed -i '' 's/sync images/call sync_images/g' "caf-$1"
     fi
     # Replace the file name in command-line argment 1 with the new name beofre invoking the compiler:
-    set -- "caf-$1" "${@:2:max_arguments}"
+    set -- "caf-$1" "${@:2:$max_arguments}"
     # Invoke the compiler along with all command-line arguments:
-    $CAFC "$@" -L $caf_lib_dir -I $caf_mod_dir $link_args
+    $CAFC "$@" -L "$caf_lib_dir" -I "$caf_mod_dir" $link_args
   else
     # Print usage information upon encountering an unknowon CAF source file extension
     usage | less

src/extensions/caf-head

@@ -3,11 +3,11 @@
 # Coarray Fortran (CAF) Compiler Wrapper
 #
 # Invokes the chosen Fortran compiler with the received command-line
-# arguments. 
+# arguments.
 #
 # Copyright (c) 2015-2016, Sourcery, Inc.
 # All rights reserved.
-# 
+#
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
 #     * Redistributions of source code must retain the above copyright
@@ -18,7 +18,7 @@
 #     * Neither the name of the Sourcery, Inc., nor the
 #       names of its contributors may be used to endorse or promote products
 #       derived from this software without specific prior written permission.
-# 
+#
 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
 # ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
 # WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
@@ -28,5 +28,5 @@
 # LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
 # ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
-# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
+# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #

src/extensions/cafrun-foot

@@ -1,6 +1,6 @@
-usage()
+Usage()
 {
-    cmd=`basename $0`
+    cmd=$(basename "$0")
     echo ""
     echo " $cmd - Coarray Fortran executable launcher for OpenCoarrays"
     echo ""
@@ -29,6 +29,7 @@ if [ $# == 0 ]; then
   usage
 elif [[ $1 == '-v' || $1 == '-V' || $1 == '--version' ]]; then
   echo ""
+  # shellcheck disable=SC2154
   echo "OpenCoarrays Coarray Fortran Executable Launcher (caf version $caf_version)"
   echo "Copyright (C) 2015-2016 Sourcery, Inc."
   echo ""

src/extensions/cafrun-head

@@ -4,7 +4,7 @@
 #
 # Copyright (c) 2015-2016, Sourcery, Inc.
 # All rights reserved.
-# 
+#
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
 #     * Redistributions of source code must retain the above copyright
@@ -15,7 +15,7 @@
 #     * Neither the name of the Sourcery, Inc., nor the
 #       names of its contributors may be used to endorse or promote products
 #       derived from this software without specific prior written permission.
-# 
+#
 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
 # ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
 # WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
@@ -25,11 +25,11 @@
 # LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
 # ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
-# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
- 
+# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
 # This script invokes the chosen Fortran compiler with the received command-line
 # arguments.  Current assumptions:
 #    1. The only argument is either an informational flag or a CAF executable
-#       file. 
-#    2. The environment variable "FC" is used to determine the identity fo the Fortran compiler/linker. 
-#    3. If "FC" is empty, a default value of "mpif90" is used. 
+#       file.
+#    2. The environment variable "FC" is used to determine the identity fo the Fortran compiler/linker.
+#    3. If "FC" is empty, a default value of "mpif90" is used.