Add pull request template

 Fix typo in CONTRIBUTING.md

Author: zbeekman

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,65 @@
+<!-- Please fill out the pull request template included below, failure -->
+<!-- to do so may result in immediate closure of your pull request. -->
+
+<!-- Fill out all portions of this template that apply. Please delete -->
+<!-- any unnecessary sections. -->
+
+This pull request (PR) is a:
+ - [ ] Bug fix
+ - [ ] Feature addition
+ - [ ] Other, Please describe:
+
+I certify that:
+
+ - [ ] I have reviewed the [contributing guidelines]
+ - [ ] If this PR is a work in progress I have added `WIP:` to the
+       beginning of the PR title
+ - [ ] If this PR is problematic for any reason, I have added
+       `DO NOT MERGE:` to the beginning of the title
+ - [ ] The branch name and title of this PR contains the text
+       `issue-<#>` where `<#>` is replaced by the issue that this PR
+       is addressing
+ - [ ] I have deleted trailing white space on any lines that this PR
+       touches
+ - [ ] I have used spaces for indentation on any lines that this PR
+       touches
+ - [ ] I have included some comments to explain non-obvious code
+       changes
+ - [ ] I have run the tests localy (`ctest`) and all tests pass
+ - [ ] Each commit is a logically atomic, self-consistent, cohesive
+       set of changes
+ - [ ] The [commit message] should follow [these guidelines]:
+     - [ ] First line is directive phrase, starting with a capitalized
+           imperative verb, and is no longer than 50 characters
+           summarizing your commit
+     - [ ] Next line, if necessary is blank
+     - [ ] Following lines are all wrapped at 72 characters and can
+           include additional paragraphs, bulleted lists, etc.
+     - [ ] Use [Github keywords] where appropriate, to indicate the
+           commit resolves an open issue.
+ - [ ] I have signed  [Contributor License Agreement (CLA)] by
+       clicking the "details" link to the right of the `licence/cla`
+       check and following the directions on the CLA assistant webpage
+
+## Summary of changes ##
+
+Summarize what you changed
+
+## Rationale for changes ##
+
+Why did you make these changes?
+
+## For contributors and SI team members with code review priviledges ##
+
+ - [ ] I certify that I will wait 24 hours before self-approving via
+       [pullapprove comment] or [Github code review] so that someone
+       else has the chance to review my proposed changes
+
+[links]:#
+[contributing guidelines]: https://github.com/sourceryinstitute/opencoarrays/blob/master/CONTRIBUTING.md
+[commit message]: https://robots.thoughtbot.com/5-useful-tips-for-a-better-commit-message
+[these guidelines]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
+[Contributor License Agreement (CLA)]: https://cla-assistant.io/sourceryinstitute/opencoarrays
+[pullapprove comment]: https://pullapprove.com/sourceryinstitute/opencoarrays/settings/
+[Github code review]: https://help.github.com/articles/about-pull-request-reviews/
+[Github keywords]: https://help.github.com/articles/closing-issues-via-commit-messages/

CONTRIBUTING.md

@@ -71,7 +71,7 @@ Here is a checklist to help you get started contributing to OpenCoarrays and wal
      - [ ] Next line, if necessary is blank
      - [ ] Following lines are all wrapped at 72 characters and can include additional paragraphs, bulleted lists, etc.
      - [ ] Use [Github keywords] where appropriate, to indicate the commit resolves an open issue.
- - [ ] Please do you best to keep a [clean and coherent history]. `git add -p ...`, `git commit --amend` and `git rebase --interactive <root-ref>` can be helpful to rework your commits into a cleaner, clearer state.
+ - [ ] Please do your best to keep a [clean and coherent history]. `git add -p ...`, `git commit --amend` and `git rebase --interactive <root-ref>` can be helpful to rework your commits into a cleaner, clearer state.
  - [ ] Next, [open up a pull request] where the base branch is [`master`] or [`devel`] as appropriate
  - [ ] Please be patient and responsive to requests and comments from SourceryInstitute (SI) team members. You may be asked to amend or otherwise alter commits, or push new commits to your branch.
  - [ ] Make sure that all the automated [Travis-CI tests] pass