Skip to content

Commit 3a95ece

Browse files
committed
Small cosmetic fixes to improve logging and prevent valgrind from bickering.
1 parent b57626d commit 3a95ece

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

src/mpi/mpi_caf.c

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,7 +1151,7 @@ PREFIX(register) (size_t size, caf_register_t type, caf_token_t *token,
11511151
/* Create or allocate a slave token. */
11521152
mpi_caf_slave_token_t *slave_token;
11531153
#ifdef EXTRA_DEBUG_OUTPUT
1154-
MPI_Aint mpi_address;
1154+
MPI_Aint mpi_address = 0;
11551155
#endif
11561156
CAF_Win_unlock_all(global_dynamic_win);
11571157
if (type == CAF_REGTYPE_COARRAY_ALLOC_REGISTER_ONLY)
@@ -4651,17 +4651,17 @@ PREFIX(get_by_ref) (caf_token_t token, int image_index,
46514651
src = (gfc_descriptor_t *)&src_desc;
46524652
if (access_desc_through_global_win)
46534653
{
4654-
dprint("remote desc fetch from %p, offset = %zd\n",
4655-
remote_base_memptr, desc_offset);
4654+
dprint("remote desc fetch from %p, offset = %zd, ref_rank = %d\n",
4655+
remote_base_memptr, desc_offset, ref_rank);
46564656
MPI_Get(src, sizeof_desc_for_rank(ref_rank), MPI_BYTE, global_dynamic_win_rank,
46574657
MPI_Aint_add((MPI_Aint)remote_base_memptr, desc_offset),
46584658
sizeof_desc_for_rank(ref_rank), MPI_BYTE,
46594659
global_dynamic_win);
46604660
}
46614661
else
46624662
{
4663-
dprint("remote desc fetch from win %d, offset = %zd\n",
4664-
mpi_token->memptr_win, desc_offset);
4663+
dprint("remote desc fetch from win %d, offset = %zd, ref_rank = %d\n",
4664+
mpi_token->memptr_win, desc_offset, ref_rank);
46654665
MPI_Get(src, sizeof_desc_for_rank(ref_rank), MPI_BYTE, memptr_win_rank,
46664666
desc_offset, sizeof_desc_for_rank(ref_rank), MPI_BYTE,
46674667
mpi_token->memptr_win);
@@ -4672,8 +4672,7 @@ PREFIX(get_by_ref) (caf_token_t token, int image_index,
46724672
src = mpi_token->desc;
46734673

46744674
#ifdef EXTRA_DEBUG_OUTPUT
4675-
dprint("remote desc rank: %zd (ref_rank: %zd)\n",
4676-
GFC_DESCRIPTOR_RANK(src), ref_rank);
4675+
dprint("remote desc rank: %zd\n", GFC_DESCRIPTOR_RANK(src));
46774676
for (i = 0; i < GFC_DESCRIPTOR_RANK(src); ++i)
46784677
{
46794678
dprint("remote desc dim[%zd] = (lb=%zd, ub=%zd, stride=%zd)\n",
@@ -4754,8 +4753,8 @@ case kind: \
47544753
caf_runtime_error(unknownarrreftype, stat, NULL, 0);
47554754
return;
47564755
}
4757-
dprint("i = %zd, array_ref = %s, delta = %ld\n", i,
4758-
caf_array_ref_str[array_ref], delta);
4756+
dprint("i = %zd, array_ref = %s, delta = %ld, in_array_ref = %d, arr_ext_fixed = %d, realloc_required = %d\n", i,
4757+
caf_array_ref_str[array_ref], delta, in_array_ref, array_extent_fixed, realloc_required);
47594758
if (delta <= 0)
47604759
return;
47614760
/* Check the various properties of the destination array.

0 commit comments

Comments
 (0)