Fix permissions and make script test more robust

 - Permissions for scripts should be  u=rwx,g=rx,o=rx (755)
 - Shell script test had permissions issues in the past, and
   `configure_file( ... )` was being used, where `file( COPY ...` should
   have been used instead.

Author: zbeekman

cmake/AddInstallationScriptTest.cmake

@@ -1,15 +1,12 @@
 macro(add_installation_script_test name path)
 
   # Copy the source to the binary tree
-  configure_file(
-    ${CMAKE_CURRENT_SOURCE_DIR}/${path}/${name}
-    ${CMAKE_CURRENT_BINARY_DIR}/${path}/${name}
-    COPYONLY
+  file( COPY "${CMAKE_CURRENT_SOURCE_DIR}/${path}/${name}" DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/${path}"
+    FILE_PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE
+    DIRECTORY_PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE
   )
-  configure_file(
-    ${CMAKE_CURRENT_SOURCE_DIR}/${path}/${name}-usage
-    ${CMAKE_CURRENT_BINARY_DIR}/${path}/${name}-usage
-    COPYONLY
+  file( COPY "${CMAKE_CURRENT_SOURCE_DIR}/${path}/${name}-usage" DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/${path}"
+    FILE_PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ
   )
   add_test(NAME test-${name} COMMAND "${CMAKE_BINARY_DIR}/${path}/${name}")
   set_property(TEST test-${name} PROPERTY WORKING_DIRECTORY "${CMAKE_BINARY_DIR}/${path}")

src/mpi/CMakeLists.txt

@@ -76,7 +76,7 @@ set(exe_dir ${CMAKE_BINARY_DIR}/bin_staging)
 set(compiler_wrapper ${exe_dir}/caf)
 install(
     FILES "${compiler_wrapper}"
-    PERMISSIONS WORLD_EXECUTE WORLD_READ OWNER_EXECUTE OWNER_READ GROUP_EXECUTE GROUP_READ
+    PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE
     DESTINATION "${CMAKE_INSTALL_BINDIR}"
 )
 file(READ ${CMAKE_CURRENT_SOURCE_DIR}/../extensions/caf-head CAF_HEADER)
@@ -109,7 +109,7 @@ file(APPEND "${compiler_wrapper}" "${FOOTER}")
 set(caf_launcher ${exe_dir}/cafrun)
 install(
     FILES "${caf_launcher}"
-    PERMISSIONS WORLD_EXECUTE WORLD_READ OWNER_EXECUTE OWNER_READ GROUP_EXECUTE GROUP_READ
+    PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE
     DESTINATION "${CMAKE_INSTALL_BINDIR}"
 )
 file(READ ${CMAKE_CURRENT_SOURCE_DIR}/../extensions/cafrun-head CAFRUN_HEADER)

src/tests/unit/extensions/CMakeLists.txt

@@ -31,7 +31,7 @@ function(generate_test_script base_name num_images)
   endif()
   file(APPEND "${harness}" "${CMAKE_INSTALL_PREFIX}/bin/cafrun -np ${num_images} ./${executable}\n")
   file( INSTALL "${harness}"
-    PERMISSIONS WORLD_EXECUTE WORLD_READ OWNER_EXECUTE OWNER_READ GROUP_EXECUTE GROUP_READ
+    PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE
     DESTINATION ${CMAKE_CURRENT_BINARY_DIR}
   )