Skip to content

Commit 4fb8454

Browse files
committed
Enhance debug logging.
1 parent b3d65d5 commit 4fb8454

File tree

1 file changed

+24
-6
lines changed

1 file changed

+24
-6
lines changed

src/runtime-libraries/mpi/mpi_caf.c

Lines changed: 24 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,19 @@ static char *caf_ref_type_str[] = {
6969
#define dprint(...)
7070
#define chk_err(...)
7171
#else
72+
#ifdef GCC_GE_15
73+
#define dprint(format, ...) \
74+
fprintf(stderr, "%d/%d (t(%d):%d/%d): %s(%d) " format, \
75+
global_this_image + 1, global_num_images, \
76+
current_team ? current_team->team_list_elem->team_id : -99, \
77+
caf_this_image, caf_num_images, __FUNCTION__, __LINE__, \
78+
##__VA_ARGS__)
79+
#else
7280
#define dprint(format, ...) \
73-
fprintf(stderr, "%d/%d (t:%d/%d): %s(%d) " format, global_this_image + 1, \
81+
fprintf(stderr, "%d/%d (%d/%d): %s(%d) " format, global_this_image + 1, \
7482
global_num_images, caf_this_image, caf_num_images, __FUNCTION__, \
7583
__LINE__, ##__VA_ARGS__)
84+
#endif
7685
#define chk_err(ierr) \
7786
do \
7887
{ \
@@ -2384,13 +2393,11 @@ PREFIX(deregister)(caf_token_t *token, int *stat, char *errmsg,
23842393
if (cur->token == *token)
23852394
{
23862395
p = TOKEN(*token);
2387-
#ifdef GCC_GE_7
2388-
dprint("Found regular token %p for memptr_win: %d.\n", *token,
2389-
((mpi_caf_token_t *)*token)->memptr_win);
2390-
#endif
2396+
dprint("Found regular token %p for memptr_win: %d.\n", *token, *p);
23912397
CAF_Win_unlock_all(*p);
23922398
ierr = MPI_Win_free(p);
23932399
chk_err(ierr);
2400+
dprint("Window destroyed.\n");
23942401

23952402
if (cur == current_team->allocated_tokens)
23962403
current_team->allocated_tokens = cur->next;
@@ -2536,7 +2543,13 @@ PREFIX(sync_all)(int *stat, char *errmsg, charlen_t errmsg_len)
25362543
ierr = MPI_Barrier(CAF_COMM_WORLD);
25372544
chk_err(ierr);
25382545
#endif
2539-
dprint("MPI_Barrier = %d.\n", err);
2546+
dprint("Sync all on team %d, MPI_Barrier = %d.\n",
2547+
#ifdef GCC_GE_15
2548+
current_team->team_list_elem->team_id,
2549+
#else
2550+
-1,
2551+
#endif
2552+
err);
25402553
if (ierr == STAT_FAILED_IMAGE)
25412554
err = STAT_FAILED_IMAGE;
25422555
else if (ierr != 0)
@@ -10448,6 +10461,7 @@ PREFIX(change_team)(caf_team_t team, int *stat, char *errmsg,
1044810461
chk_err(ierr);
1044910462
ierr = MPI_Barrier(CAF_COMM_WORLD);
1045010463
chk_err(ierr);
10464+
dprint("changed to team %d.\n", current_team->team_list_elem->team_id);
1045110465
}
1045210466
#else
1045310467
void
@@ -10582,6 +10596,7 @@ PREFIX(end_team)(int *stat, char *errmsg, charlen_t errmsg_len)
1058210596
return;
1058310597
}
1058410598

10599+
dprint("ending team %d.\n", ending_team->team_list_elem->team_id);
1058510600
for (struct allocated_tokens_t *ac = current_team->allocated_tokens; ac;)
1058610601
{
1058710602
struct allocated_tokens_t *nac = ac->next;
@@ -10601,6 +10616,7 @@ PREFIX(end_team)(int *stat, char *errmsg, charlen_t errmsg_len)
1060110616
ierr = MPI_Comm_size(CAF_COMM_WORLD, &caf_num_images);
1060210617
chk_err(ierr);
1060310618
free(ending_team);
10619+
dprint("switched to team %d.\n", current_team->team_list_elem->team_id);
1060410620
}
1060510621
#else
1060610622
void
@@ -10660,8 +10676,10 @@ PREFIX(sync_team)(caf_team_t team, int *stat, char *errmsg,
1066010676
return;
1066110677
}
1066210678

10679+
dprint("syncing team %d.\n", current_team->team_list_elem->team_id);
1066310680
int ierr = MPI_Barrier(team_to_sync->communicator);
1066410681
chk_err(ierr);
10682+
dprint("synced team %d.\n", current_team->team_list_elem->team_id);
1066510683
}
1066610684
#else
1066710685
void

0 commit comments

Comments
 (0)