Skip to content

Commit 67c6f94

Browse files
authored
Merge pull request #247 from sourceryinstitute/exclude-assembly
Add option to disable tests with assembly/binary Fixes #247
2 parents b5429ad + 611c014 commit 67c6f94

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ if(opencoarrays_aware_compiler)
209209
add_mpi_test(co_reduce 4 ${tests_root}/unit/collectives/co_reduce_test)
210210
add_mpi_test(syncimages_status 32 ${tests_root}/unit/sync/syncimages_status)
211211
add_mpi_test(simpleatomics 32 ${tests_root}/unit/simple/atomics)
212-
# I think there is a logic error in the following test
212+
# possible logic error in the following test
213213
# add_mpi_test(increment_my_neighbor 32 ${tests_root}/unit/simple/increment_my_neighbor)
214214

215215
# Integration tests verifying the use of libcaf_mpi in applications
@@ -218,7 +218,7 @@ if(opencoarrays_aware_compiler)
218218
add_mpi_test(co_heat 2 ${tests_root}/integration/pde_solvers/coarrayHeatSimplified/co_heat)
219219
add_mpi_test(asynchronous_hello_world 2 ${tests_root}/integration/events/asynchronous_hello_world)
220220
if ( ("${CMAKE_SYSTEM_PROCESSOR}" MATCHES "x86_64") AND ("${CMAKE_SYSTEM_NAME}" MATCHES "Linux") )
221-
if ( NOT (DEFINED ENV{TRAVIS}))
221+
if ( (NOT (DEFINED ENV{TRAVIS})) AND (NOT SKIP_ASSEMBLY_DEPS) )
222222
add_mpi_test(coarray_navier_stokes 2 ${tests_root}/integration/pde_solvers/navier-stokes/coarray_navier_stokes)
223223
set_property(TEST coarray_navier_stokes PROPERTY PASS_REGULAR_EXPRESSION "Test passed.")
224224
endif()

src/tests/CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
if ("${CMAKE_SYSTEM_NAME}" MATCHES "Linux")
22
option(HIGH_RESOLUTION_TIMER "use the walltime.o wallclock timer" FALSE)
33
option(LEGACY_ARCHITECTURE "use the SSE-enabled FFT library" FALSE)
4+
5+
# Let package maintainers disable fft library written in assembly
6+
option ( SKIP_ASSEMBLY_DEPS "Skip buidling/running tests that depend on files written in assembly" FALSE )
47
endif()
58

69
if (HIGH_RESOLUTION_TIMER)

src/tests/integration/pde_solvers/navier-stokes/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# checking whether the machine is of type 64-bit before proceeding further
22
if ( ("${CMAKE_SYSTEM_PROCESSOR}" MATCHES "x86_64") AND ("${CMAKE_SYSTEM_NAME}" MATCHES "Linux") )
33
# Default to older SSE-instruction-based FFT library
4-
if (NOT (DEFINED ENV{TRAVIS}))
4+
if (NOT (DEFINED ENV{TRAVIS}) AND (NOT SKIP_ASSEMBLY_DEPS) )
55
if (LEGACY_ARCHITECTURE OR (NOT DEFINED(LEGACY_ARCHITECTURE)))
66
set(fft_library ${CMAKE_CURRENT_SOURCE_DIR}/libfft_sse.a )
77
else()

0 commit comments

Comments
 (0)