Make test names more meaningful

 Also add some comments

Author: zbeekman

CMakeLists.txt

@@ -595,9 +595,9 @@ if(opencoarrays_aware_compiler)
     add_mpi_test(get-put-alloc-comp 3 ${tests_root}/regression/reported/issue-422-send-get)
   endif()
 
-  add_mpi_test(event_post_1 4 ${tests_root}/unit/events/event_post_1)
+  add_mpi_test(allocatable_p2p_event_post 4 ${tests_root}/unit/events/allocatable_p2p_event_post)
   # Fixed GCC 7 regressions, should run on GCC 6 and 7
-  add_mpi_test(event_post_2 3 ${tests_root}/unit/events/event_post_2)
+  add_mpi_test(static_event_post_issue_293 3 ${tests_root}/unit/events/static_event_post_issue_293)
 
   # These co_reduce (#172, fixed by PR #332, addl discussion in PR
   # #331) tests are for bugs not regressions. Should be fixed in all

src/tests/unit/events/CMakeLists.txt

@@ -1,8 +1,8 @@
 # Fortran tests
 
-add_executable(event_post_1 event_post_1.f90)
-target_link_libraries(event_post_1 OpenCoarrays)
+add_executable(allocatable_p2p_event_post allocatable_p2p_event_post.f90)
+target_link_libraries(allocatable_p2p_event_post OpenCoarrays)
 
-add_executable(event_post_2 event_post_2.f90)
-target_link_libraries(event_post_2 OpenCoarrays)
+add_executable(static_event_post_issue_293 static_event_post_issue_293.f90)
+target_link_libraries(static_event_post_issue_293 OpenCoarrays)
 

src/tests/unit/events/allocatable_p2p_event_post.f90

@@ -0,0 +1,60 @@
+! BSD 3-Clause License
+!
+! Copyright (c) 2016, Sourcery Institute
+! All rights reserved.
+!
+! Redistribution and use in source and binary forms, with or without
+! modification, are permitted provided that the following conditions are met:
+!
+! * Redistributions of source code must retain the above copyright notice, this
+!   list of conditions and the following disclaimer.
+!
+! * Redistributions in binary form must reproduce the above copyright notice,
+!   this list of conditions and the following disclaimer in the documentation
+!   and/or other materials provided with the distribution.
+!
+! * Neither the name of the copyright holder nor the names of its
+!   contributors may be used to endorse or promote products derived from
+!   this software without specific prior written permission.
+!
+! THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+! AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+! IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+! DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+! FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+! DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+! SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+! CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+! OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+! OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+! Comments preceded by "!!" are formatted for the FORD docoumentation generator
+program allocatable_p2p_event_post
+  !! author: Andre Vehreschild
+  !! date: 2017-08-05
+  !! category: unit-test
+  !! Basic events test testing receipt of event post from one image to another
+  use iso_fortran_env, only: event_type
+  implicit none
+
+  type(event_type), allocatable :: snd_copied(:)[:]
+
+  if (num_images() < 4) error stop "num_images() >= 4 required for even_post_1 test"
+  associate(me => this_image(), np => num_images())
+    allocate(snd_copied(np)[*])
+    if (me == 2) print*,'I am  image 2, I am posting to 4'
+    if (me == 2) event post(snd_copied(2)[4])
+    if (me == 2) print*,' I am image 2, I have posted to 4'
+    if (me == 4) then
+      event wait(snd_copied(2))
+      sync images(*) ! sync not required, but *may* expose cleanup issues/segfaults etc.
+      print *, 'Test passed.'
+    end if
+    if (me /= 4) then
+      sync images(4)
+      print *, 'I am', me, 'and image 4 told me it received the event'
+    end if
+    if (allocated(snd_copied)) deallocate(snd_copied)
+  end associate
+end program
+! vim:ts=2:sts=2:sw=2:

src/tests/unit/events/event_post_1.f90

@@ -29,7 +29,7 @@
 ! OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 ! Comments preceded by "!!" are formatted for the FORD docoumentation generator
-program main
+program static_event_post_issue_293
   !! author: Damian Rouson
   !! date: 2016-12-22
   !! category: regression
@@ -39,7 +39,7 @@ program main
   implicit none
   type(event_type) :: test_post[*]
 
-  if (num_images()<3) error stop "exposing issue 293 requires num_images()>=3"
+  if (num_images()<3) error stop "exposing issue 293 requires num_images() >= 3"
   event post(test_post)
   if (this_image()==1) print *,"Test passed."