Fix most warnings when compiling w/ clang

 - Issue with a type_def persists; non-constant member does not appear last

Author: zbeekman

src/libcaf-gfortran-descriptor.h

@@ -104,7 +104,7 @@ typedef struct gfc_descriptor_t {
 #endif
 
 #define GFC_DTYPE_SIZE_MASK \
-  ((~((ptrdiff_t) 0) >> GFC_DTYPE_SIZE_SHIFT) << GFC_DTYPE_SIZE_SHIFT)
+  ( ~((ptrdiff_t)(1 << GFC_DTYPE_SIZE_SHIFT) - 1)) // least significant bits to 0
 #define GFC_DTYPE_TYPE_SIZE_MASK (GFC_DTYPE_SIZE_MASK | GFC_DTYPE_TYPE_MASK)
 
 #define GFC_DTYPE_INTEGER_1 ((BT_INTEGER << GFC_DTYPE_TYPE_SHIFT) \

src/mpi/mpi_caf.c

@@ -6304,7 +6304,8 @@ PREFIX(is_present) (caf_token_t token, int image_index, caf_reference_t *refs)
               /* The first descriptor is accessible by the
               mpi_token->memptr_win.
               Count the dims to fetch.  */
-              for (ref_rank = 0; riter->u.a.mode[ref_rank] != CAF_ARR_REF_NONE; ++ref_rank) ;
+              for (ref_rank = 0; riter->u.a.mode[ref_rank] != CAF_ARR_REF_NONE; ++ref_rank)
+		;
               dprint ("%d/%d: %s() Getting remote descriptor of rank %d from win: %p, sizeof() %d\n",
                       caf_this_image, caf_num_images, __FUNCTION__,
                       ref_rank, mpi_token->memptr_win, sizeof_desc_for_rank(ref_rank));
@@ -6317,7 +6318,8 @@ PREFIX(is_present) (caf_token_t token, int image_index, caf_reference_t *refs)
             {
               /* All inner descriptors go by the dynamic window.
               Count the dims to fetch.  */
-              for (ref_rank = 0; riter->u.a.mode[ref_rank] != CAF_ARR_REF_NONE; ++ref_rank) ;
+              for (ref_rank = 0; riter->u.a.mode[ref_rank] != CAF_ARR_REF_NONE; ++ref_rank)
+		;
               dprint ("%d/%d: %s() Getting remote descriptor of rank %d from: %p, sizeof() %d\n",
                       caf_this_image, caf_num_images, __FUNCTION__,
                       ref_rank, remote_base_memptr, sizeof_desc_for_rank(ref_rank));