fix shellcheck issues in build_and_install.sh

Author: Damian Rouson

prerequisites/build-functions/build_and_install.sh

@@ -21,7 +21,7 @@ build_and_install()
   fi
   mkdir -p "${build_path}"
   info "pushd ${build_path}"
-  pushd "${build_path}"
+  pushd "${build_path}" || emergency "build_and_install.sh: pushd failed"
 
   if [[ "${package_to_build}" != "gcc" ]]; then
 
@@ -46,7 +46,7 @@ build_and_install()
       export cmake_binary_installer="${download_path}/cmake-${version_to_build}-Linux-x86_64.sh"
       ${SUDO:-} mkdir -p "$install_path"
       chmod u+x "${cmake_binary_installer}"
-      if [[ ! -z "${SUDO:-}" ]]; then
+      if [[ -n "${SUDO:-}" ]]; then
         info "You do not have write permissions to the installation path ${install_path}"
         info "If you have administrative privileges, enter your password to install ${package_to_build}"
       fi
@@ -63,7 +63,7 @@ build_and_install()
       info "FC=\"${FC:-'gfortran'}\" CC=\"${CC:-'gcc'}\" CXX=\"${CXX:-'g++'}\" make -j\"${num_threads}\""
       FC="${FC:-'gfortran'}" CC="${CC:-'gcc'}" CXX="${CXX:-'g++'}" make "-j${num_threads}"
       info "Installing ${package_to_build} in ${install_path}"
-      if [[ ! -z "${SUDO:-}" ]]; then
+      if [[ -n "${SUDO:-}" ]]; then
         info "You do not have write permissions to the installation path ${install_path}"
         info "If you have administrative privileges, enter your password to install ${package_to_build}"
       fi
@@ -75,7 +75,7 @@ build_and_install()
   elif [[ ${package_to_build} == "gcc" ]]; then
 
     info "pushd ${download_path}/${package_source_directory} "
-    pushd "${download_path}/${package_source_directory}"
+    pushd "${download_path}/${package_source_directory}" || emergency "build_and_install.sh: pushd failed"
 
     # Patch gfortran if necessary
     export patches_dir="${OPENCOARRAYS_SRC_DIR}/prerequisites/build-functions/patches/${package_to_build}/${version_to_build}"
@@ -96,13 +96,13 @@ build_and_install()
     "${PWD}"/contrib/download_prerequisites
 
     info "popd"
-    popd
+    popd || emergency "build_and_install.sh: popd failed"
     info "Configuring gcc/g++/gfortran builds with the following command:"
     info "${download_path}/${package_source_directory}/configure --prefix=${install_path} --enable-languages=c,c++,fortran,lto --disable-multilib --disable-werror ${bootstrap_configure}"
-    "${download_path}/${package_source_directory}/configure" --prefix="${install_path}" --enable-languages=c,c++,fortran,lto --disable-multilib --disable-werror ${bootstrap_configure}
+    "${download_path}/${package_source_directory}/configure" --prefix="${install_path}" --enable-languages=c,c++,fortran,lto --disable-multilib --disable-werror "${bootstrap_configure}"
     info "Building with the following command: 'make -j${num_threads} ${bootstrap_build}'"
-    make "-j${num_threads}" ${bootstrap_build}
-    if [[ ! -z "${SUDO:-}" ]]; then
+    make "-j${num_threads}" "${bootstrap_build}"
+    if [[ -n "${SUDO:-}" ]]; then
       info "You do not have write permissions to the installation path ${install_path}"
       info "If you have administrative privileges, enter your password to install ${package_to_build}"
     fi
@@ -115,5 +115,5 @@ build_and_install()
 
 
   info "popd"
-  popd
+  popd || emergency "build_and_install.sh: popd failed"
 }