Skip to content

Commit ed1b236

Browse files
committed
Partially revert d5655ab
- Older CMake's FindMPI.cmake doesn't have MPIEXEC_EXECUTABLE :-(
1 parent 8ec7fe0 commit ed1b236

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -244,13 +244,13 @@ endif()
244244

245245
find_package( MPI )
246246

247-
if ( (NOT MPI_C_FOUND) OR (NOT MPI_Fortran_FOUND) OR (NOT MPIEXEC_EXECUTABLE))
247+
if ( (NOT MPI_C_FOUND) OR (NOT MPI_Fortran_FOUND) OR (NOT MPIEXEC))
248248
# Get default install location of MPICH from install.sh
249249
message(WARNING "Could not find all MPI components!")
250250
message(WARNING "
251251
MPI_C_FOUND = ${MPI_C_FOUND}
252252
MPI_Fortran_FOUND = ${MPI_Fortran_FOUND}
253-
MPIEXEC_EXECUTABLE = ${MPIEXEC_EXECUTABLE}
253+
MPIEXEC = ${MPIEXEC}
254254
")
255255
execute_process( COMMAND "./install.sh" -P mpich
256256
WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}"
@@ -268,7 +268,7 @@ endif()
268268
list(REMOVE_DUPLICATES MPI_Fortran_INCLUDE_PATH)
269269

270270
# Test for consistent MPI environment
271-
if (NOT MPIEXEC_EXECUTABLE)
271+
if (NOT MPIEXEC)
272272
message ( ERROR "CMake failed to find `mpiexec` or similar. If building with `./install.sh` please
273273
report this bug to the OpenCoarrays developers at
274274
https://github.com/sourceryinstitute/opencoarrays/issues, otherwise point CMake
@@ -277,7 +277,7 @@ else()
277277
add_definitions(-DHAVE_MPI)
278278
endif()
279279

280-
get_filename_component(MPIEXEC_RELATIVE_LOC "${MPIEXEC_EXECUTABLE}"
280+
get_filename_component(MPIEXEC_RELATIVE_LOC "${MPIEXEC}"
281281
PROGRAM)
282282
get_filename_component(MPIEXEC_ABS_LOC "${MPIEXEC_RELATIVE_LOC}"
283283
REALPATH)

prerequisites/install-functions/build_opencoarrays.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,15 @@ build_opencoarrays()
3737
if ! ((${#MPIEXEC_CANDIDATES[@]} >= 1)); then
3838
emergency "Could not find a suitable \`mpiexec\` in directory containing mpi wrappers (${MPICC%/*})"
3939
else
40-
MPIEXEC_EXECUTABLE="${MPIEXEC_CANDIDATES[0]}"
40+
MPIEXEC="${MPIEXEC_CANDIDATES[0]}"
4141
fi
4242

4343
source "${OPENCOARRAYS_SRC_DIR:-}/prerequisites/build-functions/set_or_print_installation_path.sh"
4444
set_or_print_installation_path
4545

4646
info "Configuring OpenCoarrays in ${PWD} with the command:"
47-
info "CC=\"${CC}\" FC=\"${FC}\" $CMAKE \"${opencoarrays_src_dir}\" \"${WDEVFLAG}\" -DCMAKE_INSTALL_PREFIX=\"${install_path}\" -DMPIEXEC_EXECUTABLE=\"${MPIEXEC_EXECUTABLE}\" -DMPI_C_COMPILER=\"${MPICC}\" -DMPI_Fortran_COMPILER=\"${MPIFC}\""
48-
CC="${CC}" FC="${FC}" $CMAKE "${opencoarrays_src_dir}" "${WDEVFLAG}" -DCMAKE_INSTALL_PREFIX="${install_path}" -DMPIEXEC_EXECUTABLE="${MPIEXEC_EXECUTABLE}" -DMPI_C_COMPILER="${MPICC}" -DMPI_Fortran_COMPILER="${MPIFC}"
47+
info "CC=\"${CC}\" FC=\"${FC}\" $CMAKE \"${opencoarrays_src_dir}\" \"${WDEVFLAG}\" -DCMAKE_INSTALL_PREFIX=\"${install_path}\" -DMPIEXEC=\"${MPIEXEC}\" -DMPI_C_COMPILER=\"${MPICC}\" -DMPI_Fortran_COMPILER=\"${MPIFC}\""
48+
CC="${CC}" FC="${FC}" $CMAKE "${opencoarrays_src_dir}" "${WDEVFLAG}" -DCMAKE_INSTALL_PREFIX="${install_path}" -DMPIEXEC="${MPIEXEC}" -DMPI_C_COMPILER="${MPICC}" -DMPI_Fortran_COMPILER="${MPIFC}"
4949
info "Building OpenCoarrays in ${PWD} with the command make -j${num_threads}"
5050
make "-j${num_threads}"
5151
if [[ ! -z ${SUDO:-} ]]; then

src/extensions/cafrun.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,12 @@ set -o pipefail
5050
# Configured variables
5151
#---------------------
5252
#
53-
# CAF_VERSION, MPIEXEC_EXECUTABLE, MPIEXEC_NUMPROC_FLAG, MPIEXEC_PREFLAGS, MPIEXEC_POSTFLAGS,
53+
# CAF_VERSION, MPIEXEC, MPIEXEC_NUMPROC_FLAG, MPIEXEC_PREFLAGS, MPIEXEC_POSTFLAGS,
5454
# HAVE_FAILED_IMG
5555
#
5656

5757
caf_version='@CAF_VERSION@'
58-
CAFRUN="@MPIEXEC_EXECUTABLE@"
58+
CAFRUN="@MPIEXEC@"
5959
if [[ "${CAFRUN}" == @*@ ]]; then
6060
CAFRUN=mpiexec
6161
fi

src/mpi/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ cmake_host_system_information(RESULT N_CPU QUERY NUMBER_OF_LOGICAL_CORES)
1515
set(N_CPU ${N_CPU} PARENT_SCOPE)
1616
cmake_host_system_information(RESULT HOST_NAME QUERY HOSTNAME)
1717
set(HOSTNAME ${HOSTNAME} PARENT_SCOPE)
18-
execute_process(COMMAND ${MPIEXEC_EXECUTABLE} --version
18+
execute_process(COMMAND ${MPIEXEC} --version
1919
OUTPUT_VARIABLE mpi_version_out)
2020
if (mpi_version_out MATCHES "[Oo]pen[ -][Mm][Pp][Ii]")
2121
message( STATUS "OpenMPI detected")
@@ -249,7 +249,7 @@ configure_file("${CMAKE_SOURCE_DIR}/src/extensions/caf.in" "${CMAKE_BINARY_DIR}/
249249

250250
# List of carrun.in variables needing configuration:
251251
#
252-
# @CAF_VERSION@ @MPIEXEC_EXECUTABLE@ @MPIEXEC_NUMPROC_FLAG@ @MPIEXEC_PREFLAGS@ @MPIEXEC_POSTFLAGS@
252+
# @CAF_VERSION@ @MPIEXEC@ @MPIEXEC_NUMPROC_FLAG@ @MPIEXEC_PREFLAGS@ @MPIEXEC_POSTFLAGS@
253253
# @HAVE_FAILED_IMG@
254254
#
255255

0 commit comments

Comments
 (0)