Skip to content

Commit f31b1a5

Browse files
committed
Address shellcheck issues in install-functions
1 parent 04e2b95 commit f31b1a5

File tree

5 files changed

+109
-106
lines changed

5 files changed

+109
-106
lines changed

prerequisites/install-functions/build_opencoarrays.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,21 @@
1+
# shellcheck disable=SC2154
12
build_opencoarrays()
23
{
34
print_header
45
info "find_or_install mpich"
56
find_or_install mpich
67
info "find_or_install cmake"
78
find_or_install cmake
8-
mkdir -p $build_path
9-
pushd $build_path
9+
mkdir -p "$build_path"
10+
pushd "$build_path"
1011
if [[ -z "$MPICC" || -z "$MPIFC" || -z "$CMAKE" ]]; then
1112
emergency "Empty MPICC=$MPICC or MPIFC=$MPIFC or CMAKE=$CMAKE [exit 90]"
1213
else
1314
info "Configuring OpenCoarrays in ${PWD} with the command:"
1415
info "CC=\"${MPICC}\" FC=\"${MPIFC}\" $CMAKE \"${opencoarrays_src_dir}\" -DCMAKE_INSTALL_PREFIX=\"${install_path}\""
1516
CC="${MPICC}" FC="${MPIFC}" $CMAKE "${opencoarrays_src_dir}" -DCMAKE_INSTALL_PREFIX="${install_path}"
1617
info "Building OpenCoarrays in ${PWD} with the command make -j${num_threads}"
17-
make -j${num_threads}
18+
make "-j${num_threads}"
1819
if [[ ! -z ${SUDO:-} ]]; then
1920
printf "\nThe chosen installation path requires sudo privileges. Please enter password if prompted.\n"
2021
fi

0 commit comments

Comments
 (0)