fix(test): rm associations to work around gfortran

Author: Damian Rouson

src/dag_s.f90

@@ -111,11 +111,11 @@ end function topological_sort
 
   module procedure construct_from_json
     type(fallible_json_value_t) :: maybe_vertices
+    type(error_list_t) errors
 
     maybe_vertices = json_object%get_element("vertices")
-    associate(errors => maybe_vertices%errors())
-      call assert(.not. errors%has_any(), "dag_s construct_from_json: .not. errors%has_any()", char(errors%to_string()))
-    end associate
+    errors = maybe_vertices%errors()
+    call assert(.not. errors%has_any(), "dag_s construct_from_json: .not. errors%has_any()", char(errors%to_string()))
 
     select type (vertices => maybe_vertices%value_())
     type is (json_array_t)
@@ -130,20 +130,18 @@ end function topological_sort
    module procedure to_json
      type(fallible_json_string_t) maybe_key
      type(error_list_t) errors
+     type(json_string_t) vertices_key
+     type(json_array_t) vertices_value
 
      maybe_key = fallible_json_string_t("vertices")
      errors = maybe_key%errors()
      call assert(.not. errors%has_any(), "dag%to_json: .not. errors%has_any()", char(errors%to_string()))
 
-     block
-       type(json_array_t) vertices_value
 
-       vertices_value = json_array_t(json_element_t(self%vertices%to_json()))
+     vertices_value = json_array_t(json_element_t(self%vertices%to_json()))
 
-       associate(vertices_key => maybe_key%string())
-         json_object = json_object_t([vertices_key], [json_element_t(vertices_value)])
-       end associate
-     end block
+     vertices_key = maybe_key%string()
+     json_object = json_object_t([vertices_key], [json_element_t(vertices_value)])
    end procedure
 
   module procedure num_vertices

test/dag_test.f90

@@ -66,12 +66,12 @@ function construct_dag_and_write_pdf() result(result_)
     character(len=*), parameter :: command = 'dot -Tpdf -o ' // pdf_file_name // ' ' // dot_file_name
     integer, parameter :: success=0
     integer exit_status, command_status
+    type(dag_t) modules
 
-    associate(modules => module_tree_from_components())
+    modules = module_tree_from_components()
       call modules%save_digraph(dot_file_name, 'RL', 300)
       call execute_command_line(command, wait=.true., exitstat=exit_status, cmdstat=command_status)
       result_ = assert_equals(success, exit_status) .and. assert_equals(success, command_status)
-    end associate
 
   end function
 
@@ -85,11 +85,11 @@ function construct_dag_and_json_object() result(result_)
          '{"label":"vertex_m","edges":[]},' // &
          '{"label":"dag_m","edges":[3]},' // &
          '{"label":"dag_s","edges":[4,1]}]}'
+    type(dag_t) dag
 
-    associate(dag => module_tree_from_components())
-      json_object = dag%to_json()
-      result_ = assert_equals(var_str(expected_json), json_object%to_compact_string())
-    end associate
+    dag = module_tree_from_components()
+    json_object = dag%to_json()
+    result_ = assert_equals(var_str(expected_json), json_object%to_compact_string())
 
   end function