fix: use proper debug mode detection#26
Merged
iBotPeaches merged 1 commit intomasterfrom Jan 28, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts debug-mode detection in the deployment script so additional diagnostic output is emitted when debugging is enabled, to help investigate task-definition JSON failures (Issue #25).
Changes:
- Switches debug gating from
ACTIONS_RUNNER_DEBUG == trueto checking whetherACTIONS_RUNNER_DEBUGis non-empty. - Applies the updated debug gating to both modified-task-definition output and diff output.
Comments suppressed due to low confidence (1)
deploy.sh:165
- The JSON validity check is currently incorrect:
jqis invoked without a filter (so it exits non-zero in standard jq), and the condition is not negated. As written, the "invalid JSON" branch is either never entered or entered on valid JSON (depending on jq behavior). Update this to run a real validation (e.g.,jq -e .against the file) and trigger the error branch only when validation fails.
if jq < "$TASK_DEFINITION_FILE" &> /dev/null; then
echo -e "${RED}Task Definition became invalid JSON after modifications (invalid_task_definition)."
if [ -n "$ACTIONS_RUNNER_DEBUG" ]; then
echo "::debug::Debug enabled. Outputting modified Task Definition file.";
cat "$TASK_DEFINITION_FILE"
fi
exit 1;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bankamah
approved these changes
Jan 28, 2026
erik-perri
approved these changes
Jan 28, 2026
jweberst
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating #25 I cannot see debug information :/